Skip to content

Commit 0ee114f

Browse files
committed
Clarifies return value in compareTo
1 parent 58777a8 commit 0ee114f

File tree

16 files changed

+16
-32
lines changed

16 files changed

+16
-32
lines changed

src/main/java/com/andrebreves/tuple/Tuple1.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ private static <T> int compare(T t1, T t2) {
6464
public int compareTo(Tuple1<T1> other) {
6565
int result;
6666
result = compare(v1, other.v1); if (result != 0) return result;
67-
68-
return result;
67+
return 0;
6968
}
7069

7170
}

src/main/java/com/andrebreves/tuple/Tuple10.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,7 @@ public int compareTo(Tuple10<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10> other) {
118118
result = compare(v8, other.v8); if (result != 0) return result;
119119
result = compare(v9, other.v9); if (result != 0) return result;
120120
result = compare(v10, other.v10); if (result != 0) return result;
121-
122-
return result;
121+
return 0;
123122
}
124123

125124
}

src/main/java/com/andrebreves/tuple/Tuple11.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,7 @@ public int compareTo(Tuple11<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11> other
124124
result = compare(v9, other.v9); if (result != 0) return result;
125125
result = compare(v10, other.v10); if (result != 0) return result;
126126
result = compare(v11, other.v11); if (result != 0) return result;
127-
128-
return result;
127+
return 0;
129128
}
130129

131130
}

src/main/java/com/andrebreves/tuple/Tuple12.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,7 @@ public int compareTo(Tuple12<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12>
130130
result = compare(v10, other.v10); if (result != 0) return result;
131131
result = compare(v11, other.v11); if (result != 0) return result;
132132
result = compare(v12, other.v12); if (result != 0) return result;
133-
134-
return result;
133+
return 0;
135134
}
136135

137136
}

src/main/java/com/andrebreves/tuple/Tuple13.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,7 @@ public int compareTo(Tuple13<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12,
136136
result = compare(v11, other.v11); if (result != 0) return result;
137137
result = compare(v12, other.v12); if (result != 0) return result;
138138
result = compare(v13, other.v13); if (result != 0) return result;
139-
140-
return result;
139+
return 0;
141140
}
142141

143142
}

src/main/java/com/andrebreves/tuple/Tuple14.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,7 @@ public int compareTo(Tuple14<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12,
142142
result = compare(v12, other.v12); if (result != 0) return result;
143143
result = compare(v13, other.v13); if (result != 0) return result;
144144
result = compare(v14, other.v14); if (result != 0) return result;
145-
146-
return result;
145+
return 0;
147146
}
148147

149148
}

src/main/java/com/andrebreves/tuple/Tuple15.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,7 @@ public int compareTo(Tuple15<T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12,
148148
result = compare(v13, other.v13); if (result != 0) return result;
149149
result = compare(v14, other.v14); if (result != 0) return result;
150150
result = compare(v15, other.v15); if (result != 0) return result;
151-
152-
return result;
151+
return 0;
153152
}
154153

155154
}

src/main/java/com/andrebreves/tuple/Tuple2.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,7 @@ public int compareTo(Tuple2<T1, T2> other) {
7070
int result;
7171
result = compare(v1, other.v1); if (result != 0) return result;
7272
result = compare(v2, other.v2); if (result != 0) return result;
73-
74-
return result;
73+
return 0;
7574
}
7675

7776
}

src/main/java/com/andrebreves/tuple/Tuple3.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@ public int compareTo(Tuple3<T1, T2, T3> other) {
7676
result = compare(v1, other.v1); if (result != 0) return result;
7777
result = compare(v2, other.v2); if (result != 0) return result;
7878
result = compare(v3, other.v3); if (result != 0) return result;
79-
80-
return result;
79+
return 0;
8180
}
8281

8382
}

src/main/java/com/andrebreves/tuple/Tuple4.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@ public int compareTo(Tuple4<T1, T2, T3, T4> other) {
8282
result = compare(v2, other.v2); if (result != 0) return result;
8383
result = compare(v3, other.v3); if (result != 0) return result;
8484
result = compare(v4, other.v4); if (result != 0) return result;
85-
86-
return result;
85+
return 0;
8786
}
8887

8988
}

0 commit comments

Comments
 (0)