You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,6 +1,6 @@
1
1
# Contributing to Abby
2
2
3
-
I want to make contributing to this project as easy and transparent as possible, whether it's:
3
+
This document contains basic guidelines to make contributing to this project as easy and transparent as possible, whether it's:
4
4
5
5
- Reporting a bug
6
6
- Discussing the current state of the code
@@ -38,7 +38,7 @@ All bugs are tracked using GitHub issues to track public bugs. Report a bug by [
38
38
39
39
## Use a Consistent Coding Style
40
40
41
-
I'm using the automatic formatter in the [PHP Intelephense](https://marketplace.visualstudio.com/items?itemName=bmewburn.vscode-intelephense-client) Visual Studio Code extension.
41
+
All code should follow the [PSR-12: Extended Coding Style](https://www.php-fig.org/psr/psr-12/)
42
42
43
43
* 4 spaces for indentation rather than tabs
44
44
* Newlines after opening curly brackets in classes and methods
Copy file name to clipboardExpand all lines: docs/Group.md
+11-13Lines changed: 11 additions & 13 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,6 +1,6 @@
1
1
# Group
2
2
3
-
This class is in charge of creating and handling the control and variation groups of an experiment, including getting and setting their values such as group type, size, number of conversions, and whether the group is the winning or losing variant.
3
+
This class is in charge of creating and handling the control and variation groups of an experiment, including getting and setting their values such as group type, numbers of views and conversions, and whether the group is the winning or losing variant.
4
4
5
5
| Name | Description |
6
6
|------|-------------|
@@ -9,8 +9,8 @@ This class is in charge of creating and handling the control and variation group
9
9
|[setValue](#groupsetvalue)|Set property value of group|
10
10
|[getName](#groupgetname)|Get group name|
11
11
|[setName](#groupsetname)|Set group name|
12
-
|[getSize](#groupgetsize)|Get group size|
13
-
|[setSize](#groupsetsize)|Set group size|
12
+
|[getViews](#groupgetviews)|Get group views|
13
+
|[setViews](#groupsetviews)|Set group views|
14
14
|[getConversions](#groupgetconversions)|Get number of conversions for the group|
15
15
|[setConversions](#groupsetconversions)|Set number of conversions for the group|
16
16
|[getConversionRate](#groupgetconversionrate)|Get conversion rate for the group|
@@ -127,15 +127,15 @@ Set group name
127
127
128
128
<hr />
129
129
130
-
## Group::getSize
130
+
## Group::getViews
131
131
132
132
**Description**
133
133
134
134
```php
135
-
public getSize (void)
135
+
public getViews (void)
136
136
```
137
137
138
-
Get group size
138
+
Get group views
139
139
140
140
**Parameters**
141
141
@@ -147,19 +147,19 @@ Get group size
147
147
148
148
<hr />
149
149
150
-
## Group::setSize
150
+
## Group::setViews
151
151
152
152
**Description**
153
153
154
154
```php
155
-
public setSize (int $size)
155
+
public setViews (int $views)
156
156
```
157
157
158
-
Set group size
158
+
Set group views
159
159
160
160
**Parameters**
161
161
162
-
*`(int) $size`
162
+
*`(int) $views`
163
163
164
164
**Return Values**
165
165
@@ -445,6 +445,4 @@ Define the group as the variation
Copy file name to clipboardExpand all lines: docs/Result.md
+2-4Lines changed: 2 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -235,7 +235,7 @@ public isSignificant (void)
235
235
236
236
Return whether the result is statistically significant
237
237
238
-
This requires both the confidence (alternative hypothesis, i.e the inverse of the p-value) to be high enough (based on the specified minimum confidence) that the null hypothesis can be rejected, and the size of both groups to be greater than or equal to the minimum sample size (which is in turn calculated based on the minimum detectable effect, and the conversion rate of the control group)
238
+
This requires both the confidence (alternative hypothesis, i.e the inverse of the p-value) to be high enough (based on the specified minimum confidence) that the null hypothesis can be rejected, and the number of views for both groups to be greater than or equal to the minimum sample size (which is in turn calculated based on the minimum detectable effect, and the conversion rate of the control group)
0 commit comments