Only auto-repeat navigational keys in menus

This reduces sound spam and, for gamepads, rumble spam.
Particularly noticeable while holding +altmodifier when changing bindings.

Author: andrei-drexler

Quake/keys.c

@@ -1275,7 +1275,7 @@ void Key_EventWithKeycode (int key, qboolean down, int keycode)
 			Key_Message (key);
 			break;
 		case key_menu:
-			M_Keydown (key);
+			M_Keydown (key, wasdown);
 			break;
 		case key_game:
 		case key_console:
@@ -1403,7 +1403,7 @@ void Key_EventWithKeycode (int key, qboolean down, int keycode)
 		Key_Message (key);
 		break;
 	case key_menu:
-		M_Keydown (key);
+		M_Keydown (key, wasdown);
 		break;
 
 	case key_game:

Quake/menu.c

@@ -7253,7 +7253,7 @@ void M_Draw (void)
 }
 
 
-void M_Keydown (int key)
+void M_Keydown (int key, qboolean repeat)
 {
 	if (!bind_grab && !ui_mouse.value && M_IsMouseKey (key))
 		return;
@@ -7272,6 +7272,24 @@ void M_Keydown (int key)
 		}
 	}
 
+	// only allow repeat events for a few navigational keys
+	// this reduces sound spam and, for gamepads, rumble spam
+	// (particularly noticeable while holding the alt modifier when changing bindings)
+	if (repeat)
+	{
+		switch (key)
+		{
+		case K_UPARROW:
+		case K_DOWNARROW:
+		case K_LEFTARROW:
+		case K_RIGHTARROW:
+		case K_ESCAPE:
+			break;
+		default:
+			return;
+		}
+	}
+
 	switch (M_GetBaseState (m_state))
 	{
 	default:

Quake/menu.h

@@ -61,7 +61,7 @@ extern qboolean m_entersound;
 // menus
 //
 void M_Init (void);
-void M_Keydown (int key);
+void M_Keydown (int key, qboolean repeat);
 void M_Charinput (int key);
 void M_Mousemove (int x, int y);
 enum textmode_t M_TextEntry (void);