v4.1.0 Fixing issues with APN

Author: andrei-m-code

CorePush/Apple/ApnSender.cs

@@ -98,14 +98,13 @@ public async Task<ApnsResponse> SendAsync(
 
         using var response = await http.SendAsync(message, cancellationToken);
 
-        var succeed = response.IsSuccessStatusCode;
+        var success = response.IsSuccessStatusCode;
         var content = await response.Content.ReadAsStringAsync(cancellationToken);
-        var error = serializer.Deserialize<ApnsError>(content);
 
         return new ApnsResponse
         {
-            IsSuccess = succeed,
-            Error = error
+            IsSuccess = success,
+            Error = success ? null : serializer.Deserialize<ApnsError>(content)
         };
     }
 

CorePush/Apple/ApnsResponse.cs

@@ -9,41 +9,44 @@ public class ApnsResponse
 
 public class ApnsError
 {
-    public ReasonEnum Reason {get; set;}
+    /// <summary>
+    /// Use <see cref="ApnsErrorReasons"/> to compare against
+    /// </summary>
+    public string Reason {get; set;}
     public long? Timestamp {get; set; }
 }
 
 /// <summary>
 /// https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CommunicatingwithAPNs.html#//apple_ref/doc/uid/TP40008194-CH11-SW15
 /// </summary>
-public enum ReasonEnum
+public static class ApnsErrorReasons
 {
-    BadCollapseId,
-    BadDeviceToken,
-    BadExpirationDate,
-    BadMessageId,
-    BadPriority,
-    BadTopic,
-    DeviceTokenNotForTopic,
-    DuplicateHeaders,
-    IdleTimeout,
-    MissingDeviceToken,
-    MissingTopic,
-    PayloadEmpty,
-    TopicDisallowed,
-    BadCertificate,
-    BadCertificateEnvironment,
-    ExpiredProviderToken,
-    Forbidden,
-    InvalidProviderToken,
-    MissingProviderToken,
-    BadPath,
-    MethodNotAllowed,
-    Unregistered,
-    PayloadTooLarge,
-    TooManyProviderTokenUpdates,
-    TooManyRequests,
-    InternalServerError,
-    ServiceUnavailable,
-    Shutdown,  
+    public const string BadCollapseId = "BadCollapseId";
+    public const string BadDeviceToken = "BadDeviceToken";
+    public const string BadExpirationDate = "BadExpirationDate";
+    public const string BadMessageId = "BadMessageId";
+    public const string BadPriority = "BadPriority";
+    public const string BadTopic = "BadTopic";
+    public const string DeviceTokenNotForTopic = "DeviceTokenNotForTopic";
+    public const string DuplicateHeaders = "DuplicateHeaders";
+    public const string IdleTimeout = "IdleTimeout";
+    public const string MissingDeviceToken = "MissingDeviceToken";
+    public const string MissingTopic = "MissingTopic";
+    public const string PayloadEmpty = "PayloadEmpty";
+    public const string TopicDisallowed = "TopicDisallowed";
+    public const string BadCertificate = "BadCertificate";
+    public const string BadCertificateEnvironment = "BadCertificateEnvironment";
+    public const string ExpiredProviderToken = "ExpiredProviderToken";
+    public const string Forbidden = "Forbidden";
+    public const string InvalidProviderToken = "InvalidProviderToken";
+    public const string MissingProviderToken = "MissingProviderToken";
+    public const string BadPath = "BadPath";
+    public const string MethodNotAllowed = "MethodNotAllowed";
+    public const string Unregistered = "Unregistered";
+    public const string PayloadTooLarge = "PayloadTooLarge";
+    public const string TooManyProviderTokenUpdates = "TooManyProviderTokenUpdates";
+    public const string TooManyRequests = "TooManyRequests";
+    public const string InternalServerError = "InternalServerError";
+    public const string ServiceUnavailable = "ServiceUnavailable";
+    public const string Shutdown = "Shutdown";  
 }

CorePush/CorePush.csproj

@@ -10,9 +10,9 @@
     <Summary>Server Side library for sending ✅Web, ✅Android and ✅iOS Push Notifications</Summary>
     <Authors>andrei-m-code</Authors>
 
-    <AssemblyVersion>4.0.2</AssemblyVersion>
-    <FileVersion>4.0.2</FileVersion>
-    <Version>4.0.2</Version>
+    <AssemblyVersion>4.1.0</AssemblyVersion>
+    <FileVersion>4.1.0</FileVersion>
+    <Version>4.1.0</Version>
 
     <PackageProjectUrl>https://github.com/andrei-m-code/CorePush</PackageProjectUrl>
     <RepositoryUrl>https://github.com/andrei-m-code/CorePush</RepositoryUrl>
@@ -25,6 +25,12 @@
     <PackageTags>push-notifications android-push-notifications ios-push-notifications web-push web-push-notifications apn fcm firebase</PackageTags>
 
     <PackageReleaseNotes>
+v4.1.0
+- Bugfixing issues with APNS response handling
+      
+v4.0.2
+- Issues with Firebase configuration      
+      
 v4.0.1
 - Use .NET 7.0 as a target framework
 - Use System.Text.Json as a default serializer