feat: cleanup tests

Author: andrei-polukhin

connection_string_test.go

@@ -177,26 +177,22 @@ func TestReplaceDatabaseInConnectionStringErrorCases(t *testing.T) {
 		dbName  string
 
 		expected string
-	}{
-		{
-			name:     "malformed URL uses fallback",
-			connStr:  "postgres://user:pass@[invalid-ipv6:5432/postgres", // Invalid IPv6.
-			dbName:   "testdb",
-			expected: "postgres://user:pass@[invalid-ipv6:5432/testdb", // Fallback replacement.
-		},
-		{
-			name:     "DSN without dbname falls through to fallback",
-			connStr:  "host=localhost user=postgres port=5432", // No dbname.
-			dbName:   "testdb",
-			expected: "host=localhost user=postgres port=5432/testdb", // Fallback.
-		},
-		{
-			name:     "empty connection string",
-			connStr:  "",
-			dbName:   "testdb",
-			expected: "/testdb", // Fallback behavior.
-		},
-	}
+	}{{
+		name:     "malformed URL uses fallback",
+		connStr:  "postgres://user:pass@[invalid-ipv6:5432/postgres", // Invalid IPv6.
+		dbName:   "testdb",
+		expected: "postgres://user:pass@[invalid-ipv6:5432/testdb", // Fallback replacement.
+	}, {
+		name:     "DSN without dbname falls through to fallback",
+		connStr:  "host=localhost user=postgres port=5432", // No dbname.
+		dbName:   "testdb",
+		expected: "host=localhost user=postgres port=5432/testdb", // Fallback.
+	}, {
+		name:     "empty connection string",
+		connStr:  "",
+		dbName:   "testdb",
+		expected: "/testdb", // Fallback behavior.
+	}}
 
 	for _, test := range tests {
 		c.Run(test.name, func(c *qt.C) {

mock_test.go

@@ -34,7 +34,7 @@ func (m *sharedMockDatabaseConnection) ExecContext(ctx context.Context, query st
 			databases := m.provider.getDatabases()
 			if databases[dbName] {
 				mu.Unlock()
-				return nil, fmt.Errorf("database \"%s\" already exists", dbName)
+				return nil, fmt.Errorf("database %q already exists", dbName)
 			}
 			databases[dbName] = true
 			mu.Unlock()
@@ -43,10 +43,10 @@ func (m *sharedMockDatabaseConnection) ExecContext(ctx context.Context, query st
 		parts := strings.Fields(query)
 		var dbName string
 		if len(parts) >= 5 && parts[2] == "IF" && parts[3] == "EXISTS" {
-			// Handle "DROP DATABASE IF EXISTS dbname"
+			// Handle "DROP DATABASE IF EXISTS dbname".
 			dbName = strings.Trim(parts[4], `"`)
 		} else if len(parts) >= 3 {
-			// Handle "DROP DATABASE dbname"
+			// Handle "DROP DATABASE dbname".
 			dbName = strings.Trim(parts[2], `"`)
 		}
 		if dbName != "" {
@@ -56,9 +56,9 @@ func (m *sharedMockDatabaseConnection) ExecContext(ctx context.Context, query st
 			if databases[dbName] {
 				delete(databases, dbName)
 			} else if !(len(parts) >= 5 && parts[2] == "IF" && parts[3] == "EXISTS") {
-				// Only error if it's not an "IF EXISTS" query
+				// Only error if it's not an "IF EXISTS" query.
 				mu.Unlock()
-				return nil, fmt.Errorf("database \"%s\" does not exist", dbName)
+				return nil, fmt.Errorf("database %q does not exist", dbName)
 			}
 			mu.Unlock()
 		}
@@ -68,32 +68,6 @@ func (m *sharedMockDatabaseConnection) ExecContext(ctx context.Context, query st
 
 // QueryRowContext implements pgdbtemplate.DatabaseConnection.QueryRowContext.
 func (m *sharedMockDatabaseConnection) QueryRowContext(ctx context.Context, query string, args ...any) pgdbtemplate.Row {
-	if strings.Contains(query, "SELECT datname FROM pg_database WHERE NOT datistemplate") {
-		var dbs []any
-		mu := m.provider.getMutex()
-		mu.RLock()
-		databases := m.provider.getDatabases()
-		for db, exists := range databases {
-			if exists && db != "template0" && db != "template1" {
-				dbs = append(dbs, db)
-			}
-		}
-		mu.RUnlock()
-		return &sharedMockRow{data: dbs}
-	}
-	if strings.Contains(query, "SELECT datname FROM pg_database WHERE datistemplate") {
-		var dbs []any
-		mu := m.provider.getMutex()
-		mu.RLock()
-		databases := m.provider.getDatabases()
-		for db, exists := range databases {
-			if exists && (db == "template0" || db == "template1") {
-				dbs = append(dbs, db)
-			}
-		}
-		mu.RUnlock()
-		return &sharedMockRow{data: dbs}
-	}
 	if strings.Contains(query, "SELECT TRUE FROM pg_database WHERE datname") {
 		// Handle both parameterized and literal queries
 		if len(args) > 0 {

template_manager_test.go

@@ -338,7 +338,7 @@ func TestTemplateManagerCleanupErrorPaths(t *testing.T) {
 	err = tm.Cleanup(ctx)
 	c.Assert(err, qt.ErrorMatches, "(?s).*drop error.*drop error.*")
 
-	// Note: Using mock provider, no real databases created - cleanup not needed
+	// Note: Using mock provider, no real databases created - cleanup not needed.
 }
 
 // TestTemplateManagerDropTestDatabaseErrorPaths tests error handling in DropTestDatabase