Skip to content

Commit 6b9b1a8

Browse files
authored
Merge branch 'main' into grpc-snippet
2 parents 7c36d7e + b272252 commit 6b9b1a8

File tree

6 files changed

+53
-7
lines changed

6 files changed

+53
-7
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1313

1414
## Version 1.34.0/0.55b0 (2025-06-04)
1515

16+
### Fixed
17+
18+
- `opentelemetry-resource-detector-containerid`: make it more quiet on platforms without cgroups
19+
([#3579](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3579))
20+
1621
### Added
1722

1823
- `opentelemetry-instrumentation-aiokafka` Add instrumentation of `consumer.getmany` (batch)

docs/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
"https://opentelemetry-python.readthedocs.io/en/latest/",
123123
None,
124124
),
125-
"redis": ("https://redis-py.readthedocs.io/en/latest/", None),
125+
"redis": ("https://redis.readthedocs.io/en/latest/", None),
126126
}
127127

128128
# http://www.sphinx-doc.org/en/master/config.html#confval-nitpicky

instrumentation/opentelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid/__init__.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,8 @@
6565
from pyramid.config import Configurator
6666
from opentelemetry.instrumentation.pyramid import PyramidInstrumentor
6767
68-
settings = {
69-
'pyramid.tweens', 'opentelemetry.instrumentation.pyramid.trace_tween_factory\\nyour_tween_no_1\\nyour_tween_no_2',
70-
}
71-
config = Configurator(settings=settings)
68+
config = Configurator()
69+
config.add_tween('opentelemetry.instrumentation.pyramid.trace_tween_factory')
7270
PyramidInstrumentor().instrument_config(config)
7371
7472
# use your config as normal.

instrumentation/opentelemetry-instrumentation-wsgi/src/opentelemetry/instrumentation/wsgi/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ def GET(self):
9797
9898
.. code-block:: python
9999
100+
from opentelemetry.trace import Span
100101
from wsgiref.types import WSGIEnvironment, StartResponse
101102
from opentelemetry.instrumentation.wsgi import OpenTelemetryMiddleware
102103

resource/opentelemetry-resource-detector-containerid/src/opentelemetry/resource/detector/containerid/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def _get_container_id_v1():
4141
break
4242

4343
except FileNotFoundError as exception:
44-
logger.warning("Failed to get container id. Exception: %s", exception)
44+
logger.debug("Failed to get container id. Exception: %s", exception)
4545
return container_id
4646

4747

@@ -66,7 +66,7 @@ def _get_container_id_v2():
6666
break
6767

6868
except FileNotFoundError as exception:
69-
logger.warning("Failed to get container id. Exception: %s", exception)
69+
logger.debug("Failed to get container id. Exception: %s", exception)
7070
return container_id
7171

7272

resource/opentelemetry-resource-detector-containerid/tests/test_container.py

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,48 @@ def test_container_id_detect_from_mountinfo_file(
109109
actual.attributes.copy(), MockContainerResourceAttributes
110110
)
111111

112+
@patch(
113+
"opentelemetry.resource.detector.containerid._get_container_id_v1",
114+
return_value=None,
115+
)
116+
@patch(
117+
"builtins.open",
118+
side_effect=FileNotFoundError,
119+
)
120+
def test_cannot_read_mountinfo_file(
121+
self, mock_get_container_id_v1, mock_mountinfo_file
122+
):
123+
with self.assertLogs(
124+
"opentelemetry.resource.detector.containerid", level="DEBUG"
125+
) as cm:
126+
actual = ContainerResourceDetector().detect()
127+
self.assertFalse(actual.attributes.copy())
128+
self.assertIn(
129+
"DEBUG:opentelemetry.resource.detector.containerid:Failed to get container id. Exception: ",
130+
cm.output,
131+
)
132+
133+
@patch(
134+
"opentelemetry.resource.detector.containerid._get_container_id_v2",
135+
return_value=None,
136+
)
137+
@patch(
138+
"builtins.open",
139+
side_effect=FileNotFoundError,
140+
)
141+
def test_cannot_read_cgroup_file(
142+
self, mock_get_container_id_v2, mock_cgroup_file
143+
):
144+
with self.assertLogs(
145+
"opentelemetry.resource.detector.containerid", level="DEBUG"
146+
) as cm:
147+
actual = ContainerResourceDetector().detect()
148+
self.assertFalse(actual.attributes.copy())
149+
self.assertIn(
150+
"DEBUG:opentelemetry.resource.detector.containerid:Failed to get container id. Exception: ",
151+
cm.output,
152+
)
153+
112154
@patch(
113155
"opentelemetry.resource.detector.containerid._get_container_id",
114156
return_value=MockContainerResourceAttributes[

0 commit comments

Comments
 (0)