feat: default pre-commit hook now fixes all files

"pass_filenames: false" is the default now.
Choose one of the other hooks if you want a different behavior.

Author: andreoliwa

.pre-commit-hooks.yaml

@@ -1,29 +1,53 @@
 # https://pre-commit.com/#creating-new-hooks
+
+# This is the new default: to fix all files, NOT passing filenames to the hook.
+# The usage of "pass_filenames: false`` is not recommended by the authors of pre-commit,
+#  but it's the only way to make Nitpick work as intended.
+# See this comment for more context: https://github.com/andreoliwa/nitpick/pull/673/files#r1714086075
+# If this breaks your workflow, choose one of the other hooks below with "pass_filenames: true".
+
 - id: nitpick
-  name: "nitpick fix (auto fixing files)"
-  description: "Fix configuration files (TOML/INI/JSON/etc.) directly, according to the Nitpick style"
+  name: "nitpick fix (all files)"
+  description: "Fix configuration files (TOML/INI/JSON/etc.) directly, according to the Nitpick style. All files are considered by pre-commit."
   entry: nitpick fix
+  pass_filenames: false
   language: python
 
-- id: nitpick-suggest
-  name: "nitpick init --suggest (auto fixing files)"
-  description: "Suggest new Nitpick styles based on the files in the project root (skipping Git ignored files)"
-  entry: nitpick init --fix --suggest
-  language: python
-  # This  hook should NOT be run for changed Git files, otherwise they will be considered style URLS
-  # and will be added to [tool.nitpick]style in pyproject.toml
+# Same as nitpick, but with a more explicit name.
+- id: nitpick-fix-all
+  name: "nitpick fix (all files)"
+  description: "Fix configuration files (TOML/INI/JSON/etc.) directly, according to the Nitpick style. All files are considered by pre-commit."
+  entry: nitpick fix
   pass_filenames: false
-  always_run: true
+  language: python
 
-# This hook is kept for compatibility (or if one wants to be explicit): "nitpick" does the same as "nitpick-fix" now
 - id: nitpick-fix
-  name: "nitpick fix (auto fixing files)"
-  description: "Fix configuration files (TOML/INI/JSON/etc.) directly, according to the Nitpick style"
+  name: "nitpick fix (modified files only)"
+  description: "Fix configuration files (TOML/INI/JSON/etc.) directly, according to the Nitpick style. Only modified files are considered by pre-commit."
   entry: nitpick fix
+  pass_filenames: true
+  language: python
+
+- id: nitpick-check-all
+  name: "nitpick check (all files)"
+  description: "Only check configuration files (TOML/INI/JSON/etc.) and print the violations, according to the Nitpick style. All files are considered by pre-commit."
+  entry: nitpick check
+  pass_filenames: false
   language: python
 
 - id: nitpick-check
-  name: "nitpick check (check files only)"
-  description: "Only check configuration files (TOML/INI/JSON/etc.) and print the violations, according to the Nitpick style"
+  name: "nitpick check (modified files only)"
+  description: "Only check configuration files (TOML/INI/JSON/etc.) and print the violations, according to the Nitpick style. Only modified files are considered by pre-commit."
   entry: nitpick check
+  pass_filenames: true
   language: python
+
+- id: nitpick-suggest
+  name: "nitpick init --suggest (auto fixing files)"
+  description: "Suggest new Nitpick styles based on the files in the project root (skipping Git ignored files)"
+  entry: nitpick init --fix --suggest
+  language: python
+  # This  hook should NOT be run for changed Git files, otherwise they will be considered style URLS
+  # and will be added to [tool.nitpick]style in pyproject.toml
+  pass_filenames: false
+  always_run: true

README.rst

@@ -401,12 +401,14 @@ this to the ``.pre-commit-config.yaml`` in your repository::
       - repo: https://github.com/andreoliwa/nitpick
         rev: v0.37.0
         hooks:
+          - id: nitpick-suggest
           - id: nitpick
 
-There are 3 available hook IDs:
+There are a few hook IDs available:
 
-- ``nitpick`` and ``nitpick-fix`` both run the ``nitpick fix`` command;
-- ``nitpick-check`` runs ``nitpick check``.
+- ``nitpick``, ``nitpick-fix`` and ``nitpick-fix-all`` run the ``nitpick fix`` command;
+- ``nitpick-check`` and ``nitpick-check-all`` runs ``nitpick check``;
+- ``nitpick-suggest`` runs ``nitpick init --fix --suggest``;
 
 If you want to run Nitpick as a flake8 plugin instead::
 

docs/quickstart.rst

@@ -69,10 +69,10 @@ If you use pre-commit_ on your project, add this to the ``.pre-commit-config.yam
           - id: nitpick-suggest
           - id: nitpick
 
-There are 4 available hook IDs:
+There are a few hook IDs available:
 
-- ``nitpick`` and ``nitpick-fix`` both run the ``nitpick fix`` command;
-- ``nitpick-check`` runs ``nitpick check``;
+- ``nitpick``, ``nitpick-fix`` and ``nitpick-fix-all`` run the ``nitpick fix`` command;
+- ``nitpick-check`` and ``nitpick-check-all`` runs ``nitpick check``;
 - ``nitpick-suggest`` runs ``nitpick init --fix --suggest``;
 
 If you want to run Nitpick_ as a flake8_ plugin instead:

docs/requirements.txt

@@ -8,7 +8,7 @@ certifi==2025.10.5 ; python_version >= "3.10" and python_version < "4.0"
 charset-normalizer==3.4.3 ; python_version >= "3.10" and python_version < "4.0"
 click==8.3.0 ; python_version >= "3.10" and python_version < "4.0"
 colorama==0.4.6 ; python_version >= "3.10" and python_version < "4.0" and (platform_system == "Windows" or sys_platform == "win32")
-configupdater==3.1.1 ; python_version >= "3.10" and python_version < "4.0"
+configupdater==3.2 ; python_version >= "3.10" and python_version < "4.0"
 dictdiffer==0.9.0 ; python_version >= "3.10" and python_version < "4.0"
 docutils==0.21.2 ; python_version >= "3.10" and python_version < "4.0"
 dpath==2.2.0 ; python_version >= "3.10" and python_version < "4.0"

src/nitpick/core.py

@@ -96,6 +96,7 @@ def run(self, *partial_names: str, autofix=False) -> Iterator[Fuss]:
         """
         Reporter.reset()
 
+        logger.info("File names: {}", partial_names)
         try:
             yield from chain(
                 self.project.merge_styles(self.offline),