Skip to content
This repository was archived by the owner on Sep 15, 2024. It is now read-only.

Commit 8f8ad3a

Browse files
committed
Remove GuzzleHttp\json_encode to pass tests.
1 parent 6f6f54f commit 8f8ad3a

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

README.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
# Very short description of the package
22

33
[![Latest Version on Packagist](https://img.shields.io/packagist/v/andreshg112/laravel-auditing-notifications.svg?style=flat-square)](https://packagist.org/packages/andreshg112/laravel-auditing-notifications)
4-
[![Build Status](https://img.shields.io/travis/andreshg112/laravel-auditing-notifications/master.svg?style=flat-square)](https://travis-ci.org/andreshg112/laravel-auditing-notifications)
5-
[![Quality Score](https://img.shields.io/scrutinizer/g/andreshg112/laravel-auditing-notifications.svg?style=flat-square)](https://scrutinizer-ci.com/g/andreshg112/laravel-auditing-notifications)
4+
[![Build Status](https://travis-ci.com/andreshg112/laravel-auditing-notifications.svg?branch=master)](https://travis-ci.com/andreshg112/laravel-auditing-notifications)
5+
[![StyleCI](https://github.styleci.io/repos/178957162/shield?branch=master)](https://github.styleci.io/repos/178957162)
6+
[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/andreshg112/laravel-auditing-notifications/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/andreshg112/laravel-auditing-notifications/?branch=master)
7+
[![Code Coverage](https://scrutinizer-ci.com/g/andreshg112/laravel-auditing-notifications/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/andreshg112/laravel-auditing-notifications/?branch=master)
68
[![Total Downloads](https://img.shields.io/packagist/dt/andreshg112/laravel-auditing-notifications.svg?style=flat-square)](https://packagist.org/packages/andreshg112/laravel-auditing-notifications)
79

810
This is where your description should go. Try and limit it to a paragraph or two, and maybe throw in a mention of what PSRs you support to avoid any confusion with users and contributors.
@@ -17,13 +19,13 @@ composer require andreshg112/laravel-auditing-notifications
1719

1820
## Usage
1921

20-
``` php
22+
```php
2123
// Usage description here
2224
```
2325

2426
### Testing
2527

26-
``` bash
28+
```bash
2729
composer test
2830
```
2931

@@ -41,13 +43,13 @@ If you discover any security related issues, please email [email protected]
4143

4244
## Credits
4345

44-
- [Andrés Herrera García](https://github.com/andreshg112)
45-
- [All Contributors](../../contributors)
46+
- [Andrés Herrera García](https://github.com/andreshg112)
47+
- [All Contributors](../../contributors)
4648

4749
## License
4850

4951
The MIT License (MIT). Please see [License File](LICENSE.md) for more information.
5052

5153
## Laravel Package Boilerplate
5254

53-
This package was generated using the [Laravel Package Boilerplate](https://laravelpackageboilerplate.com).
55+
This package was generated using the [Laravel Package Boilerplate](https://laravelpackageboilerplate.com).

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919
"php": "^7.1",
2020
"illuminate/support": "5.2.* || 5.3.* || 5.4.* || 5.5.* || 5.6.* || 5.7.*",
2121
"lab123/aws-sns": "dev-master",
22-
"mockery/mockery": "^1.2",
2322
"owen-it/laravel-auditing": "^8.0"
2423
},
2524
"require-dev": {
2625
"codedungeon/phpunit-result-printer": "^0.26.1",
26+
"mockery/mockery": "^1.2",
2727
"orchestra/testbench": "^3.5",
2828
"phpunit/phpunit": "^7.0"
2929
},

src/AuditSns.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace Andreshg112\LaravelAuditingNotifications;
44

55
use Illuminate\Bus\Queueable;
6-
use function GuzzleHttp\json_encode;
76
use Illuminate\Support\Facades\Config;
87
use Lab123\AwsSns\Messages\AwsSnsMessage;
98
use Illuminate\Notifications\Notification;

tests/NotificationDriverTest.php

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,21 +49,19 @@ public function readyForAuditing(): bool
4949
return true;
5050
}
5151

52-
public function resolveIpAddress(): string
52+
protected function resolveIpAddress(): string
5353
{
5454
return '';
5555
}
5656

57-
public function resolveUrl(): string
57+
protected function resolveUrl(): string
5858
{
5959
return '';
6060
}
6161

6262
protected function resolveUser()
63-
{
64-
}
63+
{ }
6564

66-
public function resolveUserAgent()
67-
{
68-
}
65+
protected function resolveUserAgent()
66+
{ }
6967
}

0 commit comments

Comments
 (0)