Don't refresh library every new device, limit to an hour (#3081)

Author: andrew-codechimp

custom_components/battery_notes/config_flow.py

@@ -168,7 +168,8 @@ async def async_step_device(
                 library_updater: LibraryUpdater = self.hass.data[DOMAIN][
                     DATA_LIBRARY_UPDATER
                 ]
-                await library_updater.get_library_updates(dt_util.utcnow())
+                if await library_updater.time_to_update_library(1):
+                    await library_updater.get_library_updates(dt_util.utcnow())
 
             device_registry = dr.async_get(self.hass)
             device_entry = device_registry.async_get(device_id)
@@ -261,7 +262,8 @@ async def async_step_entity(
                         library_updater: LibraryUpdater = self.hass.data[DOMAIN][
                             DATA_LIBRARY_UPDATER
                         ]
-                        await library_updater.get_library_updates(dt_util.utcnow())
+                        if await library_updater.time_to_update_library(1):
+                            await library_updater.get_library_updates(dt_util.utcnow())
 
                     device_registry = dr.async_get(self.hass)
                     device_entry = device_registry.async_get(entity_entry.device_id)

custom_components/battery_notes/library_updater.py

@@ -62,7 +62,7 @@ def __init__(self, hass: HomeAssistant):
     @callback
     async def timer_update(self, now: datetime):
         """Need to update the library."""
-        if await self.time_to_update_library() is False:
+        if await self.time_to_update_library(23) is False:
             return
 
         await self.get_library_updates(now)
@@ -114,7 +114,7 @@ def _update_library_json(library_file: str, content: str) -> None:
                 "Unable to update library, will retry later."
             )
 
-    async def time_to_update_library(self) -> bool:
+    async def time_to_update_library(self, hours: int) -> bool:
         """Check when last updated and if OK to do a new library update."""
         try:
             if DATA_LIBRARY_LAST_UPDATE in self.hass.data[DOMAIN]:
@@ -124,7 +124,7 @@ async def time_to_update_library(self) -> bool:
 
                 time_difference_in_hours = time_since_last_update / timedelta(hours=1)
 
-                if time_difference_in_hours < 23:
+                if time_difference_in_hours < hours:
                     _LOGGER.debug("Skipping library update, too recent")
                     return False