Simplify fetch error handling, add bad url integration spec (#47)

This massive case statement is not useful in practice, let's simplify things

Author: andrewMacmurray

integration/src/Main.elm

@@ -50,6 +50,7 @@ specs =
     , httpTimeoutSpec
     , httpBadBodySpec
     , httpBadStatusSpec
+    , httpBadUrlSpec
     , randomSpec
     , timeZoneSpec
     , timeHereSpec
@@ -379,6 +380,22 @@ httpBadStatusSpec =
         (Spec.assertError (shouldHaveBadStatus 400))
 
 
+httpBadUrlSpec : Spec
+httpBadUrlSpec =
+    Spec.describe "http bad url"
+        "should surface a BadUrl error if url is invalid"
+        (Http.get
+            { url = "WAT WAT"
+            , headers = []
+            , expect = Http.expectWhatever
+            , timeout = Nothing
+            }
+        )
+        (Spec.assertError
+            (Spec.shouldEqual (Http.BadUrl "WAT WAT"))
+        )
+
+
 randomSpec : Spec
 randomSpec =
     Spec.describe

runner/http/fetch.ts

@@ -75,64 +75,11 @@ export function http(request: HttpRequest): Promise<HttpResponse> {
 }
 
 function toHttpError(err: any): HttpError {
-  switch (err.cause?.code) {
-    case "ENOTFOUND":
-      return "NETWORK_ERROR";
-    case "ECONNREFUSED":
-      return "NETWORK_ERROR";
-    case "ECONNRESET":
-      return "NETWORK_ERROR";
-    case "EAGAIN":
-      return "NETWORK_ERROR";
-    case "ERR_INVALID_URL":
-      return "BAD_URL";
-
-    case "UND_ERR":
-      return "NETWORK_ERROR";
-    case "UND_ERR_CONNECT_TIMEOUT":
-      return "NETWORK_ERROR";
-    case "UND_ERR_HEADERS_TIMEOUT":
-      return "NETWORK_ERROR";
-    case "UND_ERR_HEADERS_OVERFLOW":
-      return "NETWORK_ERROR";
-    case "UND_ERR_BODY_TIMEOUT":
-      return "NETWORK_ERROR";
-    case "UND_ERR_RESPONSE_STATUS_CODE":
-      return "NETWORK_ERROR";
-    case "UND_ERR_INVALID_ARG":
-      return "NETWORK_ERROR";
-    case "UND_ERR_INVALID_RETURN_VALUE":
-      return "NETWORK_ERROR";
-    case "UND_ERR_ABORTED":
-      return "NETWORK_ERROR";
-    case "UND_ERR_DESTROYED":
-      return "NETWORK_ERROR";
-    case "UND_ERR_CLOSED":
-      return "NETWORK_ERROR";
-    case "UND_ERR_SOCKET":
-      return "NETWORK_ERROR";
-    case "UND_ERR_NOT_SUPPORTED":
-      return "NETWORK_ERROR";
-    case "UND_ERR_REQ_CONTENT_LENGTH_MISMATCH":
-      return "NETWORK_ERROR";
-    case "UND_ERR_RES_CONTENT_LENGTH_MISMATCH":
-      return "NETWORK_ERROR";
-    case "UND_ERR_INFO":
-      return "NETWORK_ERROR";
-    case "UND_ERR_RES_EXCEEDED_MAX_SIZE":
-      return "NETWORK_ERROR";
-  }
-
-  switch (err.name) {
-    case "AbortError":
-      return "TIMEOUT";
+  if (err.name === "AbortError") {
+    return "TIMEOUT";
+  } else if (err.cause?.code === "ERR_INVALID_URL") {
+    return "BAD_URL";
+  } else {
+    return "NETWORK_ERROR";
   }
-
-  console.warn(
-    `Unknown Http fetch error, consider submitting a PR adding an explicit case for this
-    https://github.com/andrewMacmurray/elm-concurrent-task/blob/main/runner/http/fetch.ts#L60
-    `,
-    err
-  );
-  return "NETWORK_ERROR";
 }