Another glob is globbed too soon

Author: andrewbranch

package.json

@@ -9,7 +9,7 @@
     "test": "jest",
     "pretest": "npm run check && npm run build && prettier --check src/**/*.js",
     "prepublishOnly": "npm test",
-    "format": "prettier --write src/**/*.js"
+    "format": "prettier --write 'src/**/*.js'"
   },
   "repository": {
     "type": "git",

src/index.js

@@ -176,7 +176,7 @@ function createPlugin() {
       replaceColor,
       extensionDataDirectory,
       logLevel,
-      ...rest,
+      ...rest
     });
 
     /** @type {Record<string, string>} */
@@ -227,7 +227,11 @@ function createPlugin() {
 
           const themeClassName = themeClassNames[setting];
           const themeCache = await cache.get('themes');
-          const colorThemePath = ensureThemeLocation(colorThemeIdentifier, themeCache, markdownNode.fileAbsolutePath);
+          const colorThemePath = await ensureThemeLocation(
+            colorThemeIdentifier,
+            themeCache,
+            markdownNode.fileAbsolutePath
+          );
 
           const { resultRules: tokenColors, resultColors: settings } = loadColorTheme(colorThemePath);
           const defaultTokenColors = {
@@ -310,9 +314,9 @@ function createPlugin() {
               const endIndex = result.tokens[i + 2] || line.length;
               /** @type {LineData} */
               htmlLine.push(
-                span({ class: getClassNameFromMetadata(metadata) }, [
-                  escapeHTML(line.slice(startIndex, endIndex))
-                ], { whitespace: TriviaRenderFlags.NoWhitespace }),
+                span({ class: getClassNameFromMetadata(metadata) }, [escapeHTML(line.slice(startIndex, endIndex))], {
+                  whitespace: TriviaRenderFlags.NoWhitespace
+                })
               );
             }
           } else {
@@ -321,24 +325,25 @@ function createPlugin() {
 
           /** @type {LineData} */
           const lineData = { codeFenceOptions: options, index: lineIndex, content: line, language: languageName };
-          const className = joinClassNames(
-            getLineClassName(lineData),
-            'vscode-highlight-line'
-          );
+          const className = joinClassNames(getLineClassName(lineData), 'vscode-highlight-line');
 
-          htmlLines.push(span(
-            mergeAttributes({ class: className }, attrs),
-            htmlLine,
-            { whitespace: TriviaRenderFlags.NoWhitespace }
-          ));
+          htmlLines.push(
+            span(mergeAttributes({ class: className }, attrs), htmlLine, { whitespace: TriviaRenderFlags.NoWhitespace })
+          );
         }
 
         const className = joinClassNames(wrapperClassName, joinThemeClassNames(themeClassNames), 'vscode-highlight');
         node.type = 'html';
         node.value = renderHTML(
-          pre({ class: className, 'data-language': languageName }, [
-            code({ class: 'vscode-highlight-code' }, htmlLines, { whitespace: TriviaRenderFlags.NewlineBetweenChildren })
-          ], { whitespace: TriviaRenderFlags.NoWhitespace })
+          pre(
+            { class: className, 'data-language': languageName },
+            [
+              code({ class: 'vscode-highlight-code' }, htmlLines, {
+                whitespace: TriviaRenderFlags.NewlineBetweenChildren
+              })
+            ],
+            { whitespace: TriviaRenderFlags.NoWhitespace }
+          )
         );
       } finally {
         unlockRegistry();
@@ -352,9 +357,9 @@ function createPlugin() {
         value: renderHTML(
           style({ class: 'vscode-highlight-styles' }, [
             injectStyles ? styles : '',
-            ...themeNames.map(theme => stylesheets[theme]),
+            ...themeNames.map(theme => stylesheets[theme])
           ])
-        ),
+        )
       });
     }
   }

src/renderUtils.js

@@ -53,8 +53,8 @@ function joinClassNames(...classNames) {
 }
 
 /**
- * @param {string} tagName 
- * @param {object} attributes 
+ * @param {string} tagName
+ * @param {object} attributes
  * @param {(ElementTemplate | string)[]} children
  * @param {RenderOptions=} renderOptions
  * @returns {ElementTemplate}
@@ -88,11 +88,11 @@ const span = factory('span');
 const style = factory('style');
 
 const TriviaRenderFlags = {
-  NoWhitespace:            0,
-  NewlineAfterOpeningTag:  1 << 0,
+  NoWhitespace: 0,
+  NewlineAfterOpeningTag: 1 << 0,
   NewlineBeforeClosingTag: 1 << 1,
-  NewlineBetweenChildren:  1 << 2,
-  IndentChildren:          1 << 3,
+  NewlineBetweenChildren: 1 << 2,
+  IndentChildren: 1 << 3
 };
 
 /**
@@ -108,10 +108,11 @@ function renderHTML(element, indent = 0) {
   }
 
   const { tagName, attributes, children } = element;
-  const attrs = Object.keys(attributes).map(attr => ` ${attr}="${escape(attributes[attr])}"`).join('');
+  const attrs = Object.keys(attributes)
+    .map(attr => ` ${attr}="${escape(attributes[attr])}"`)
+    .join('');
   let html = '';
 
-
   write(`<${tagName}${attrs}>`);
   if (whitespace & TriviaRenderFlags.NewlineAfterOpeningTag) {
     writeNewline();
@@ -158,5 +159,5 @@ module.exports = {
   code,
   span,
   style,
-  TriviaRenderFlags,
+  TriviaRenderFlags
 };

src/storeUtils.js

@@ -49,15 +49,17 @@ async function ensureThemeLocation(themeNameOrId, themeCache, markdownFilePath)
     const theme = themes[themeId];
     if (themeNameOrId === themeId || themeNameOrId.toLowerCase() === theme.label.toLowerCase()) {
       const themePath = path.isAbsolute(theme.path) ? theme.path : path.resolve(__dirname, '../lib/themes', theme.path);
-      if (!await exists(themePath)) {
+      if (!(await exists(themePath))) {
         throw new Error(`Theme manifest lists '${themeNameOrId}' at '${themePath}, but no such file exists.'`);
       }
     }
   }
 
   const locallyResolved = path.resolve(path.dirname(markdownFilePath), themeNameOrId);
-  if (!await exists(locallyResolved)) {
-    throw new Error(`Theme manifest does not contain theme '${themeNameOrId}', and no theme file exists at '${locallyResolved}'.`);
+  if (!(await exists(locallyResolved))) {
+    throw new Error(
+      `Theme manifest does not contain theme '${themeNameOrId}', and no theme file exists at '${locallyResolved}'.`
+    );
   }
 }