Skip to content

Vogue is incorrect in assuming it's the last script in scripts array #31

@anentropic

Description

@anentropic

I am getting errors like this:
"NetworkError: 404 NOT FOUND - http://127.0.0.1:8000/products/undefinedsocket.io/socket.io.js"

The problem lies in getScriptInfo() in vogue-client.js

it assumes the Vogue script will be the last one in the array returned by document.getElementsByTagName("script") but because it appends itself to the ... and common practice is now to put all your scripts at the bottom of the (see html5 boilerplate etc)... so it is not selecting the Vogue script, it's grabbing my Google Analytics script block instead.

It really needs to look for vogue-client.js specifically.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions