Skip to content

Commit 033e625

Browse files
Update ADR002-Shorten-inventory-ids-with-naonoid.md
Signed-off-by: Andrew Harmel-Law <andrew@harmel-law.com>
1 parent 89c60ee commit 033e625

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

adr/ADR002-Shorten-inventory-ids-with-naonoid.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ These are the decision criteria:
6161

6262
## Advice
6363
* Have we thought about the possibility of auto-generated profanity in the auto-generated text? It could be bad for our reputation if this happened. _(Monira R., Product Manager, 25 Aug, 2024)_
64-
* What’s the possibility of ID collisions with each option? Have we looked at generating them in a database? It’s a good way to offload the responsibility of making sure IDs are unique. _(Hanna A., Infra team, 24 Aug, 2024)_
64+
* What’s the possibility of ID collisions with each option? Have we looked at generating them in a database? It’s a good way to offload the responsibility of making sure IDs are unique. _(Hannah A., Infra team, 24 Aug, 2024)_
6565
* Does making it human-meaningful matter, or just human-readable? _(Rebecca F., UX, 25 Aug, 2024)_
6666
* Can we list out all the places where we’ll need to use this ID? _(Izzy H., Tech Lead from another team: Site Search, 28 Aug, 2024)_
6767
* Will the IDs be exposed publicly? We must think about leakage of internal data models and generation modes as it might broaden our attack surface. _(Pete H., Infosec, 25 Aug, 2024)_

0 commit comments

Comments
 (0)