Skip to content

Commit b10ef43

Browse files
Fix a few typos; add intent to make documentation
1 parent b011d03 commit b10ef43

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ There is a single exception to this rule: vectorized (without threading) version
2020

2121
## Motivation
2222

23-
When writing numerical code, one may with to perform a reduction, perhaps across multiple dimensions, as the most natural means of expressing the relevant mathematical operation.
23+
When writing numerical code, one may wish to perform a reduction, perhaps across multiple dimensions, as the most natural means of expressing the relevant mathematical operation.
2424
For readers well-acquainted with LoopVectorization.jl, the thought immediately comes to mind: writing out the loops will inevitably be a large performance gain. Thus, in that neverending pursuit of fast code, we write the loops -- but this produces specific code, tailored to the dimensions of the problem.
2525
Instead, we might have liked to write generic code, parameterizing our function with an index set of dimensions. This package attempts to resolve this perpetual dilemma using metaprogramming. The hope is that the next time one asks the question: is it worthwhile to write the loops (gain performance, lose genericity), or can I make do with the Base implementation? that one can confidently reach for one of the "vectorized" versions provided by this package.
2626

@@ -201,7 +201,6 @@ julia> findmax(B′) == vfindmax(+, B1, B2, B3)
201201
true
202202

203203
julia> @benchmark findmin(@. $B1 + $B2 + $B3)
204-
@benchmark vfindmin(+, $B1, $B2, $B3)
205204
BenchmarkTools.Trial: 10000 samples with 8 evaluations.
206205
Range (min max): 3.905 μs 943.922 μs ┊ GC (min max): 0.00% 94.06%
207206
Time (median): 4.011 μs ┊ GC (median): 0.00%
@@ -245,6 +244,7 @@ The original motivation for this work was a vectorized & multithreaded multi-dim
245244
## Future work
246245
1. post-reduction operators
247246
2. reductions over index subsets within a dimension.
247+
3. actual documentation
248248

249249
## Elsewhere
250250
* [LoopVectorization.jl](https://github.com/chriselrod/LoopVectorization.jl) back-end for this package.

0 commit comments

Comments
 (0)