Additional overloads (#242)

* Add additional overload to avoid allocations where possible

* Update public API

Author: andrewlock

src/NetEscapades.AspNetCore.SecurityHeaders/Headers/SourceCollection.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections;
 using System.Collections.Generic;
 
@@ -31,11 +32,25 @@ public void Add(string source)
 
     /// <summary>
     /// Adds a source to the collection for the given directive.
-    /// Calls to <see cref="AddRange"/> are idempotent;
+    /// Calls to <see cref="AddRange(System.ReadOnlySpan{string})"/> are idempotent;
     /// if the source has already been added, it will not be added again.
     /// </summary>
     /// <param name="sources">The sources to add</param>
-    public void AddRange(IEnumerable<string> sources)
+    public void AddRange(params ReadOnlySpan<string> sources)
+    {
+        foreach (var source in sources)
+        {
+            Add(source);
+        }
+    }
+
+    /// <summary>
+    /// Adds a source to the collection for the given directive.
+    /// Calls to <see cref="AddRange(IEnumerable{string})"/> are idempotent;
+    /// if the source has already been added, it will not be added again.
+    /// </summary>
+    /// <param name="sources">The sources to add</param>
+    public void AddRange(params IEnumerable<string> sources)
     {
         foreach (var source in sources)
         {

test/NetEscapades.AspNetCore.SecurityHeaders.Test/PublicApiTest.PublicApiHasNotChanged.verified.txt

@@ -600,6 +600,7 @@ namespace NetEscapades.AspNetCore.SecurityHeaders.Headers
         public int Count { get; }
         public void Add(string source) { }
         public void AddRange(System.Collections.Generic.IEnumerable<string> sources) { }
+        public void AddRange(System.ReadOnlySpan<string> sources) { }
         public System.Collections.Generic.IEnumerator<string> GetEnumerator() { }
         public bool Remove(string source) { }
     }

test/NetEscapades.AspNetCore.SecurityHeaders.Test/SourceCollectionTests.cs

@@ -0,0 +1,87 @@
+using System.Collections.Generic;
+using FluentAssertions;
+using NetEscapades.AspNetCore.SecurityHeaders.Headers;
+using Xunit;
+
+namespace NetEscapades.AspNetCore.SecurityHeaders.Test;
+
+public class SourceCollectionTests
+{
+    [Fact]
+    public void AddsSourceInExpectedOrder()
+    {
+        string[] expected = ["Source 1", "Source 2", "Source 3"]; 
+        var col = new SourceCollection();
+        foreach (var source in expected)
+        {
+            col.Add(source);
+        }
+
+        VerifyAsExpected(col, expected);
+    }
+
+    [Fact]
+    public void DuplicateSourcesAreNotAdded()
+    {
+        var col = new SourceCollection();
+        col.Add("Source 1");
+        col.Add("Source 1");
+        col.Add("Source 2");
+        col.Add("Source 3");
+        col.Add("Source 3");
+
+        VerifyAsExpected(col, ["Source 1", "Source 2", "Source 3"]);
+    }
+
+    [Fact]
+    public void AddRageAddsSourceInExpectedOrder()
+    {
+        List<string> sources = ["Source 1", "Source 2", "Source 3"]; 
+        var col = new SourceCollection();
+        col.AddRange(sources);
+
+        VerifyAsExpected(col, sources);
+    }
+
+    [Fact]
+    public void AddRangeDuplicateSourcesAreNotAdded()
+    {
+        string[] expected = ["Source 1", "Source 2", "Source 3"]; 
+        var col = new SourceCollection();
+        col.AddRange([
+            "Source 1",
+            "Source 1",
+            "Source 2",
+            "Source 3",
+            "Source 3",
+        ]);
+
+        VerifyAsExpected(col, expected);
+    }
+
+    [Fact]
+    public void RemoveRemovesSources()
+    {
+        string[] expected = ["Source 1", "Source 2", "Source 3"]; 
+        var col = new SourceCollection();
+        col.Add("To move");
+        foreach (var source in expected)
+        {
+            col.Add(source);
+        }
+
+        col.Remove("To move");
+
+        VerifyAsExpected(col, expected);
+    }
+
+    private static void VerifyAsExpected(SourceCollection collection, IList<string> expected)
+    {
+        var i = 0;
+        foreach (var source in collection)
+        {
+            source.Should().Be(expected[i]);
+            i++;
+        }
+    }
+}