Add pragma to suppress unreachable pattern warnings (#143)

* Add pragma to suppress unreachable pattern warnings

This commit introduces the `#pragma warning disable CS8510` directive to suppress warnings about unreachable patterns in switch expressions. The directive has been added to `SourceGenerationHelper.cs` and various test files to prevent unnecessary warnings during code generation. The corresponding `#pragma warning restore CS8510` directive has also been included to restore the warning state after the relevant code sections.

* Remove `#pragma warning disable CS8510` directive across multiple files and enhance enum generation functionality. Added methods for parsing and checking defined enum values, along with new extension methods. Introduced tests to verify correct generation of enums with repeated values and flags.

* Enhance `SourceGenerationHelper` to track constant values of enum members using a new `HashSet<object>`. Update logic for appending enum member values to improve clarity, particularly regarding display names. Introduce two new enums, `EnumWithRepeatedValues` and `EnumWithRepeatedValuesWithDisplayNames`, to handle repeated values and display names. Update tests to reflect changes in enum definitions, including the removal of the `Third` member check due to its repeated value.

Author: paulomorgado

src/NetEscapades.EnumGenerators/SourceGenerationHelper.cs

@@ -103,6 +103,8 @@ public class EnumExtensionsAttribute<T> : System.Attribute
 
     public static (string Content, string HintName) GenerateExtensionClass(in EnumToGenerate enumToGenerate)
     {
+        var constantValues = new HashSet<object>();
+
         var sb = new StringBuilder();
         sb.AppendLine(Header);
         if (!string.IsNullOrEmpty(enumToGenerate.Namespace))
@@ -187,15 +189,19 @@ public static string ToStringFast(this
             """);
 
         var hasDisplayNames = false;
+        constantValues.Clear();
         foreach (var member in enumToGenerate.Names)
         {
-            hasDisplayNames |= member.Value.DisplayName is not null;
-            sb.Append(
-                """
+            if (constantValues.Add(member.Value.ConstantValue))
+            {
+                hasDisplayNames |= member.Value.DisplayName is not null;
+                    sb.Append(
+                        """
 
-                                
-                """).Append(fullyQualifiedName).Append('.').Append(member.Key)
-                .Append(" => nameof(").Append(fullyQualifiedName).Append('.').Append(member.Key).Append("),");
+                                        
+                        """).Append(fullyQualifiedName).Append('.').Append(member.Key)
+                        .Append(" => nameof(").Append(fullyQualifiedName).Append('.').Append(member.Key).Append("),");
+            }
         }
 
         if (enumToGenerate.HasFlags)
@@ -236,22 +242,26 @@ private static string ToStringFastWithMetadata(this
                 value switch
                             {
                 """);
+            constantValues.Clear();
             foreach (var member in enumToGenerate.Names)
             {
-                sb.Append(
-                    """
+                if (constantValues.Add(member.Value.ConstantValue))
+                {
+                    sb.Append(
+                        """
 
                                     
                     """).Append(fullyQualifiedName).Append('.').Append(member.Key)
-                    .Append(" => ");
+                        .Append(" => ");
 
-                if (member.Value.DisplayName is { } dn)
-                {
-                    sb.Append(SymbolDisplay.FormatLiteral(dn, quote: true)).Append(',');
-                }
-                else
-                {
-                    sb.Append("nameof(").Append(fullyQualifiedName).Append('.').Append(member.Key).Append("),");
+                    if (member.Value.DisplayName is { } dn)
+                    {
+                        sb.Append(SymbolDisplay.FormatLiteral(dn, quote: true)).Append(',');
+                    }
+                    else
+                    {
+                        sb.Append("nameof(").Append(fullyQualifiedName).Append('.').Append(member.Key).Append("),");
+                    }
                 }
             }
 
@@ -349,14 +359,18 @@ public static bool IsDefined(
                         => value switch
                         {
             """);
+        constantValues.Clear();
         foreach (var member in enumToGenerate.Names)
         {
-            sb.Append(
-                """
+            if (constantValues.Add(member.Value.ConstantValue))
+            {
+                sb.Append(
+                    """
 
-                                
-                """).Append(fullyQualifiedName).Append('.').Append(member.Key)
-                .Append(" => true,");
+                                    
+                    """).Append(fullyQualifiedName).Append('.').Append(member.Key)
+                    .Append(" => true,");
+            }
         }
 
         sb.Append(

tests/NetEscapades.EnumGenerators.IntegrationTests/Enums.cs

@@ -148,4 +148,22 @@ public enum EnumWithExtensionInOtherNamespace
 
         Third = 2,
     }
+
+    [EnumExtensions]
+    public enum EnumWithRepeatedValues
+    {
+        First = 0,
+        Second = 1,
+        Third = 0, // Repeated value
+        Fourth = Second, // Repeated value
+        Fifth = Second + Third, // Repeated value
+    }
+
+    [EnumExtensions]
+    public enum EnumWithRepeatedValuesWithDisplayNames
+    {
+        [Display(Name = "Main")] First = 0,
+        Second = 1,
+        [Display(Name = "Repeated")] Third = 0, // Repeated value with display name
+    }
 }