add parse and tryparse for string

Author: lucasteles

src/StronglyTypedIds/Templates/NullableString/NullableString_Base.cs

@@ -29,3 +29,10 @@ public override bool Equals(object? obj)
         public override string? ToString() => Value;
         public static bool operator ==(TESTID a, TESTID b) => a.Equals(b);
         public static bool operator !=(TESTID a, TESTID b) => !(a == b);
+
+        public static TESTID Parse(string? value) => new TESTID(value?.Trim());
+        public static bool TryParse(string? value, out TESTID result)
+        {
+            result = new TESTID(value?.Trim());
+            return true;
+        }

src/StronglyTypedIds/Templates/String/String_Base.cs

@@ -30,3 +30,15 @@ public override bool Equals(object obj)
         public override string ToString() => Value;
         public static bool operator ==(TESTID a, TESTID b) => a.Equals(b);
         public static bool operator !=(TESTID a, TESTID b) => !(a == b);
+
+        public static TESTID Parse(string value) => new TESTID(value.Trim());
+        public static bool TryParse(string value, out TESTID result)
+        {
+            if (string.IsNullOrWhiteSpace(value))
+            {
+                result = default;
+                return false;
+            }
+            result = new TESTID(value.Trim());
+            return true;
+        }

test/StronglyTypedIds.IntegrationTests/NullableStringIdTests.cs

@@ -64,6 +64,27 @@ public void DifferentTypesAreUnequal()
             Assert.NotEqual((object)bar, (object)foo);
         }
 
+        [Fact]
+        public void CanParseSuccessfully()
+        {
+            var value = "123ABC";
+            var foo = NullableStringId.Parse($" {value} ");
+            var bar = new NullableStringId(value);
+
+            Assert.Equal(bar, foo);
+        }
+
+        [Fact]
+        public void CanTryParseSuccessfully()
+        {
+            var value = "123ABC";
+            var result = NullableStringId.TryParse($" {value} ", out NullableStringId foo);
+            var bar = new NullableStringId(value);
+
+            Assert.True(result);
+            Assert.Equal(bar, foo);
+        }
+
         [Fact]
         public void CanSerializeToString_WithNewtonsoftJsonProvider()
         {

test/StronglyTypedIds.IntegrationTests/StringIdTests.cs

@@ -70,6 +70,40 @@ public void DifferentTypesAreUnequal()
             Assert.NotEqual((object)bar, (object)foo);
         }
 
+
+        [Fact]
+        public void CanParseSuccessfully()
+        {
+            var value = "123ABC";
+            var foo = StringId.Parse($" {value} ");
+            var bar = new StringId(value);
+
+            Assert.Equal(bar, foo);
+        }
+
+
+        [Fact]
+        public void CanTryParseSuccessfully()
+        {
+            var value = "123ABC";
+            var result = StringId.TryParse($" {value} ", out StringId foo);
+            var bar = new StringId(value);
+
+            Assert.True(result);
+            Assert.Equal(bar, foo);
+        }
+
+
+        [Theory]
+        [InlineData("")]
+        [InlineData(" ")]
+        [InlineData(null!)]
+        public void CaTryParseFailOnInvalidStrings(string value)
+        {
+            var result = StringId.TryParse(value, out _);
+            Assert.False(result);
+        }
+
         [Fact]
         public void CanSerializeToString_WithNewtonsoftJsonProvider()
         {

test/StronglyTypedIds.Tests/Snapshots/SourceGenerationHelperSnapshotTests.GeneratesIdCorrectly_ns=Some.Namespace_converter=0_backingType=NullableString_implementations=0.verified.txt

@@ -43,5 +43,12 @@ namespace Some.Namespace
         public override string? ToString() => Value;
         public static bool operator ==(MyTestId a, MyTestId b) => a.Equals(b);
         public static bool operator !=(MyTestId a, MyTestId b) => !(a == b);
+
+        public static MyTestId Parse(string? value) => new MyTestId(value?.Trim());
+        public static bool TryParse(string? value, out MyTestId result)
+        {
+            result = new MyTestId(value?.Trim());
+            return true;
+        }
     }
 }

test/StronglyTypedIds.Tests/Snapshots/SourceGenerationHelperSnapshotTests.GeneratesIdCorrectly_ns=Some.Namespace_converter=0_backingType=NullableString_implementations=2.verified.txt

@@ -43,5 +43,12 @@ namespace Some.Namespace
         public override string? ToString() => Value;
         public static bool operator ==(MyTestId a, MyTestId b) => a.Equals(b);
         public static bool operator !=(MyTestId a, MyTestId b) => !(a == b);
+
+        public static MyTestId Parse(string? value) => new MyTestId(value?.Trim());
+        public static bool TryParse(string? value, out MyTestId result)
+        {
+            result = new MyTestId(value?.Trim());
+            return true;
+        }
     }
 }

test/StronglyTypedIds.Tests/Snapshots/SourceGenerationHelperSnapshotTests.GeneratesIdCorrectly_ns=Some.Namespace_converter=0_backingType=NullableString_implementations=4.verified.txt

@@ -43,6 +43,13 @@ namespace Some.Namespace
         public override string? ToString() => Value;
         public static bool operator ==(MyTestId a, MyTestId b) => a.Equals(b);
         public static bool operator !=(MyTestId a, MyTestId b) => !(a == b);
+
+        public static MyTestId Parse(string? value) => new MyTestId(value?.Trim());
+        public static bool TryParse(string? value, out MyTestId result)
+        {
+            result = new MyTestId(value?.Trim());
+            return true;
+        }
         public int CompareTo(MyTestId other)
         {
             return (Value, other.Value) switch

test/StronglyTypedIds.Tests/Snapshots/SourceGenerationHelperSnapshotTests.GeneratesIdCorrectly_ns=Some.Namespace_converter=0_backingType=NullableString_implementations=6.verified.txt

@@ -43,6 +43,13 @@ namespace Some.Namespace
         public override string? ToString() => Value;
         public static bool operator ==(MyTestId a, MyTestId b) => a.Equals(b);
         public static bool operator !=(MyTestId a, MyTestId b) => !(a == b);
+
+        public static MyTestId Parse(string? value) => new MyTestId(value?.Trim());
+        public static bool TryParse(string? value, out MyTestId result)
+        {
+            result = new MyTestId(value?.Trim());
+            return true;
+        }
         public int CompareTo(MyTestId other)
         {
             return (Value, other.Value) switch

test/StronglyTypedIds.Tests/Snapshots/SourceGenerationHelperSnapshotTests.GeneratesIdCorrectly_ns=Some.Namespace_converter=0_backingType=String_implementations=0.verified.txt

@@ -43,5 +43,17 @@ namespace Some.Namespace
         public override string ToString() => Value;
         public static bool operator ==(MyTestId a, MyTestId b) => a.Equals(b);
         public static bool operator !=(MyTestId a, MyTestId b) => !(a == b);
+
+        public static MyTestId Parse(string value) => new MyTestId(value.Trim());
+        public static bool TryParse(string value, out MyTestId result)
+        {
+            if (string.IsNullOrWhiteSpace(value))
+            {
+                result = default;
+                return false;
+            }
+            result = new MyTestId(value.Trim());
+            return true;
+        }
     }
 }

test/StronglyTypedIds.Tests/Snapshots/SourceGenerationHelperSnapshotTests.GeneratesIdCorrectly_ns=Some.Namespace_converter=0_backingType=String_implementations=2.verified.txt

@@ -43,5 +43,17 @@ namespace Some.Namespace
         public override string ToString() => Value;
         public static bool operator ==(MyTestId a, MyTestId b) => a.Equals(b);
         public static bool operator !=(MyTestId a, MyTestId b) => !(a == b);
+
+        public static MyTestId Parse(string value) => new MyTestId(value.Trim());
+        public static bool TryParse(string value, out MyTestId result)
+        {
+            if (string.IsNullOrWhiteSpace(value))
+            {
+                result = default;
+                return false;
+            }
+            result = new MyTestId(value.Trim());
+            return true;
+        }
     }
 }