Silence build warnings

* Correct specifiers in format strings
* Capture return value of assignment in conditionals

Author: andrewschleifer

Classes/PBGitIndex.m

@@ -355,7 +355,7 @@ - (BOOL)applyPatch:(NSString *)hunk stage:(BOOL)stage reverse:(BOOL)reverse
 
 - (NSString *)diffForFile:(PBChangedFile *)file staged:(BOOL)staged contextLines:(NSUInteger)context
 {
-	NSString *parameter = [NSString stringWithFormat:@"-U%u", context];
+	NSString *parameter = [NSString stringWithFormat:@"-U%ld", context];
 	if (staged) {
 		NSString *indexPath = [@":0:" stringByAppendingString:file.path];
 

Classes/PBGitRepository.m

@@ -219,7 +219,7 @@ - (void) addRef: (PBGitRef *) ref fromParameters: (NSArray *) components
 		sha = [components objectAtIndex:2];
 
 	NSMutableArray* curRefs;
-	if (curRefs = [refs objectForKey:sha])
+	if ((curRefs = [refs objectForKey:sha]))
 		[curRefs addObject:ref];
 	else
 		[refs setObject:[NSMutableArray arrayWithObject:ref] forKey:sha];

Classes/PBGitRevList.mm

@@ -156,7 +156,7 @@ - (void) walkRevisionListWithSpecifier: (PBGitRevSpecifier*) rev
 		if (parentString.size() != 0)
 		{
 			if (((parentString.size() + 1) % 41) != 0) {
-				NSLog(@"invalid parents: %i", parentString.size());
+				NSLog(@"invalid parents: %ld", parentString.size());
 				continue;
 			}
 			int nParents = (parentString.size() + 1) / 41;

Classes/PBGitTree.m

@@ -148,15 +148,15 @@ - (NSString *)textContents
 		return [NSString stringWithFormat:@"This is a tree with path %@", [self fullPath]];
 
 	if ([self hasBinaryAttributes])
-		return [NSString stringWithFormat:@"%@ appears to be a binary file of %d bytes", [self fullPath], [self fileSize]];
+		return [NSString stringWithFormat:@"%@ appears to be a binary file of %lld bytes", [self fullPath], [self fileSize]];
 
 	if ([self fileSize] > 52428800) // ~50MB
-		return [NSString stringWithFormat:@"%@ is too big to be displayed (%d bytes)", [self fullPath], [self fileSize]];
+		return [NSString stringWithFormat:@"%@ is too big to be displayed (%lld bytes)", [self fullPath], [self fileSize]];
 
 	NSString* contents = [self contents];
 
 	if ([self hasBinaryHeader:contents])
-		return [NSString stringWithFormat:@"%@ appears to be a binary file of %d bytes", [self fullPath], [self fileSize]];
+		return [NSString stringWithFormat:@"%@ appears to be a binary file of %lld bytes", [self fullPath], [self fileSize]];
 
 	return contents;
 }

gitx.m

@@ -33,7 +33,7 @@
 	// Now attempt to connect, allowing the app time to startup
 	int attempt;
 	for (attempt = 0; proxy == nil && attempt < 50; ++attempt) {
-		if (proxy = connect())
+		if ((proxy = connect()))
 			return proxy;
 
 		usleep(15000);