Removing of EOL produces incorrect patch

[andrewshadura]

Prepare a test repo:

git init
echo test > test
git add test
git commit -m test
echo -n test > test

This produces a diff:

diff --git a/test b/test
index 9daeafb9864c..30d74d258442 100644
--- a/test
+++ b/test
@@ -1 +1 @@
-test
+test
\ No newline at end of file

This is being parsed as:

diff --git a/test b/test
index 9daeafb9864c..30d74d258442 100644
--- a/test
+++ b/test
@@ -1,1 +1,1 @@
-test
\ No newline at end of file
+test

[rwarren]

Just going to add a note here since this is still a major problem for me. I had a failed PR (#48) for this, but I unfortunately don't understand enough about the patch processing to implement a proper fix.

FWIW, this is a particular problem when working with Visual Studio (full VS, not vscode) since it saves a bunch of its managed files (packages.config, *.resx, *.Dotsettings, etc) without newlines at the end. 😭 This is obviously an edge case for any git-crecord users out there since it doesn't run on Windows (I use it through WSL), but it is a huge pain for me, unfortunately.

I really miss mercurial some days.