Skip to content

Commit 0ab44fd

Browse files
davidbrochartandrii-i
authored andcommitted
Update pycrdt-websocket v0.13.0 (jupyterlab#293)
1 parent e54b89c commit 0ab44fd

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

projects/jupyter-server-ydoc/jupyter_server_ydoc/handlers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ async def _clean_room(self) -> None:
337337
async with self._room_lock(self._room_id):
338338
# Remove the room from the websocket server
339339
self.log.info("Deleting Y document from memory: %s", self._room_id)
340-
self._websocket_server.delete_room(room=self.room)
340+
await self._websocket_server.delete_room(room=self.room)
341341

342342
# Clean room
343343
del self.room

projects/jupyter-server-ydoc/jupyter_server_ydoc/rooms.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,15 +133,13 @@ def _emit(self, level: LogLevel, action: str | None = None, msg: str | None = No
133133

134134
self._logger.emit(schema_id=JUPYTER_COLLABORATION_EVENTS_URI, data=data)
135135

136-
def stop(self) -> None:
136+
async def stop(self) -> None:
137137
"""
138138
Stop the room.
139139
140140
Cancels the save task and unsubscribes from the file.
141141
"""
142-
self._document.unobserve()
143-
self._file.unobserve(self.room_id)
144-
142+
await super().stop()
145143
# TODO: Should we cancel or wait ?
146144
if self._saving_document:
147145
self._saving_document.cancel()

projects/jupyter-server-ydoc/jupyter_server_ydoc/websocketserver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ async def clean(self):
5656
# self.log.warning(msg)
5757
# self.log.debug("Pending tasks: %r", pending)
5858

59-
self.stop()
59+
await self.stop()
6060
tasks = []
6161
if self.monitor_task is not None:
6262
self.monitor_task.cancel()

projects/jupyter-server-ydoc/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ authors = [
3030
dependencies = [
3131
"jupyter_server>=2.4.0,<3.0.0",
3232
"jupyter_ydoc>=2.0.0,<3.0.0",
33-
"pycrdt-websocket>=0.12.5,<0.13.0",
33+
"pycrdt-websocket>=0.13.0,<0.14.0",
3434
"jupyter_events>=0.10.0",
3535
"jupyter_server_fileid>=0.7.0,<1",
3636
"jsonschema>=4.18.0"

0 commit comments

Comments
 (0)