Fix stack_size option bug, add testing workflow

Author: andrjohns

.github/workflows/R-CMD-check-cross.yaml

@@ -1,8 +1,6 @@
 on:
   push:
     branches: [main, master]
-  pull_request:
-    branches: [main, master]
 
 name: R-CMD-check-crossplatform
 

.github/workflows/test-rstan.yaml

@@ -0,0 +1,103 @@
+# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
+# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
+on:
+  push:
+    branches: [main, master]
+
+name: RStan stanc
+
+jobs:
+  rstan-stanc:
+    runs-on: ${{ matrix.config.os }}
+
+    name: ${{ matrix.config.os }} (${{ matrix.config.r }})
+
+    strategy:
+      fail-fast: false
+      matrix:
+        config:
+          - {os: macos-latest,   r: 'devel'}
+
+          - {os: windows-11-arm, r: '4.5.1', extra-pkgs: RcppCore/RcppParallel}
+          - {os: windows-latest, r: 'devel'}
+
+          - {os: ubuntu-24.04-arm,   r: 'release'}
+          - {os: ubuntu-latest,   r: 'devel', http-user-agent: 'release'}
+
+    env:
+      GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
+      MAKEFLAGS: -j4
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: true
+
+      - uses: r-lib/actions/setup-r@v2
+        if: matrix.config.os != 'windows-11-arm'
+        with:
+          r-version: ${{ matrix.config.r }}
+          rtools-version: ${{ matrix.config.rtools }}
+          http-user-agent: ${{ matrix.config.http-user-agent }}
+          use-public-rspm: true
+
+      - name: Install R & RTools (ARM64)
+        if: matrix.config.os == 'windows-11-arm'
+        run: |
+          $url = "https://www.r-project.org/nosvn/winutf8/aarch64/R-4-signed/R-${{ matrix.config.r }}-aarch64.exe"
+          Invoke-WebRequest `
+              -Uri https://www.r-project.org/nosvn/winutf8/aarch64/R-4-signed/R-${{ matrix.config.r }}-aarch64.exe `
+              -OutFile ../R-${{ matrix.config.r }}-aarch64.exe
+          Start-Process `
+              -FilePath ../R-${{ matrix.config.r }}-aarch64.exe `
+              -ArgumentList "/INSTALL /VERYSILENT /SUPPRESSMSGBOXES" -Wait
+
+          Invoke-WebRequest `
+              -Uri https://github.com/r-hub/rtools45/releases/download/latest/rtools45-aarch64.exe `
+              -OutFile "../rtools45-aarch64.exe"
+          Start-Process `
+              -FilePath "../rtools45-aarch64.exe" `
+              -ArgumentList "/INSTALL /VERYSILENT /SUPPRESSMSGBOXES" -Wait
+
+          echo "C:/rtools45-aarch64/usr/bin;C:/rtools45-aarch64/aarch64-w64-mingw32.static.posix/bin" | Out-File -Append -FilePath $env:GITHUB_PATH -Encoding utf8
+          echo "C:/Program Files/R-aarch64/R-${{ matrix.config.r }}/bin" | Out-File -Append -FilePath $env:GITHUB_PATH -Encoding utf8
+
+      - name: Install pak on Windows ARM
+        if: matrix.config.os == 'windows-11-arm'
+        run: |
+          libsdir <- file.path(Sys.getenv("TMP"), "Library")
+          dir.create(libsdir, recursive = TRUE, showWarnings = FALSE)
+          cat(sprintf("R_LIB_FOR_PAK=%s\n", libsdir), file = Sys.getenv("GITHUB_ENV"), append = TRUE)
+          cat(sprintf("R_LIBS_USER=%s\n", libsdir), file = Sys.getenv("GITHUB_ENV"), append = TRUE)
+          install.packages("pak", lib = libsdir,
+                           repos = c("https://r-lib.r-universe.dev", "https://cloud.r-project.org"),
+                           Ncpus = 4);
+        shell: Rscript {0}
+
+      - uses: r-lib/actions/setup-r-dependencies@v2
+        with:
+          extra-packages: local::. any::rstan any::rstantools ${{ matrix.config.extra-pkgs }}
+          pak-version: ${{ matrix.config.os == 'windows-11-arm' && 'none' || 'stable' }}
+
+      - name: Get Package sources
+        run: |
+          git clone --depth 1 https://github.com/cran/ctsem.git
+          git clone --depth 1 https://github.com/cran/blavaan.git
+
+      - name: Check rstan stanc works with complex packages
+        run: |
+          rstantools::rstan_config("ctsem")
+          rstantools::rstan_config("blavaan")
+        shell: Rscript {0}
+
+      - name: Install development rstan
+        run: |
+          pak::repo_add('https://stan-dev.r-universe.dev')
+          pak::pak('rstan')
+        shell: Rscript {0}
+
+      - name: Check development rstan stanc works
+        run: |
+          rstantools::rstan_config("ctsem")
+          rstantools::rstan_config("blavaan")
+        shell: Rscript {0}

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: QuickJSR
 Title: Interface for the 'QuickJS-NG' Lightweight 'JavaScript' Engine
-Version: 1.8.0.9000
+Version: 1.8.1
 Authors@R: c(
     person(c("Andrew", "R."), "Johnson", , "[email protected]", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0001-7000-8065")),
@@ -23,6 +23,6 @@ Encoding: UTF-8
 Language: en-AU
 NeedsCompilation: yes
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.2
+RoxygenNote: 7.3.3
 SystemRequirements: GNU make
 VignetteBuilder: knitr

NEWS.md

@@ -1,3 +1,6 @@
+# QuickJSR 1.8.1
+  * Fix issue where `stack_size` option was ignored in `JSContext$new()`
+
 # QuickJSR 1.8.0
   * Update bundled QuickJS-NG engine to v0.10.1 (see https://github.com/quickjs-ng/quickjs/releases for release notes)
 

inst/include/quickjs_helpers.hpp

@@ -107,9 +107,8 @@ namespace quickjsr {
         return NULL;
     }
 
-    // Workaround for RStan stack overflow until they update
     if (stack_size != -1) {
-      JS_SetMaxStackSize(rt, 0);
+      JS_SetMaxStackSize(rt, stack_size);
     }
     js_std_set_worker_new_context_func(JS_NewCustomContext);
     js_std_init_handlers(rt);