Skip to content

Commit 5cf61d2

Browse files
committed
chore(tests): Remove deprecated usage of tasks.create() in the tests
1 parent 950707c commit 5cf61d2

File tree

2 files changed

+22
-14
lines changed

2 files changed

+22
-14
lines changed

plugin/src/test/kotlin/io/github/androa/gradle/plugin/avro/ErrorHandlingTest.kt

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,19 +75,21 @@ class ErrorHandlingTest {
7575
.builder()
7676
.withProjectDir(tempDir.toFile())
7777
.build()
78-
val task = project.tasks.create("generateAvro", GenerateAvroTask::class.java)
7978

8079
// Create an empty directory
8180
val emptyDir = tempDir.resolve("empty").toFile().apply { mkdirs() }
8281
val outputDir = tempDir.resolve("output").toFile().apply { mkdirs() }
8382

8483
// Configure task
85-
task.schemas.setFrom(emptyDir)
86-
task.outputDir.set(outputDir)
87-
task.intermediateDir.set(tempDir.resolve("intermediate").toFile())
84+
val taskProvider = project.tasks.register("generateAvro", GenerateAvroTask::class.java)
85+
taskProvider.configure { task ->
86+
task.schemas.setFrom(emptyDir)
87+
task.outputDir.set(outputDir)
88+
task.intermediateDir.set(tempDir.resolve("intermediate").toFile())
89+
}
8890

8991
// Execute - should not throw exception
90-
task.generate()
92+
taskProvider.get().generate()
9193

9294
// Verify output dir exists but is empty
9395
assertTrue(outputDir.exists(), "Output directory should exist")
@@ -101,7 +103,6 @@ class ErrorHandlingTest {
101103
.builder()
102104
.withProjectDir(tempDir.toFile())
103105
.build()
104-
val task = project.tasks.create("generateAvro", GenerateAvroTask::class.java)
105106

106107
// Create a malformed protocol file
107108
val malformedProtocol = tempDir.resolve("malformed.avpr").toFile()
@@ -124,15 +125,18 @@ class ErrorHandlingTest {
124125
""".trimIndent(),
125126
)
126127

128+
val taskProvider = project.tasks.register("generateAvro", GenerateAvroTask::class.java)
127129
// Configure task
128-
task.schemas.setFrom(malformedProtocol)
129-
task.outputDir.set(tempDir.resolve("output").toFile())
130-
task.intermediateDir.set(tempDir.resolve("intermediate").toFile())
130+
taskProvider.configure { task ->
131+
task.schemas.setFrom(malformedProtocol)
132+
task.outputDir.set(tempDir.resolve("output").toFile())
133+
task.intermediateDir.set(tempDir.resolve("intermediate").toFile())
134+
}
131135

132136
// Execute and verify
133137
val exception =
134138
assertThrows(Exception::class.java) {
135-
task.generate()
139+
taskProvider.get().generate()
136140
}
137141

138142
// Verify error message is helpful

plugin/src/test/kotlin/io/github/androa/gradle/plugin/avro/GenerateAvroTaskTest.kt

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,19 @@ class GenerateAvroTaskTest {
2626
fun setup() {
2727
// Create a test project and task
2828
project = ProjectBuilder.builder().withProjectDir(tempDir.toFile()).build()
29-
task = project.tasks.create("generateAvro", GenerateAvroTask::class.java)
29+
val taskProvider = project.tasks.register("generateAvro", GenerateAvroTask::class.java)
3030

3131
// Setup schema directory and output directory
3232
schemaDir = tempDir.resolve("schemas").toFile().apply { mkdirs() }
3333

3434
// Set up task properties
35-
task.schemas.setFrom(schemaDir)
36-
task.outputDir.set(tempDir.resolve("output").toFile())
37-
task.intermediateDir.set(tempDir.resolve("intermediate").toFile())
35+
taskProvider.configure { task ->
36+
task.schemas.setFrom(schemaDir)
37+
task.outputDir.set(tempDir.resolve("output").toFile())
38+
task.intermediateDir.set(tempDir.resolve("intermediate").toFile())
39+
}
40+
41+
task = taskProvider.get()
3842

3943
// Create output directory to avoid test failures
4044
task.outputDir

0 commit comments

Comments
 (0)