fix(autofill): fall back to remote views when inline presentations are unavailable

msfjarvis · msfjarvis · commit 89b47f6ae88b · 2022-12-12T21:40:25.000+05:30
Fixes #2290
diff --git a/app/src/main/java/app/passwordstore/util/autofill/Api30AutofillResponseBuilder.kt b/app/src/main/java/app/passwordstore/util/autofill/Api30AutofillResponseBuilder.kt
@@ -106,7 +106,11 @@ constructor(
       val inlinePresentation = makeInlinePresentation(context, imeSpec, metadata)
       if (inlinePresentation != null) {
         presentationsBuilder.setInlinePresentation(inlinePresentation)
+      } else {
+        presentationsBuilder.setMenuPresentation(makeRemoteView(context, metadata))
       }
+    } else {
+      presentationsBuilder.setMenuPresentation(makeRemoteView(context, metadata))
     }
     val presentations = presentationsBuilder.build()
     return Dataset.Builder(presentations).run {

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,11 @@ constructor(`
`106`	`106`	`val inlinePresentation = makeInlinePresentation(context, imeSpec, metadata)`
`107`	`107`	`if (inlinePresentation != null) {`
`108`	`108`	`presentationsBuilder.setInlinePresentation(inlinePresentation)`
	`109`	`+ } else {`
	`110`	`+ presentationsBuilder.setMenuPresentation(makeRemoteView(context, metadata))`
`109`	`111`	`}`
	`112`	`+ } else {`
	`113`	`+ presentationsBuilder.setMenuPresentation(makeRemoteView(context, metadata))`
`110`	`114`	`}`
`111`	`115`	`val presentations = presentationsBuilder.build()`
`112`	`116`	`return Dataset.Builder(presentations).run {`