Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Commit bfd9c1d

Browse files
authored
github: remove nonFree flavor from tests (#1102)
Our tests have zero differences between these flavors so running 4 jobs rather than 2 just slows us down Signed-off-by: Harsh Shandilya <[email protected]>
1 parent 0810273 commit bfd9c1d

File tree

1 file changed

+3
-16
lines changed

1 file changed

+3
-16
lines changed

.github/workflows/pull_request.yml

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ jobs:
77
strategy:
88
matrix:
99
api-level: [23, 29]
10-
variant: [freeDebug, nonFreeDebug]
1110
steps:
1211

1312
- name: Check if relevant files have changed
@@ -67,10 +66,10 @@ jobs:
6766
6867
- name: Run unit tests
6968
if: ${{ steps.service-changed.outputs.result == 'true' }}
70-
run: ./gradlew test${{ matrix.variant }} lint${{ matrix.variant}} -Dpre-dex=false
69+
run: ./gradlew testFreeDebug lintFreeDebug
7170

72-
- name: Run instrumentation tests on free flavor
73-
if: ${{ steps.service-changed.outputs.result == 'true' && matrix.variant == 'freeDebug' }}
71+
- name: Run instrumentation tests
72+
if: ${{ steps.service-changed.outputs.result == 'true' }}
7473
uses: reactivecircus/[email protected]
7574
with:
7675
api-level: ${{ matrix.api-level }}
@@ -81,18 +80,6 @@ jobs:
8180
adb shell settings put global window_animation_scale 0
8281
./gradlew :app:connectedFreeDebugAndroidTest
8382
84-
- name: Run instrumentation tests on nonFree flavor
85-
if: ${{ steps.service-changed.outputs.result == 'true' && matrix.variant == 'nonFreeDebug' }}
86-
uses: reactivecircus/[email protected]
87-
with:
88-
api-level: ${{ matrix.api-level }}
89-
target: default
90-
script: |
91-
adb shell settings put global animator_duration_scale 0
92-
adb shell settings put global transition_animation_scale 0
93-
adb shell settings put global window_animation_scale 0
94-
./gradlew :app:connectedNonFreeDebugAndroidTest
95-
9683
- name: (Fail-only) upload test report
9784
if: failure()
9885
uses: actions/upload-artifact@v2

0 commit comments

Comments
 (0)