Continue onboarding if permissions are granted prematurely (#1097)

msfjarvis · web-flow · commit f2647dfbe61d · 2020-09-12T19:28:42.000+02:00
Signed-off-by: Harsh Shandilya &lt;me@msfjarvis.dev&gt;
diff --git a/app/src/main/java/com/zeapo/pwdstore/OnboardingActivity.kt b/app/src/main/java/com/zeapo/pwdstore/OnboardingActivity.kt
@@ -122,6 +122,10 @@ class OnboardingActivity : AppCompatActivity() {
                         externalDirectorySelectAction.launch(UserPreference.createDirectorySelectionIntent(this))
                     }
                 }.launch(Manifest.permission.WRITE_EXTERNAL_STORAGE)
+            } else {
+                // Unlikely we have storage permissions without user ever selecting a directory,
+                // but let's not assume.
+                externalDirectorySelectAction.launch(UserPreference.createDirectorySelectionIntent(this))
             }
         } else {
             MaterialAlertDialogBuilder(this)

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,10 @@ class OnboardingActivity : AppCompatActivity() {`
`122`	`122`	`externalDirectorySelectAction.launch(UserPreference.createDirectorySelectionIntent(this))`
`123`	`123`	`}`
`124`	`124`	`}.launch(Manifest.permission.WRITE_EXTERNAL_STORAGE)`
	`125`	`+ } else {`
	`126`	`+ // Unlikely we have storage permissions without user ever selecting a directory,`
	`127`	`+ // but let's not assume.`
	`128`	`+ externalDirectorySelectAction.launch(UserPreference.createDirectorySelectionIntent(this))`
`125`	`129`	`}`
`126`	`130`	`} else {`
`127`	`131`	`MaterialAlertDialogBuilder(this)`