Use FLAG_IMMUTABLE instead of FLAG_MUTABLE for ActivityScenario pending implicit intents.

This fixes using ActivityScenario#launchActivityForResult with an implicit Intent
when targetSdk = 34.

Fixes #2193

PiperOrigin-RevId: 628490334

Author: brettchabot

core/CHANGELOG.md

@@ -6,7 +6,8 @@
 
 **Bug Fixes**
 
-* make ViewCapture use ControlledLooper API instead of hardcoding is Robolectric check
+* Make ViewCapture use ControlledLooper API instead of hardcoding is Robolectric check
+* Fix using ActivityScenario#launchActivityForResult with an implicit Intent
 
 **New Features**
 

core/java/androidx/test/core/app/InstrumentationActivityInvoker.java

@@ -445,6 +445,12 @@ public void startActivityForResult(Intent intent, @Nullable Bundle activityOptio
 
     activityOptionsBundle = optInToGrantBalPrivileges(activityOptionsBundle);
 
+    // make an immutable intent if its implicit
+    int intentMutability =
+        intent.getPackage() == null && intent.getComponent() == null
+            ? PendingIntent.FLAG_IMMUTABLE
+            : PendingIntent.FLAG_MUTABLE;
+
     // Note: Instrumentation.startActivitySync(Intent) cannot be used here because BootstrapActivity
     // may start in different process. Also, we use PendingIntent because the target activity may
     // set "exported" attribute to false so that it prohibits starting the activity outside of their
@@ -458,7 +464,7 @@ public void startActivityForResult(Intent intent, @Nullable Bundle activityOptio
                     getApplicationContext(),
                     /* requestCode= */ 0,
                     intent,
-                    /* flags= */ PendingIntent.FLAG_UPDATE_CURRENT | PendingIntent.FLAG_MUTABLE))
+                    /* flags= */ PendingIntent.FLAG_UPDATE_CURRENT | intentMutability))
             .putExtra(TARGET_ACTIVITY_OPTIONS_BUNDLE_KEY, activityOptionsBundle);
 
     getApplicationContext().startActivity(bootstrapIntent, activityOptionsBundle);

core/javatests/androidx/test/core/app/ActivityScenarioTest.java

@@ -540,6 +540,15 @@ public void launch_intentWithPackageName() {
     assertThat(activityScenario).isNotNull();
   }
 
+  @Test
+  public void launchActivityForResult_intentWithAction() {
+    Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse("scenario://test"));
+
+    ActivityScenario<IntentActivity> activityScenario =
+        ActivityScenario.launchActivityForResult(intent);
+    assertThat(activityScenario).isNotNull();
+  }
+
   private static Stage lastLifeCycleTransition(Activity activity) {
     return ActivityLifecycleMonitorRegistry.getInstance().getLifecycleStageOf(activity);
   }