Skip to content

Commit 593bed2

Browse files
Merge pull request #2128 from android:settings_gradle
PiperOrigin-RevId: 602546246
2 parents 761f92f + f328a24 commit 593bed2

File tree

6 files changed

+20
-48
lines changed

6 files changed

+20
-48
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ jobs:
7373
key: ${{ runner.os }}-${{ env.cache-version }}-bazel-test-${{ github.sha }}
7474
restore-keys: |
7575
${{ runner.os }}-${{ env.cache-version }}-bazel-test-
76-
- name: Run Robolectric tests
77-
run: bazelisk test --test_tag_filters=robolectric --build_tag_filters=robolectric --test_output=all ...
76+
- name: Run Robolectric tests and fast tagged tests
77+
run: bazelisk test --test_tag_filters=robolectric,fast --build_tag_filters=robolectric,fast --test_output=all ...
7878
shell: bash
7979
- name: 'Clean bazel cache'
8080
# Don't cache the bazel/external directory, since it can be > 2GB
@@ -131,4 +131,3 @@ jobs:
131131
name: test-reports
132132
path: gradle-tests/**/build/reports/androidTests/
133133

134-

tools/release/BUILD renamed to gradle-tests/BUILD.bazel

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
load("@bazel_skylib//rules:expand_template.bzl", "expand_template")
2+
load("@bazel_skylib//rules:diff_test.bzl", "diff_test")
23
load(
34
"//build_extensions:axt_versions.bzl",
45
"ANDROIDX_JUNIT_VERSION",
@@ -33,13 +34,22 @@ expand_template(
3334
"{RULES_VERSION}": RULES_VERSION,
3435
"{RUNNER_VERSION}": RUNNER_VERSION,
3536
"{SERVICES_VERSION}": SERVICES_VERSION,
37+
"{MODIFY_WARNING}": "// This file is auto-generated from tools/release/validation_and_propagate_versions.sh\n// DO NOT MODIFY locally",
3638
},
3739
template = "settings.gradle.template",
3840
)
3941

4042
genrule(
4143
name = "update_settings_gradle_rule",
4244
srcs = [":update_settings_gradle"],
43-
outs = ["settings.gradle"],
45+
outs = ["settings.gradle.generated"],
4446
cmd = "cp $(location :update_settings_gradle) \"$@\"",
4547
)
48+
49+
diff_test(
50+
name = "settings_gradle_diff_test",
51+
file1 = "settings.gradle",
52+
file2 = ":settings.gradle.generated",
53+
failure_message = "Unexpected diff detected in settings.gradle. Have you run tools/release/validate_and_propagate_versions.sh?",
54+
tags = ["fast"],
55+
)

gradle-tests/settings.gradle

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
// This file is auto-generated from tools/release/validation_and_propagate_versions.sh
2+
// DO NOT MODIFY locally
3+
14
pluginManagement {
25
repositories {
36
gradlePluginPortal()

gradle-tests/settings.gradle.previous

Lines changed: 0 additions & 41 deletions
This file was deleted.

tools/release/settings.gradle.template renamed to gradle-tests/settings.gradle.template

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
{MODIFY_WARNING}
2+
13
pluginManagement {
24
repositories {
35
gradlePluginPortal()
@@ -36,7 +38,6 @@ include ':runner'
3638
include ':espresso'
3739
include ':espresso:accessibility'
3840
include ':espresso:contrib'
39-
include ':espresso-device'
4041
include ':espresso:idling_resource'
4142
include ':espresso:web'
4243
include ':orchestrator'

tools/release/validate_and_propagate_versions.sh

100644100755
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@ OUTPUT=`bazelisk run //tools/release/java/androidx/test/tools/releaseupdater:rel
1717
if [[ ! -z "$OUTPUT" ]]; then
1818
echo $OUTPUT | xargs buildozer
1919
fi
20-
bazelisk build //tools/release:update_settings_gradle_rule
21-
cp bazel-bin/tools/release/settings.gradle gradle-tests/settings.gradle
20+
bazelisk build //gradle-tests:update_settings_gradle_rule
21+
cp bazel-bin/gradle-tests/settings.gradle.generated gradle-tests/settings.gradle

0 commit comments

Comments
 (0)