Skip to content

Commit 5a80466

Browse files
committed
Successful maven repo build.
In progress: android_locql_test
1 parent e83f6e4 commit 5a80466

File tree

8 files changed

+53
-44
lines changed

8 files changed

+53
-44
lines changed

MODULE.bazel

Lines changed: 28 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ bazel_dep(name = "rules_jvm_external", version = "6.6")
1010
bazel_dep(name = "rules_android", version = "0.6.0", repo_name = "build_bazel_rules_android")
1111
bazel_dep(name = "rules_kotlin", version = "1.9.6", repo_name = "io_bazel_rules_kotlin")
1212
bazel_dep(name = "protobuf", version = "29.0", repo_name = "com_google_protobuf")
13-
#bazel_dep(name = "io_grpc_grpc_java", version = "1.54.1")
13+
bazel_dep(name = "grpc-java", version = "1.68.1")
1414
#needed?
1515
#bazel_dep(name = "rules_python", version = "0.37.1")
1616
bazel_dep(name = "rules_robolectric", version = "4.14.1.2", repo_name = "robolectric")
@@ -24,6 +24,20 @@ single_version_override(
2424
# maven dependencies
2525
maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
2626

27+
maven.artifact(
28+
artifact = "accessibility-test-framework",
29+
# exclude the org.checkerframework dependency since that require
30+
# java8 compatibility. See b/176926990
31+
# accessibility-test-framework depends on hamcrest 2.2 which causes 'Using type org.hamcrest.Matcher from an indirect dependency' compile errors
32+
exclusions = [
33+
"org.checkerframework:checker",
34+
"org.hamcrest:hamcrest-core",
35+
"org.hamcrest:hamcrest-library",
36+
],
37+
group = "com.google.android.apps.common.testing.accessibility.framework",
38+
version = "3.1.2",
39+
)
40+
2741
maven.install(
2842
name = "maven",
2943
artifacts = [
@@ -46,47 +60,26 @@ maven.install(
4660
# "androidx.test.uiautomator:uiautomator:2.2.0",
4761
# "androidx.viewpager:viewpager:1.0.0",
4862
# "androidx.window:window:1.1.0",
49-
# "androidx.window:window-java:1.1.0",
50-
# "androidx.window:window-core:1.1.0",
63+
"androidx.window:window-java:1.1.0",
64+
"androidx.window:window-core:1.1.0",
5165
# "aopalliance:aopalliance:1.0",
5266
# "com.android.tools.lint:lint-api:30.1.0",
5367
# "com.android.tools.lint:lint-checks:30.1.0",
5468
# "com.beust:jcommander:1.72",
55-
# maven.artifact(
56-
# artifact = "accessibility-test-framework",
57-
# exclusions = [
58-
# # exclude the org.checkerframework dependency since that require
59-
# # java8 compatibility. See b/176926990
60-
# maven.exclusion(
61-
# artifact = "checker",
62-
# group = "org.checkerframework",
63-
# ),
64-
# # accessibility-test-framework depends on hamcrest 2.2 which causes 'Using type org.hamcrest.Matcher from an indirect dependency' compile errors
65-
# maven.exclusion(
66-
# artifact = "hamcrest-core",
67-
# group = "org.hamcrest",
68-
# ),
69-
# maven.exclusion(
70-
# artifact = "hamcrest-library",
71-
# group = "org.hamcrest",
72-
# ),
73-
# ],
74-
# group = "com.google.android.apps.common.testing.accessibility.framework",
75-
# version = "3.1.2",
76-
# ),
69+
7770
# "com.google.android.material:material:1.4.0",
7871
# "com.google.auto.value:auto-value:1.5.1",
7972
# "com.google.code.findbugs:jsr305:3.0.2",
8073
# "com.google.code.gson:gson:2.8.5",
81-
# "com.google.dagger:dagger-compiler:2.46",
82-
# "com.google.dagger:dagger-producers:2.46",
83-
# "com.google.dagger:dagger:2.46",
74+
"com.google.dagger:dagger-compiler:2.46",
75+
"com.google.dagger:dagger-producers:2.46",
76+
"com.google.dagger:dagger:2.46",
8477
# "com.google.errorprone:error_prone_annotations:2.9.0",
8578
# "com.google.errorprone:javac-shaded:9-dev-r4023-3",
8679
# "com.google.flogger:flogger-system-backend:0.4",
8780
# "com.google.flogger:flogger:0.4",
8881
# "com.google.flogger:google-extensions:0.4",
89-
# "com.google.googlejavaformat:google-java-format:1.4",
82+
"com.google.googlejavaformat:google-java-format:1.4",
9083
# "com.google.guava:guava:30.1.1-android",
9184
# "com.google.guava:listenablefuture:1.0",
9285
# "com.google.inject.extensions:guice-multibindings:4.1.0",
@@ -96,9 +89,9 @@ maven.install(
9689
# "com.linkedin.dexmaker:dexmaker-mockito:jar:2.28.1",
9790
# "com.linkedin.dexmaker:dexmaker:2.28.1",
9891
# "org.mockito.kotlin:mockito-kotlin:4.1.0",
99-
# "com.squareup:javapoet:1.9.0",
100-
# "io.grpc:grpc-okhttp:1.54.1",
101-
# "io.grpc:grpc-stub:1.54.1",
92+
"com.squareup:javapoet:1.9.0",
93+
"io.grpc:grpc-okhttp:1.54.1",
94+
"io.grpc:grpc-stub:1.54.1",
10295
# "org.apache.tomcat:annotations-api:6.0.53",
10396
# "javax.annotation:javax.annotation-api:1.3.1",
10497
# "javax.inject:javax.inject:1",
@@ -107,7 +100,7 @@ maven.install(
107100
# "net.bytebuddy:byte-buddy-agent:1.9.10",
108101
# "net.bytebuddy:byte-buddy:1.9.10",
109102
# "net.sf.kxml:kxml2:jar:2.3.0",
110-
# "org.ccil.cowan.tagsoup:tagsoup:1.2.1",
103+
"org.ccil.cowan.tagsoup:tagsoup:1.2.1",
111104
# "org.checkerframework:checker-compat-qual:2.5.5",
112105
# "org.hamcrest:hamcrest-core:1.3",
113106
"org.hamcrest:hamcrest-library:1.3",
@@ -142,6 +135,8 @@ maven.install(
142135
],
143136
)
144137

138+
139+
145140
use_repo(maven, "maven")
146141

147142

build_extensions/axt_android_local_test.bzl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
load("@io_bazel_rules_kotlin//kotlin:android.bzl", "kt_android_library")
44
load("//build_extensions:create_jar.bzl", "create_jar")
5+
load("@build_bazel_rules_android//android:rules.bzl", "android_local_test")
56

67
def axt_android_local_test(name, srcs = [], deps = [], manifest = "//build_extensions:AndroidManifest_robolectric.xml", tags = ["robolectric"], **kwargs):
78
"""A wrapper around android_local_test that provides sensible defaults for androidx.test.
@@ -41,12 +42,12 @@ def axt_android_local_test(name, srcs = [], deps = [], manifest = "//build_exten
4142
exports_manifest = True,
4243
manifest = manifest,
4344
deps = deps,
44-
testonly = 1,
45+
testonly = True,
4546
)
4647
deps = [":%s_kt_lib" % name]
4748
srcs = []
4849

49-
native.android_local_test(
50+
android_local_test(
5051
name = name,
5152
srcs = srcs,
5253
tags = tags,

build_extensions/maven/axt_maven_apk.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
load("@rules_java//java:defs.bzl", "JavaInfo")
44
load("//build_extensions/maven:combine_jars.bzl", "combine_jars")
55
load("//build_extensions/maven:maven_info.bzl", "MavenFilesInfo", "MavenInfo", "collect_maven_apk_info")
6+
load("@build_bazel_rules_android//providers:providers.bzl", "ApkInfo")
67

78
def _axt_maven_apk_impl(ctx):
89
# produce src jar

build_extensions/maven/maven_info.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ def _isJavaProtoTarget(all_deps):
150150

151151
def _findGrpcJavaProtoJar(target):
152152
for jar in target[JavaInfo].transitive_runtime_jars.to_list():
153-
if "io_grpc_grpc_java/protobuf-lite" in jar.path:
153+
if "grpc-java/protobuf-lite" in jar.path:
154154
return jar
155155
return None
156156

build_extensions/maven/maven_registry.bzl

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,18 @@ _TARGET_TO_MAVEN_ARTIFACT = {
4545
"//services/events/java/": "androidx.test:runner:%s" % RUNNER_VERSION,
4646
"//services:test_services": "androidx.test.services:test-services:%s" % SERVICES_VERSION,
4747
"//runner/android_test_orchestrator/stubapp:stubapp": "androidx.test:orchestrator:%s" % ORCHESTRATOR_VERSION,
48+
49+
"@@grpc-java~//okhttp:okhttp": "io.grpc:grpc-okhttp:1.54.1",
50+
"@@grpc-java~//api": "io.grpc:grpc-stub:1.54.1",
51+
"@@grpc-java~//core": "io.grpc:grpc-stub:1.54.1",
52+
"@@grpc-java~//context": "io.grpc:grpc-stub:1.54.1",
53+
"@@grpc-java~//util": "io.grpc:grpc-stub:1.54.1",
54+
"@@grpc-java~//stub": "io.grpc:grpc-stub:1.54.1",
4855
}
4956

5057
_SHADED_TARGETS = [
5158
"@com_google_protobuf//:protobuf_javalite",
52-
"@com_google_protobuf//java/core:lite",
59+
"@@protobuf~//java/core:lite",
5360
"//opensource/proto:any_java_proto_lite",
5461
"@com_google_protobuf//:any_proto",
5562
"//opensource/dagger:dagger",
@@ -110,6 +117,6 @@ def is_shaded_from_label(label):
110117
renamed via jarjar.
111118
"""
112119

113-
# bazel 6.0.0 mysteriously prefixes a '@' onto //opensource/dagger, so just remove it
114-
string_label = str(label).replace("@//", "//")
120+
# bazel mysteriously prefixes a '@' onto //opensource/dagger, sometimes two, so just remove it
121+
string_label = str(label).replace("@//", "//").replace("@//", "//")
115122
return string_label in _SHADED_TARGETS

opensource/emulator/proto/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Protos for interacting with emulator
22

3-
load("@io_grpc_grpc_java//:java_grpc_library.bzl", "java_grpc_library")
3+
load("@grpc-java//:java_grpc_library.bzl", "java_grpc_library")
44

55
package(
66
default_applicable_licenses = ["//espresso:license"],

runner/android_junit_runner/javatests/androidx/test/internal/events/client/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ axt_android_local_test(
2727

2828
android_library(
2929
name = "sampletest",
30-
testonly = 1,
3130
srcs = ["SampleJUnitTest.java"],
32-
testonly = 1,
3331
deps = ["@maven//:junit_junit"],
3432
)
3533

services/shellexecutor/java/androidx/test/services/shellexecutor/BUILD

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ load("@com_google_protobuf//bazel:java_lite_proto_library.bzl", "java_lite_proto
22
load("@com_google_protobuf//bazel:proto_library.bzl", "proto_library")
33
load("@rules_java//java:defs.bzl", "java_library")
44
load("//build_extensions:kt_android_library.bzl", "kt_android_library")
5+
load("@build_bazel_rules_android//android:rules.bzl", "android_library")
56

67
# A shell command execution server to allow shell commands to be run at elevated permissions
78

@@ -38,6 +39,12 @@ kt_android_library(
3839
],
3940
)
4041

42+
android_library(
43+
name = "exec_idl",
44+
idl_srcs = ["Command.aidl"],
45+
visibility = ["//visibility:private"],
46+
)
47+
4148
kt_android_library(
4249
name = "exec_server",
4350
srcs = [
@@ -50,9 +57,9 @@ kt_android_library(
5057
"ShellExecSharedConstants.java",
5158
"ShellMain.java",
5259
],
53-
idl_srcs = ["Command.aidl"],
5460
visibility = [":export"],
5561
deps = [
62+
":exec_idl",
5663
":local_socket_protocol",
5764
":local_socket_protocol_pb_java_proto_lite",
5865
"//services/speakeasy/java/androidx/test/services/speakeasy:protocol",
@@ -77,9 +84,9 @@ kt_android_library(
7784
"ShellExecutorImpl.java",
7885
"ShellExecutorLocalSocketImpl.kt",
7986
],
80-
idl_srcs = ["Command.aidl"],
8187
visibility = [":export"],
8288
deps = [
89+
":exec_idl",
8390
":local_socket_protocol",
8491
":local_socket_protocol_pb_java_proto_lite",
8592
"//services/speakeasy/java/androidx/test/services/speakeasy:protocol",

0 commit comments

Comments
 (0)