Skip to content

Commit ac75043

Browse files
Paige McAuliffecopybara-androidxtest
authored andcommitted
Remove ActionContext interface
PiperOrigin-RevId: 548727053
1 parent 9e342a2 commit ac75043

19 files changed

+47
-164
lines changed

espresso/device/java/androidx/test/espresso/device/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ kt_android_library(
3737
deps = [
3838
"//annotation/java/androidx/test/annotation",
3939
"//espresso/device/java/androidx/test/espresso/device/action",
40-
"//espresso/device/java/androidx/test/espresso/device/context",
4140
"//espresso/device/java/androidx/test/espresso/device/dagger",
4241
"//espresso/device/java/androidx/test/espresso/device/sizeclass",
4342
"//opensource/dagger",

espresso/device/java/androidx/test/espresso/device/DeviceInteraction.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import androidx.test.espresso.device.action.setDisplaySize as getSetDisplaySizeD
2424
import androidx.test.espresso.device.action.setFlatMode as getSetFlatModeDeviceAction
2525
import androidx.test.espresso.device.action.setScreenOrientation as getSetScreenOrientationDeviceAction
2626
import androidx.test.espresso.device.action.setTabletopMode as getSetTabletopModeDeviceAction
27-
import androidx.test.espresso.device.context.ActionContext
2827
import androidx.test.espresso.device.sizeclass.HeightSizeClass
2928
import androidx.test.espresso.device.sizeclass.WidthSizeClass
3029
import androidx.test.internal.util.Checks.checkNotMainThread
@@ -37,9 +36,7 @@ import javax.inject.Inject
3736
* <p>This API is experimental and subject to change.
3837
*/
3938
@ExperimentalTestApi
40-
class DeviceInteraction
41-
@Inject
42-
constructor(private val context: ActionContext, private val deviceController: DeviceController) {
39+
class DeviceInteraction @Inject constructor(private val deviceController: DeviceController) {
4340

4441
/**
4542
* Performs the given action on the test device. This method should not be called on the main
@@ -51,7 +48,7 @@ constructor(private val context: ActionContext, private val deviceController: De
5148
*/
5249
fun perform(action: DeviceAction): DeviceInteraction {
5350
checkNotMainThread()
54-
action.perform(context, deviceController)
51+
action.perform(deviceController)
5552
return this
5653
}
5754

espresso/device/java/androidx/test/espresso/device/EspressoDevice.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class EspressoDevice private constructor() {
3939
@JvmStatic
4040
fun onDevice(): DeviceInteraction {
4141
checkNotMainThread()
42-
return DeviceInteraction(BASE.actionContext(), BASE.deviceController())
42+
return DeviceInteraction(BASE.deviceController())
4343
}
4444
}
4545
}

espresso/device/java/androidx/test/espresso/device/action/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ kt_android_library(
1919
deps = [
2020
"//annotation/java/androidx/test/annotation",
2121
"//espresso/device/java/androidx/test/espresso/device/common",
22-
"//espresso/device/java/androidx/test/espresso/device/context",
2322
"//espresso/device/java/androidx/test/espresso/device/controller",
2423
"//espresso/device/java/androidx/test/espresso/device/sizeclass",
2524
"//runner/monitor",

espresso/device/java/androidx/test/espresso/device/action/BaseSingleFoldDeviceAction.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import androidx.test.espresso.device.common.executeShellCommand
2121
import androidx.test.espresso.device.common.getMapOfDeviceStateNamesToIdentifiers
2222
import androidx.test.espresso.device.common.getResumedActivityOrNull
2323
import androidx.test.espresso.device.common.isRobolectricTest
24-
import androidx.test.espresso.device.context.ActionContext
2524
import androidx.test.espresso.device.controller.DeviceControllerOperationException
2625
import androidx.test.espresso.device.controller.DeviceMode
2726
import androidx.test.platform.device.DeviceController
@@ -50,7 +49,7 @@ internal open class BaseSingleFoldDeviceAction(
5049
}
5150

5251
@OptIn(androidx.window.core.ExperimentalWindowApi::class)
53-
override fun perform(context: ActionContext, deviceController: DeviceController) {
52+
override fun perform(deviceController: DeviceController) {
5453
if (isRobolectricTest()) {
5554
deviceController.setDeviceMode(deviceMode.getMode())
5655
return

espresso/device/java/androidx/test/espresso/device/action/BookModeAction.kt

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ package androidx.test.espresso.device.action
1818

1919
import android.content.res.Configuration
2020
import android.util.Log
21-
import androidx.test.espresso.device.context.ActionContext
2221
import androidx.test.espresso.device.controller.DeviceControllerOperationException
2322
import androidx.test.espresso.device.controller.DeviceMode
23+
import androidx.test.platform.app.InstrumentationRegistry
2424
import androidx.test.platform.device.DeviceController
2525
import androidx.window.layout.FoldingFeature
2626
import java.util.concurrent.Executor
@@ -32,9 +32,9 @@ internal class BookModeAction(private val mainExecutor: Executor) :
3232
private val TAG = BookModeAction::class.java.simpleName
3333
}
3434

35-
override fun perform(context: ActionContext, deviceController: DeviceController) {
35+
override fun perform(deviceController: DeviceController) {
3636
// TODO(b/203801760): Check current device mode and return if already in book mode.
37-
super.perform(context, deviceController)
37+
super.perform(deviceController)
3838

3939
if (super.foldingFeatureOrientation == null) {
4040
throw DeviceControllerOperationException(
@@ -43,14 +43,18 @@ internal class BookModeAction(private val mainExecutor: Executor) :
4343
} else if (super.foldingFeatureOrientation != FoldingFeature.Orientation.VERTICAL) {
4444
Log.d(TAG, "FoldingFeature orientation needs to be rotated.")
4545
val orientationToRotateTo =
46-
if (context.applicationContext.getResources().getConfiguration().orientation ==
47-
Configuration.ORIENTATION_PORTRAIT
46+
if (
47+
InstrumentationRegistry.getInstrumentation()
48+
.getTargetContext()
49+
.getResources()
50+
.getConfiguration()
51+
.orientation == Configuration.ORIENTATION_PORTRAIT
4852
) {
4953
ScreenOrientation.LANDSCAPE
5054
} else {
5155
ScreenOrientation.PORTRAIT
5256
}
53-
ScreenOrientationAction(orientationToRotateTo).perform(context, deviceController)
57+
ScreenOrientationAction(orientationToRotateTo).perform(deviceController)
5458
}
5559
}
5660
}

espresso/device/java/androidx/test/espresso/device/action/ClosedModeAction.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,14 @@ package androidx.test.espresso.device.action
1919
import android.util.Log
2020
import androidx.test.espresso.device.common.executeShellCommand
2121
import androidx.test.espresso.device.common.getMapOfDeviceStateNamesToIdentifiers
22-
import androidx.test.espresso.device.context.ActionContext
2322
import androidx.test.espresso.device.controller.DeviceMode
2423
import androidx.test.platform.device.DeviceController
2524
import java.util.concurrent.Executor
2625

2726
/** Action to set the test device to be closed. */
2827
internal class ClosedModeAction(private val mainExecutor: Executor) :
2928
BaseSingleFoldDeviceAction(DeviceMode.CLOSED, null, mainExecutor) {
30-
override fun perform(context: ActionContext, deviceController: DeviceController) {
29+
override fun perform(deviceController: DeviceController) {
3130
val currentDeviceStateIdentifier = executeShellCommand("cmd device_state print-state").trim()
3231
if (currentDeviceStateIdentifier == getMapOfDeviceStateNamesToIdentifiers().get("CLOSED")) {
3332
if (Log.isLoggable(TAG, Log.DEBUG)) {
@@ -36,7 +35,7 @@ internal class ClosedModeAction(private val mainExecutor: Executor) :
3635
return
3736
}
3837

39-
super.perform(context, deviceController)
38+
super.perform(deviceController)
4039
}
4140

4241
companion object {

espresso/device/java/androidx/test/espresso/device/action/DeviceAction.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package androidx.test.espresso.device.action
1818

1919
import androidx.test.annotation.ExperimentalTestApi
20-
import androidx.test.espresso.device.context.ActionContext
2120
import androidx.test.platform.device.DeviceController
2221

2322
/** Responsible for performing an interaction on the given device. */
@@ -26,8 +25,7 @@ interface DeviceAction {
2625
/**
2726
* Performs this action on the given device.
2827
*
29-
* @param context the ActionContext containing the context for this application and test app.
3028
* @param deviceController the controller to use to interact with the device.
3129
*/
32-
fun perform(context: ActionContext, deviceController: DeviceController)
30+
fun perform(deviceController: DeviceController)
3331
}

espresso/device/java/androidx/test/espresso/device/action/DisplaySizeAction.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import androidx.test.espresso.device.common.calculateCurrentDisplayWidthAndHeigh
2525
import androidx.test.espresso.device.common.executeShellCommand
2626
import androidx.test.espresso.device.common.getDeviceApiLevel
2727
import androidx.test.espresso.device.common.getResumedActivityOrNull
28-
import androidx.test.espresso.device.context.ActionContext
2928
import androidx.test.espresso.device.controller.DeviceControllerOperationException
3029
import androidx.test.espresso.device.sizeclass.HeightSizeClass
3130
import androidx.test.espresso.device.sizeclass.WidthSizeClass
@@ -40,7 +39,7 @@ internal class DisplaySizeAction(
4039
val widthDisplaySize: WidthSizeClass,
4140
val heightDisplaySize: HeightSizeClass
4241
) : DeviceAction {
43-
override fun perform(context: ActionContext, deviceController: DeviceController) {
42+
override fun perform(deviceController: DeviceController) {
4443
if (getDeviceApiLevel() < 24) {
4544
throw UnsupportedDeviceOperationException(
4645
"Setting display size is not supported on devices with APIs below 24."

espresso/device/java/androidx/test/espresso/device/action/FlatModeAction.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ package androidx.test.espresso.device.action
1919
import android.util.Log
2020
import androidx.test.espresso.device.common.executeShellCommand
2121
import androidx.test.espresso.device.common.getMapOfDeviceStateNamesToIdentifiers
22-
import androidx.test.espresso.device.context.ActionContext
2322
import androidx.test.espresso.device.controller.DeviceMode
2423
import androidx.test.platform.device.DeviceController
2524
import androidx.window.layout.FoldingFeature
@@ -28,7 +27,7 @@ import java.util.concurrent.Executor
2827
/** Action to set the test device to be completely flat, like a tablet. */
2928
internal class FlatModeAction(private val mainExecutor: Executor) :
3029
BaseSingleFoldDeviceAction(DeviceMode.FLAT, FoldingFeature.State.FLAT, mainExecutor) {
31-
override fun perform(context: ActionContext, deviceController: DeviceController) {
30+
override fun perform(deviceController: DeviceController) {
3231
val currentDeviceStateIdentifier = executeShellCommand("cmd device_state print-state").trim()
3332
if (currentDeviceStateIdentifier == getMapOfDeviceStateNamesToIdentifiers().get("OPENED")) {
3433
if (Log.isLoggable(TAG, Log.DEBUG)) {
@@ -37,7 +36,7 @@ internal class FlatModeAction(private val mainExecutor: Executor) :
3736
return
3837
}
3938

40-
super.perform(context, deviceController)
39+
super.perform(deviceController)
4140
}
4241

4342
companion object {

0 commit comments

Comments
 (0)