Change androidx_test targets to default to testonly = 1.

multiprocess onClick definitions were also moved from xml to java to placate a lint check.

PiperOrigin-RevId: 737765858

Author: brettchabot

build_extensions/kt_android_library.bzl

@@ -3,5 +3,6 @@
 
 load("@io_bazel_rules_kotlin//kotlin:android.bzl", io_kt_android_library = "kt_android_library")
 
-def kt_android_library(**kwargs):
-    io_kt_android_library(**kwargs)
+def kt_android_library(testonly = 1, **kwargs):
+    # explicitly set testonly to 1 because io_kt_android_library doesn't seem to respect package(default_testonly = 1)
+    io_kt_android_library(testonly = testonly, **kwargs)

core/BUILD

@@ -1,12 +1,14 @@
 # Publicly visible androidx.test.core API library
 
-package(default_applicable_licenses = ["//:license"])
+package(
+    default_applicable_licenses = ["//:license"],
+    default_testonly = 1,
+)
 
 licenses(["notice"])
 
 alias(
     name = "core",
-    testonly = 1,
     actual = "//core/java/androidx/test/core",
     visibility = ["//visibility:public"],
 )
@@ -16,7 +18,6 @@ alias(
 # for the bootstrap activities
 alias(
     name = "manifest",
-    testonly = 1,
     actual = "//core/java/androidx/test/core:manifest",
     visibility = ["//visibility:public"],
 )

core/java/androidx/test/core/BUILD

@@ -10,6 +10,7 @@ load("//build_extensions/maven:maven_artifact.bzl", "maven_artifact")
 # all users should reference the equivalent targets in //core
 package(
     default_applicable_licenses = ["//:license"],
+    default_testonly = 1,
     default_visibility = [
         ":allowlist",
     ],
@@ -29,13 +30,15 @@ licenses(["notice"])
 # for the bootstrap activities
 android_library(
     name = "manifest",
+    testonly = 0,
     exports_manifest = 1,
     manifest = "AndroidManifest.xml",
     resource_files = glob(["res/**"]),
 )
 
 kt_android_library(
     name = "core_internal",
+    testonly = 0,
     srcs = glob(
         [
             "**/*.java",
@@ -59,20 +62,19 @@ kt_android_library(
 # TODO(b/199522848): delete these targets once espresso moves to testonly
 android_library(
     name = "core",
-    testonly = 1,
     exports = [":core_internal"],
 )
 
 android_library(
     name = "core_not_test_only",
+    testonly = 0,
     visibility = ["//espresso/core/java/androidx/test/espresso:__subpackages__"],
     exports = [":core_internal"],
 )
 
 # kt_android_library does not produce an aar, so wrap in a android_library for release
 android_library(
     name = "core_aar_lib",
-    testonly = 1,
     manifest = "AndroidManifest.xml",
     resource_files = glob(["res/**"]),
     visibility = ["//visibility:private"],
@@ -90,7 +92,6 @@ alias(
 # Generate rules for the release artifacts.
 axt_android_aar(
     name = "core_aar",
-    testonly = 1,
     expected_class_prefixes = [
         "androidx.test.core",
     ],
@@ -99,7 +100,6 @@ axt_android_aar(
 
 maven_artifact(
     name = "core_maven_artifact",
-    testonly = 1,
     last_updated = "20180403000000",
     target = ":core_aar",
 )

core/javatests/androidx/test/core/app/testing/BUILD

@@ -12,7 +12,6 @@ licenses(["notice"])
 
 kt_android_library(
     name = "testing",
-    testonly = 1,
     srcs = glob([
         "**/*.java",
         "**/*.kt",

espresso/BUILD

@@ -1,6 +1,9 @@
 load("@rules_license//rules:license.bzl", "license")
 
-package(default_applicable_licenses = ["//espresso:license"])
+package(
+    default_applicable_licenses = ["//espresso:license"],
+    default_testonly = 1,
+)
 
 license(
     name = "license",

espresso/accessibility/java/androidx/test/espresso/accessibility/BUILD

@@ -10,12 +10,12 @@ licenses(["notice"])
 
 package(
     default_applicable_licenses = ["//espresso:license"],
+    default_testonly = 1,
     default_visibility = ["//:__subpackages__"],
 )
 
 android_library(
     name = "accessibility_checks",
-    testonly = 1,
     srcs = [
         "AccessibilityChecks.java",
     ],
@@ -31,7 +31,6 @@ android_library(
 
 axt_android_aar(
     name = "accessibility_checks_aar",
-    testonly = 1,
     expected_class_prefixes = [
         "androidx.test.espresso.accessibility",
     ],
@@ -40,7 +39,6 @@ axt_android_aar(
 
 maven_artifact(
     name = "accessibility_checks_maven_artifact",
-    testonly = 1,
     last_updated = "20170622000000",
     target = ":accessibility_checks_aar",
 )

espresso/accessibility/javatests/androidx/test/espresso/accessibility/BUILD

@@ -6,7 +6,10 @@ load(
     "axt_android_library_test",
 )
 
-package(default_applicable_licenses = ["//espresso:license"])
+package(
+    default_applicable_licenses = ["//espresso:license"],
+    default_testonly = 1,
+)
 
 licenses(["notice"])
 

espresso/contrib/java/androidx/test/espresso/contrib/BUILD

@@ -12,6 +12,7 @@ licenses(["notice"])
 
 package(
     default_applicable_licenses = ["//espresso:license"],
+    default_testonly = 1,
     default_visibility = ["//:__subpackages__"],
 )
 
@@ -51,7 +52,6 @@ android_library(
 
 android_library(
     name = "picker_actions",
-    testonly = 1,
     srcs = ["PickerActions.java"],
     visibility = ["//visibility:public"],
     deps = [
@@ -70,6 +70,7 @@ COMMON_JAVACOPTS = [
 
 jetify_android_library(
     name = "recycler_view",
+    testonly = 0,
     srcs = ["RecyclerViewActions.java"],
     javacopts = COMMON_JAVACOPTS,
     jetify_sources = True,
@@ -87,7 +88,6 @@ jetify_android_library(
 
 android_library(
     name = "drawer_actions",
-    testonly = 1,
     srcs = [
         "DrawerActions.java",
         "DrawerMatchers.java",
@@ -116,7 +116,6 @@ android_library(
 
 android_library(
     name = "accessibility_checks",
-    testonly = 1,
     srcs = [
         "AccessibilityChecks.java",
     ],
@@ -130,7 +129,6 @@ android_library(
 
 android_library(
     name = "design_lib_actions",
-    testonly = 1,
     srcs = ["NavigationViewActions.java"],
     visibility = ["//visibility:public"],
     deps = [
@@ -146,7 +144,6 @@ android_library(
 
 android_library(
     name = "view_pager_actions",
-    testonly = 1,
     srcs = ["ViewPagerActions.java"],
     visibility = ["//visibility:public"],
     deps = [
@@ -160,7 +157,6 @@ android_library(
 
 android_library(
     name = "espresso_contrib_aar_lib",
-    testonly = 1,
     manifest = "AndroidManifest.xml",
     resource_files = glob(["res/**"]),
     exports = [
@@ -176,7 +172,6 @@ android_library(
 
 axt_android_aar(
     name = "espresso_contrib_aar",
-    testonly = 1,
     expected_class_prefixes = [
         "androidx.test.espresso.contrib",
     ],
@@ -185,7 +180,6 @@ axt_android_aar(
 
 maven_artifact(
     name = "espresso_contrib_maven_artifact",
-    testonly = 1,
     last_updated = "20170622000000",
     target = ":espresso_contrib_aar",
 )

espresso/contrib/javatests/androidx/test/espresso/contrib/BUILD

@@ -7,14 +7,16 @@ load(
 )
 load("//build_extensions:jetify.bzl", "jetify_android_library")
 
-package(default_applicable_licenses = ["//espresso:license"])
+package(
+    default_applicable_licenses = ["//espresso:license"],
+    default_testonly = 1,
+)
 
 licenses(["notice"])
 ## Android tests
 
 jetify_android_library(
     name = "recycler_view_tests",
-    testonly = 1,
     srcs = [
         "RecyclerViewGridLayoutManagerTest.java",
         "RecyclerViewIntegrationTest.java",

espresso/core/BUILD

@@ -1,12 +1,14 @@
 # Alias for androidx.test.espresso.core API library
 
-package(default_applicable_licenses = ["//espresso:license"])
+package(
+    default_applicable_licenses = ["//espresso:license"],
+    default_testonly = 1,
+)
 
 licenses(["notice"])
 
 alias(
     name = "core",
-    testonly = 1,
     actual = "//espresso/core/java/androidx/test/espresso",
     visibility = ["//visibility:public"],
 )