Replace use of @bazel_tools//tools/jdk:jar with custom utility.

bazel 7.5 no longer exposes direct access to the 'jar' executable.
Use of it was suboptimal anyway, since its use is cryptic and by
default can produce a jar that contains files with timestamps,
hampering build reproducibility.

Instead, this commit creates a simple standalone java_binary that can
create a jar.

Also remove unused maven_artifact:override_license_file

PiperOrigin-RevId: 730642408

Author: brettchabot

build_extensions/axt_android_local_test.bzl

@@ -1,17 +1,7 @@
 """A rule wrapper for generating android_local_test ."""
 
 load("@io_bazel_rules_kotlin//kotlin:android.bzl", "kt_android_library")
-
-_CONFIG_JAR_COMMAND = """
-set -e
-JAR="$(location @bazel_tools//tools/jdk:jar)"
-SRC="$<"
-[[ "$$(basename "$${SRC}")" = 'robolectric.properties' ]] || {
-  echo 'Must be named: robolectric.properties';
-  exit 1;
-}
-$${JAR} -cf "$@" -C "$$(dirname "$${SRC}")" "$$(basename "$${SRC}")"
-"""
+load("//build_extensions:create_jar.bzl", "create_jar")
 
 def axt_android_local_test(name, srcs = [], deps = [], manifest = "//build_extensions:AndroidManifest_robolectric.xml", tags = ["robolectric"], **kwargs):
     """A wrapper around android_local_test that provides sensible defaults for androidx.test.
@@ -72,21 +62,14 @@ def _robolectric_config(name, src):
       name: a string, the name of the rule
       src: a label, the properties file to package
     """
-    native.genrule(
+    create_jar(
         name = name + "_gen",
         srcs = [src],
-        outs = ["%s.jar" % name],
-        message = "Generating Robolectric config...",
-        cmd = _CONFIG_JAR_COMMAND,
-        tools = [
-            "@bazel_tools//tools/jdk:jar",
-        ],
-        visibility = ["//visibility:private"],
     )
     native.java_import(
         name = name,
         constraints = ["android"],
-        jars = [name + "_gen"],
+        jars = [name + "_gen.jar"],
     )
 
 def _is_kotlin(srcs):

build_extensions/create_jar.bzl

@@ -0,0 +1,38 @@
+"""Build rule to create a single jar from given files of any type."""
+
+def _create_jar_impl(ctx):
+    """
+    Construct a single jar from given files of any type.
+    """
+
+    input_paths = []
+    for target in ctx.attr.srcs:
+        input_paths.extend(target.files.to_list())
+
+    args = ctx.actions.args()
+    args.add(ctx.outputs.output)
+    args.add_all(input_paths)
+
+    ctx.actions.run(
+        inputs = input_paths,
+        outputs = [ctx.outputs.output],
+        executable = ctx.executable._create_jar_java,
+        arguments = [args],
+        mnemonic = "CreateJAR",
+    )
+
+create_jar = rule(
+    attrs = {
+        "srcs": attr.label_list(allow_files = True),
+        "_create_jar_java": attr.label(
+            executable = True,
+            cfg = "exec",
+            allow_files = True,
+            default = Label("//build_extensions/jar_creator/java/androidx/test/tools/jarcreator:jarcreator"),
+        ),
+    },
+    outputs = {
+        "output": "%{name}.jar",
+    },
+    implementation = _create_jar_impl,
+)

build_extensions/jar_creator/java/androidx/test/tools/jarcreator/BUILD

@@ -0,0 +1,23 @@
+load("@io_bazel_rules_kotlin//kotlin:jvm.bzl", "kt_jvm_library")
+
+package(
+    default_visibility = [
+        "//:__subpackages__",
+    ],
+)
+
+kt_jvm_library(
+    name = "jarcreator_lib",
+    srcs = glob([
+        "*.kt",
+    ]),
+)
+
+java_binary(
+    name = "jarcreator",
+    srcs = ["Main.java"],
+    main_class = "androidx.test.tools.jarcreator.Main",
+    deps = [
+        ":jarcreator_lib",
+    ],
+)

build_extensions/jar_creator/java/androidx/test/tools/jarcreator/JarCreator.kt

@@ -0,0 +1,51 @@
+/*
+ * Copyright 2025 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package androidx.test.tools.jarcreator
+
+import java.io.BufferedInputStream
+import java.io.File
+import java.io.FileInputStream
+import java.io.FileOutputStream
+import java.io.InputStream
+import java.util.jar.JarEntry
+import java.util.jar.JarOutputStream
+
+/**
+ * This is a simple utility that creates a jar file of input files.
+ *
+ * Unlike other solutions like invoking jar command directly or using bazel's
+ * java_common.pack_sources, this will create a jar without timestamp and with files in the root
+ * directory of the jar.
+ */
+fun createJar(args: Array<String>) {
+  require(args.size >= 2) { "Must provide at least two files: <output> <input...>" }
+
+  val outputFile = args[0]
+  val jarOutputStream = JarOutputStream(FileOutputStream(outputFile, false))
+  jarOutputStream.use {
+    for (i in 1 until args.size) {
+      val inputFile = File(args[i])
+      val inputStream = BufferedInputStream(FileInputStream(inputFile))
+      inputStream.use { addToJar(jarOutputStream, inputStream, inputFile) }
+    }
+  }
+}
+
+private fun addToJar(jarOutputStream: JarOutputStream, inputStream: InputStream, inputFile: File) {
+  val entry = JarEntry(inputFile.name)
+  jarOutputStream.putNextEntry(entry)
+  inputStream.transferTo(jarOutputStream)
+}

build_extensions/jar_creator/java/androidx/test/tools/jarcreator/Main.java

@@ -0,0 +1,24 @@
+/*
+ * Copyright 2025 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package androidx.test.tools.jarcreator;
+
+public class Main {
+  private Main() {}
+
+  public static void main(String[] args) {
+    JarCreatorKt.createJar(args);
+  }
+}

build_extensions/jar_creator/javatests/androidx/test/tools/jarcreator/BUILD

@@ -0,0 +1,11 @@
+load("@io_bazel_rules_kotlin//kotlin:jvm.bzl", "kt_jvm_test")
+
+kt_jvm_test(
+    name = "JarCreatorTest",
+    srcs = ["JarCreatorTest.kt"],
+    deps = [
+        "//build_extensions/jar_creator/java/androidx/test/tools/jarcreator:jarcreator_lib",
+        "@maven//:com_google_truth_truth",
+        "@maven//:junit_junit",
+    ],
+)

build_extensions/jar_creator/javatests/androidx/test/tools/jarcreator/JarCreatorTest.kt

@@ -0,0 +1,45 @@
+/*
+ * Copyright (C) 2023 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package androidx.test.tools.jarcreator
+
+import com.google.common.truth.Truth.assertThat
+import java.io.File
+import java.util.jar.JarFile
+import org.junit.Assert.assertThrows
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.junit.runners.JUnit4
+
+@RunWith(JUnit4::class)
+class JarCreatorTest {
+
+  @Test
+  fun invalidInput() {
+    assertThrows(java.lang.IllegalArgumentException::class.java) { createJar(emptyArray()) }
+  }
+
+  @Test
+  fun combineJars() {
+    val outFile = File.createTempFile("createJarOut", ".jar")
+    val fileToInclude = File.createTempFile("include", ".txt")
+
+    createJar(arrayOf(outFile.absolutePath, fileToInclude.absolutePath))
+
+    val contents = JarFile(outFile.absolutePath).stream().map { it.name }
+    assertThat(contents).containsExactly(fileToInclude.name)
+  }
+}

build_extensions/maven/maven_artifact.bzl

@@ -179,32 +179,6 @@ def _rename_artifact(ctx, tpl_string, src_file, packaging_type, artifact_id, ver
     )
     return artifact
 
-def _override_license_file(ctx, src_file):
-    """Append a LICENSE file into the src if exists"""
-    artifact_with_license = ctx.actions.declare_file("%s-with-LICENSE.%s" % (src_file.basename, src_file.extension))
-    commands = []
-    commands.append("cp %s %s" % (src_file.path, artifact_with_license.path))
-
-    # Append a given LICENSE file to the root directory.
-    commands.append("%s -uf %s -C %s %s" % (
-        ctx.executable._jar.path,
-        artifact_with_license.path,
-        ctx.file.license_file.dirname,
-        ctx.file.license_file.basename,
-    ))
-
-    # Remove the LICENSE files in META_INF.
-    # (Ignore zip error: Nothing to do)
-    commands.append("(zip -dq %s META-INF/LICENSE  META-INF/LICENSE.txt || true)" % (artifact_with_license.path))
-
-    ctx.actions.run_shell(
-        inputs = [src_file, ctx.file.license_file, ctx.executable._jar],
-        outputs = [artifact_with_license],
-        command = "&&".join(commands),
-        tools = [ctx.executable._jar],
-    )
-    return artifact_with_license
-
 def _maven_artifact_impl(ctx):
     """Generates maven repository for a single artifact."""
 
@@ -277,12 +251,6 @@ maven_artifact = rule(
             mandatory = False,
             doc = "Map of maven dependency to a csv list of excluded dependencies. eg {\"com.google.foo:foo\":\"com.google.bar:bar,com.google.bar:bar-none\"}",
         ),
-        "_jar": attr.label(
-            default = Label("@bazel_tools//tools/jdk:jar"),
-            executable = True,
-            allow_files = True,
-            cfg = "exec",
-        ),
         "_maven_artifact_sh": attr.label(
             default = Label("//build_extensions/maven:maven_artifact_sh"),
             executable = True,