Skip to content

Commit dc1b017

Browse files
brettchabotcopybara-androidxtest
authored andcommitted
Replace use of Suppress with Ignore in tests
PiperOrigin-RevId: 677905854
1 parent 00266a9 commit dc1b017

File tree

7 files changed

+16
-16
lines changed

7 files changed

+16
-16
lines changed

espresso/contrib/javatests/androidx/test/espresso/contrib/RecyclerViewIntegrationTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@
4343
import androidx.test.core.app.ActivityScenario;
4444
import androidx.test.core.app.ActivityScenario.ActivityAction;
4545
import androidx.test.espresso.PerformException;
46-
import androidx.test.filters.Suppress;
4746
import androidx.test.ui.app.ItemListAdapter.CustomViewHolder;
4847
import androidx.test.ui.app.R;
4948
import androidx.test.ui.app.RecyclerViewActivity;
5049
import org.hamcrest.Description;
5150
import org.hamcrest.Matcher;
5251
import org.hamcrest.TypeSafeMatcher;
5352
import org.junit.Before;
53+
import org.junit.Ignore;
5454
import org.junit.Test;
5555

5656
public abstract class RecyclerViewIntegrationTest {
@@ -191,7 +191,7 @@ public void testScrolling_scrollToItemAndClick() {
191191
}
192192

193193
// TODO(b/68003948): flaky
194-
@Suppress
194+
@Ignore
195195
@Test
196196
public void testScrolling_scrollToMultipleViewsAndClick() {
197197
onView(withId(rvLayoutId)).perform(scrollTo(hasDescendant(withText(ITEM_16))));
@@ -338,7 +338,7 @@ public void testActionOnItemAtPosition_clickOnLastAndFirstItem() {
338338
}
339339

340340
// TODO(b/68003948): flaky
341-
@Suppress
341+
@Ignore
342342
@Test
343343
public void testActionsOnItem_clickMultipleItems() throws InterruptedException {
344344
onView(withItemText(ITEM_64)).check(doesNotExist());

espresso/core/javatests/androidx/test/espresso/action/AdapterDataIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@
3131
import androidx.test.ext.junit.rules.ActivityScenarioRule;
3232
import androidx.test.ext.junit.runners.AndroidJUnit4;
3333
import androidx.test.filters.LargeTest;
34-
import androidx.test.filters.Suppress;
3534
import androidx.test.ui.app.LongListActivity;
3635
import androidx.test.ui.app.R;
3736
import java.util.Map;
37+
import org.junit.Ignore;
3838
import org.junit.Rule;
3939
import org.junit.Test;
4040
import org.junit.runner.RunWith;
@@ -49,7 +49,7 @@ public class AdapterDataIntegrationTest {
4949
new ActivityScenarioRule<>(LongListActivity.class);
5050

5151
@Test
52-
@Suppress // flaky
52+
@Ignore // flaky
5353
public void clickAroundList() {
5454
onData(allOf(is(instanceOf(Map.class)), hasEntry(is(LongListActivity.STR), is("item: 99"))))
5555
.perform(click());

espresso/core/javatests/androidx/test/espresso/action/EditorActionIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@
3333
import androidx.test.ext.junit.rules.ActivityScenarioRule;
3434
import androidx.test.ext.junit.runners.AndroidJUnit4;
3535
import androidx.test.filters.LargeTest;
36-
import androidx.test.filters.Suppress;
3736
import androidx.test.ui.app.R;
3837
import androidx.test.ui.app.SendActivity;
3938
import org.hamcrest.CustomTypeSafeMatcher;
39+
import org.junit.Ignore;
4040
import org.junit.Rule;
4141
import org.junit.Test;
4242
import org.junit.rules.ExpectedException;
@@ -68,7 +68,7 @@ public void pressImeActionButtonOnSearchBox() {
6868
* Test only passes if run in isolation. Unless Gradle supports a single instrumentation per test
6969
* this test is ignored"
7070
*/
71-
@Suppress
71+
@Ignore
7272
@Test
7373
public void pressImeActionButtonOnNonEditorWidget() {
7474
expectedException.expect(PerformException.class);

espresso/core/javatests/androidx/test/espresso/action/KeyEventActionIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@
4343
import androidx.test.ext.junit.runners.AndroidJUnit4;
4444
import androidx.test.filters.FlakyTest;
4545
import androidx.test.filters.LargeTest;
46-
import androidx.test.filters.Suppress;
4746
import androidx.test.ui.app.MainActivity;
4847
import androidx.test.ui.app.R;
4948
import java.util.Map;
49+
import org.junit.Ignore;
5050
import org.junit.Rule;
5151
import org.junit.Test;
5252
import org.junit.rules.ExpectedException;
@@ -63,7 +63,7 @@ public class KeyEventActionIntegrationTest {
6363
* Test only passes if run in isolation. Unless Gradle supports a single instrumentation per test
6464
* this test is ignored"
6565
*/
66-
@Suppress
66+
@Ignore
6767
@Test
6868
public void clickBackOnRootAction() {
6969
ActivityScenario.launch(MainActivity.class);

espresso/core/javatests/androidx/test/espresso/base/AsyncTaskPoolMonitorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import androidx.test.ext.junit.runners.AndroidJUnit4;
2323
import androidx.test.filters.LargeTest;
24-
import androidx.test.filters.Suppress;
2524
import java.util.concurrent.Callable;
2625
import java.util.concurrent.CountDownLatch;
2726
import java.util.concurrent.Future;
@@ -31,6 +30,7 @@
3130
import java.util.concurrent.TimeUnit;
3231
import java.util.concurrent.atomic.AtomicBoolean;
3332
import org.junit.After;
33+
import org.junit.Ignore;
3434
import org.junit.Test;
3535
import org.junit.runner.RunWith;
3636

@@ -97,7 +97,7 @@ public void run() {
9797
}
9898

9999
// TODO(b/68003948): flaky
100-
@Suppress
100+
@Ignore
101101
@Test
102102
public void idleNotificationAndRestart() throws Exception {
103103

@@ -153,7 +153,7 @@ public void run() {
153153
}
154154

155155
// TODO(b/68003948): flaky
156-
@Suppress
156+
@Ignore
157157
@Test
158158
public void idleNotification_extraWork() throws Exception {
159159
final CountDownLatch firstRunLatch = new CountDownLatch(1);

espresso/core/javatests/androidx/test/espresso/base/UiControllerImplIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
import androidx.test.espresso.base.IdlingResourceRegistry.IdleNotificationCallback;
3737
import androidx.test.ext.junit.runners.AndroidJUnit4;
3838
import androidx.test.filters.LargeTest;
39-
import androidx.test.filters.Suppress;
4039
import androidx.test.platform.tracing.Tracing;
4140
import androidx.test.ui.app.R;
4241
import androidx.test.ui.app.SendActivity;
@@ -45,6 +44,7 @@
4544
import java.util.List;
4645
import javax.inject.Provider;
4746
import org.junit.Before;
47+
import org.junit.Ignore;
4848
import org.junit.Test;
4949
import org.junit.runner.RunWith;
5050

@@ -189,7 +189,7 @@ public void injectMotionEvent() throws InterruptedException, IOException {
189189
}
190190

191191
@Test
192-
@Suppress // flaky, uiController.injectMotionEventSequence can intermittently return false
192+
@Ignore // flaky, uiController.injectMotionEventSequence can intermittently return false
193193
public void injectMotionEventSequence() throws InterruptedException {
194194
try (ActivityScenario<SendActivity> scenario = ActivityScenario.launch(SendActivity.class)) {
195195

testapps/multiprocess_testapp/javatests/androidx/test/multiprocess/app/DefaultProcessActivityTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
import androidx.test.espresso.remote.RemoteEspressoException;
3434
import androidx.test.ext.junit.rules.ActivityScenarioRule;
3535
import androidx.test.ext.junit.runners.AndroidJUnit4;
36-
import androidx.test.filters.Suppress;
36+
import org.junit.Ignore;
3737
import org.junit.Rule;
3838
import org.junit.Test;
3939
import org.junit.runner.RunWith;
@@ -95,7 +95,7 @@ public void verifyAssertingOnDataInRemoteProcessIsSuccessful() {
9595
}
9696

9797
@Test
98-
@Suppress // flaky b/264579367
98+
@Ignore // flaky b/264579367
9999
public void verifySwitchingBetweenTwoProcessesQuicklyWorks() {
100100
Log.d(TAG, "Checking main process name...");
101101
onView(withId(R.id.textNamedProcess)).check(matches(withText(is(DEFAULT_PROC_NAME))));

0 commit comments

Comments
 (0)