Skip to content

Commit 1b28dd6

Browse files
committed
Clarify Boolean parameters by naming them in a typealias
1 parent 5263b76 commit 1b28dd6

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

feature/results/src/main/java/com/android/developers/androidify/customize/CustomizeExportScreen.kt

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ private fun CustomizeExportContents(
211211
},
212212
)
213213
}
214-
val toolSelector = @Composable { modifier: Modifier, horizontal: Boolean ->
214+
val toolSelector: ToolSelectorComposable = @Composable { modifier, horizontal ->
215215
ToolSelector(
216216
tools = state.tools,
217217
selectedOption = state.selectedTool,
@@ -222,7 +222,7 @@ private fun CustomizeExportContents(
222222
},
223223
)
224224
}
225-
val toolDetail = @Composable { modifier: Modifier, singleLine: Boolean ->
225+
val toolDetail: ToolDetailComposable = @Composable { modifier, singleLine ->
226226
SelectedToolDetail(
227227
state,
228228
onSelectedToolStateChanged = { toolState ->
@@ -314,8 +314,8 @@ private fun CustomizeExportLayoutCompact(
314314
paddingValues: PaddingValues,
315315
imageResult: @Composable (ExportImageCanvas.() -> Unit),
316316
state: CustomizeExportState,
317-
toolSelector: @Composable (Modifier, Boolean) -> Unit,
318-
toolDetail: @Composable (Modifier, Boolean) -> Unit,
317+
toolDetail: ToolDetailComposable,
318+
toolSelector: ToolSelectorComposable,
319319
actionButtons: @Composable (Modifier) -> Unit,
320320
) {
321321
Column(
@@ -349,8 +349,8 @@ private fun CustomizeExportLayoutMedium(
349349
paddingValues: PaddingValues,
350350
imageResult: @Composable (ExportImageCanvas.() -> Unit),
351351
state: CustomizeExportState,
352-
toolDetail: @Composable (Modifier, Boolean) -> Unit,
353-
toolSelector: @Composable (Modifier, Boolean) -> Unit,
352+
toolDetail: ToolDetailComposable,
353+
toolSelector: ToolSelectorComposable,
354354
actionButtons: @Composable (Modifier) -> Unit,
355355
) {
356356
Row(
@@ -531,6 +531,9 @@ private fun BotActionsButtonRow(
531531
}
532532
}
533533

534+
typealias ToolSelectorComposable = @Composable (modifier: Modifier, horizontal: Boolean) -> Unit
535+
typealias ToolDetailComposable = @Composable (modifier: Modifier, singleLine: Boolean) -> Unit
536+
534537
@Composable
535538
fun CustomizeExportScreenScaffold(
536539
snackbarHostState: SnackbarHostState,

feature/results/src/main/java/com/android/developers/androidify/customize/xr/CustomizeExportScreenSpatial.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ import androidx.xr.compose.subspace.layout.width
4444
import com.android.developers.androidify.customize.CustomizeExportScreenScaffold
4545
import com.android.developers.androidify.customize.CustomizeExportState
4646
import com.android.developers.androidify.customize.ExportImageCanvas
47+
import com.android.developers.androidify.customize.ToolDetailComposable
48+
import com.android.developers.androidify.customize.ToolSelectorComposable
4749
import com.android.developers.androidify.xr.DisableSharedTransition
4850
import com.android.developers.androidify.xr.MainPanelWorkaround
4951
import com.android.developers.androidify.xr.SquiggleBackgroundSubspace
@@ -53,8 +55,8 @@ fun CustomizeExportLayoutSpatial(
5355
state: CustomizeExportState,
5456
snackbarHostState: SnackbarHostState,
5557
imageResult: @Composable (ExportImageCanvas.() -> Unit),
56-
toolDetail: @Composable (Modifier, Boolean) -> Unit,
57-
toolSelector: @Composable (Modifier, Boolean) -> Unit,
58+
toolDetail: ToolDetailComposable,
59+
toolSelector: ToolSelectorComposable,
5860
actionButtons: @Composable (Modifier) -> Unit,
5961
topBar: @Composable () -> Unit,
6062
) {

0 commit comments

Comments
 (0)