Skip to content

Commit 6bb28c4

Browse files
authored
Merge pull request #36 from ujizin/refactor/add-keep-screen-modifier
refactor: replace KeepScreenOn composable with Modifier.keepScreenOn
2 parents f6b24d7 + 17508e5 commit 6bb28c4

File tree

2 files changed

+3
-16
lines changed
  • core/util/src/main/java/com/android/developers/androidify/util
  • feature/creation/src/main/java/com/android/developers/androidify/creation

2 files changed

+3
-16
lines changed

core/util/src/main/java/com/android/developers/androidify/util/LayoutUtils.kt

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ package com.android.developers.androidify.util
1717

1818
import android.annotation.SuppressLint
1919
import androidx.compose.runtime.Composable
20-
import androidx.compose.runtime.DisposableEffect
2120
import androidx.compose.ui.platform.LocalContext
22-
import androidx.compose.ui.platform.LocalView
2321
import androidx.compose.ui.tooling.preview.PreviewParameterProvider
2422
import androidx.window.WindowSdkExtensions
2523
import androidx.window.core.layout.WindowSizeClass
@@ -122,14 +120,3 @@ class FoldablePreviewParametersProvider : PreviewParameterProvider<FoldablePrevi
122120

123121
)
124122
}
125-
126-
@Composable
127-
fun KeepScreenOn() {
128-
val currentView = LocalView.current
129-
DisposableEffect(Unit) {
130-
currentView.keepScreenOn = true
131-
onDispose {
132-
currentView.keepScreenOn = false
133-
}
134-
}
135-
}

feature/creation/src/main/java/com/android/developers/androidify/creation/LoadingScreen.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ import androidx.compose.ui.graphics.vector.ImageVector
5656
import androidx.compose.ui.graphics.vector.Path
5757
import androidx.compose.ui.graphics.vector.PathParser
5858
import androidx.compose.ui.graphics.vector.rememberVectorPainter
59+
import androidx.compose.ui.keepScreenOn
5960
import androidx.compose.ui.platform.LocalDensity
6061
import androidx.compose.ui.res.stringArrayResource
6162
import androidx.compose.ui.res.stringResource
@@ -72,7 +73,6 @@ import androidx.compose.ui.unit.dp
7273
import com.android.developers.androidify.theme.AndroidifyTheme
7374
import com.android.developers.androidify.theme.components.AndroidifyTopAppBar
7475
import com.android.developers.androidify.theme.components.PrimaryButton
75-
import com.android.developers.androidify.util.KeepScreenOn
7676
import com.android.developers.androidify.util.LargeScreensPreview
7777
import com.android.developers.androidify.util.SmallPhonePreview
7878
import com.android.developers.androidify.util.isAtLeastMedium
@@ -85,7 +85,6 @@ fun LoadingScreen(
8585
onCancelPress: () -> Unit,
8686
isMediumScreen: Boolean = isAtLeastMedium(),
8787
) {
88-
KeepScreenOn()
8988
Scaffold(
9089
topBar = {
9190
AndroidifyTopAppBar(isMediumWindowSize = isMediumScreen, aboutEnabled = false)
@@ -108,7 +107,8 @@ fun LoadingScreen(
108107
},
109108
containerColor = MaterialTheme.colorScheme.secondary,
110109
modifier = Modifier
111-
.fillMaxSize(),
110+
.fillMaxSize()
111+
.keepScreenOn(),
112112
) { contentPadding ->
113113
LoadingScreenContents(contentPadding)
114114
}

0 commit comments

Comments
 (0)