Skip to content

Commit 7aa6120

Browse files
committed
Refactor Scaffold contentPadding back into parameter
1 parent 6ce7486 commit 7aa6120

File tree

2 files changed

+14
-18
lines changed

2 files changed

+14
-18
lines changed

feature/creation/src/main/java/com/android/developers/androidify/creation/LoadingScreen.kt

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import androidx.compose.foundation.layout.Arrangement
2727
import androidx.compose.foundation.layout.Box
2828
import androidx.compose.foundation.layout.BoxScope
2929
import androidx.compose.foundation.layout.Column
30+
import androidx.compose.foundation.layout.PaddingValues
3031
import androidx.compose.foundation.layout.Spacer
3132
import androidx.compose.foundation.layout.fillMaxSize
3233
import androidx.compose.foundation.layout.fillMaxWidth
@@ -97,8 +98,8 @@ fun LoadingScreen(
9798
AndroidifyTopAppBar(isMediumWindowSize = layoutType == EditScreenLayoutType.Medium)
9899
},
99100
onCancelPress = onCancelPress,
100-
) {
101-
LoadingScreenContents()
101+
) { contentPadding ->
102+
LoadingScreenContents(contentPadding)
102103
}
103104
}
104105
}
@@ -108,7 +109,7 @@ fun LoadingScreenScaffold(
108109
topBar: @Composable () -> Unit,
109110
onCancelPress: () -> Unit,
110111
containerColor: Color = MaterialTheme.colorScheme.secondary,
111-
content: @Composable () -> Unit,
112+
content: @Composable (PaddingValues) -> Unit,
112113
) {
113114
Scaffold(
114115
topBar = topBar,
@@ -132,21 +133,16 @@ fun LoadingScreenScaffold(
132133
modifier = Modifier
133134
.fillMaxSize()
134135
.keepScreenOn(),
135-
) { contentPadding ->
136-
Box(
137-
modifier = Modifier
138-
.fillMaxSize()
139-
.padding(contentPadding),
140-
) {
141-
content()
142-
}
143-
}
136+
content = content,
137+
)
144138
}
145139

146140
@Composable
147-
fun LoadingScreenContents() {
141+
fun LoadingScreenContents(contentPadding: PaddingValues) {
148142
Column(
149-
modifier = Modifier.fillMaxSize(),
143+
modifier = Modifier
144+
.fillMaxSize()
145+
.padding(contentPadding),
150146
horizontalAlignment = Alignment.CenterHorizontally,
151147
verticalArrangement = Arrangement.Center,
152148
) {

feature/creation/src/main/java/com/android/developers/androidify/creation/xr/LoadingScreenSpatial.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ fun LoadingScreenSpatial(
8383
topBar = {},
8484
onCancelPress = onCancelPress,
8585
containerColor = Color.Transparent,
86-
) {
87-
LoadingScreenContents()
86+
) { contentPadding ->
87+
LoadingScreenContents(contentPadding)
8888
}
8989
}
9090
}
@@ -106,8 +106,8 @@ private fun LoadingScreenSpatialPreview() {
106106
topBar = {},
107107
onCancelPress = { },
108108
containerColor = Color.Transparent,
109-
) {
110-
LoadingScreenContents()
109+
) { contentPadding ->
110+
LoadingScreenContents(contentPadding)
111111
}
112112
}
113113
}

0 commit comments

Comments
 (0)