Merge pull request #96 from android/yaraki/lint

Fix all lint errors

Author: yaraki

ActivitySceneTransitionBasic/build.gradle

@@ -21,7 +21,7 @@ buildscript {
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.2.1'
+        classpath 'com.android.tools.build:gradle:7.3.0'
     }
 }
 

ActivitySceneTransitionBasic/gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-all.zip

BasicTransition/Application/src/main/java/com/example/android/common/logger/LogView.java

@@ -17,12 +17,14 @@
 
 import android.app.Activity;
 import android.content.Context;
-import android.util.*;
-import android.widget.TextView;
+import android.util.AttributeSet;
 
-/** Simple TextView which is used to output log data received through the LogNode interface.
-*/
-public class LogView extends TextView implements LogNode {
+import androidx.appcompat.widget.AppCompatTextView;
+
+/**
+ * Simple TextView which is used to output log data received through the LogNode interface.
+ */
+public class LogView extends AppCompatTextView implements LogNode {
 
     public LogView(Context context) {
         super(context);
@@ -38,20 +40,21 @@ public LogView(Context context, AttributeSet attrs, int defStyle) {
 
     /**
      * Formats the log data and prints it out to the LogView.
+     *
      * @param priority Log level of the data being logged.  Verbose, Error, etc.
-     * @param tag Tag for for the log data.  Can be used to organize log statements.
-     * @param msg The actual message to be logged. The actual message to be logged.
-     * @param tr If an exception was thrown, this can be sent along for the logging facilities
-     *           to extract and print useful information.
+     * @param tag      Tag for for the log data.  Can be used to organize log statements.
+     * @param msg      The actual message to be logged. The actual message to be logged.
+     * @param tr       If an exception was thrown, this can be sent along for the logging facilities
+     *                 to extract and print useful information.
      */
     @Override
     public void println(int priority, String tag, String msg, Throwable tr) {
 
-        
+
         String priorityStr = null;
 
         // For the purposes of this View, we want to print the priority as readable text.
-        switch(priority) {
+        switch (priority) {
             case android.util.Log.VERBOSE:
                 priorityStr = "VERBOSE";
                 break;
@@ -92,7 +95,7 @@ public void println(int priority, String tag, String msg, Throwable tr) {
 
         // In case this was originally called from an AsyncTask or some other off-UI thread,
         // make sure the update occurs within the UI thread.
-        ((Activity) getContext()).runOnUiThread( (new Thread(new Runnable() {
+        ((Activity) getContext()).runOnUiThread((new Thread(new Runnable() {
             @Override
             public void run() {
                 // Display the text we just generated within the LogView.
@@ -113,11 +116,13 @@ public void setNext(LogNode node) {
         mNext = node;
     }
 
-    /** Takes a string and adds to it, with a separator, if the bit to be added isn't null. Since
+    /**
+     * Takes a string and adds to it, with a separator, if the bit to be added isn't null. Since
      * the logger takes so many arguments that might be null, this method helps cut out some of the
      * agonizing tedium of writing the same 3 lines over and over.
-     * @param source StringBuilder containing the text to append to.
-     * @param addStr The String to append
+     *
+     * @param source    StringBuilder containing the text to append to.
+     * @param addStr    The String to append
      * @param delimiter The String to separate the source and appended strings. A tab or comma,
      *                  for instance.
      * @return The fully concatenated String as a StringBuilder
@@ -136,7 +141,9 @@ private StringBuilder appendIfNotNull(StringBuilder source, String addStr, Strin
     // The next LogNode in the chain.
     LogNode mNext;
 
-    /** Outputs the string as a new line of log data in the LogView. */
+    /**
+     * Outputs the string as a new line of log data in the LogView.
+     */
     public void appendToLog(String s) {
         append("\n" + s);
     }

BasicTransition/build.gradle

@@ -21,7 +21,7 @@ buildscript {
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.2.1'
+        classpath 'com.android.tools.build:gradle:7.3.0'
     }
 }
 

BasicTransition/gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-all.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

CustomTransition/Application/src/main/java/com/example/android/common/logger/LogView.java

@@ -17,12 +17,14 @@
 
 import android.app.Activity;
 import android.content.Context;
-import android.util.*;
-import android.widget.TextView;
+import android.util.AttributeSet;
 
-/** Simple TextView which is used to output log data received through the LogNode interface.
-*/
-public class LogView extends TextView implements LogNode {
+import androidx.appcompat.widget.AppCompatTextView;
+
+/**
+ * Simple TextView which is used to output log data received through the LogNode interface.
+ */
+public class LogView extends AppCompatTextView implements LogNode {
 
     public LogView(Context context) {
         super(context);
@@ -38,20 +40,21 @@ public LogView(Context context, AttributeSet attrs, int defStyle) {
 
     /**
      * Formats the log data and prints it out to the LogView.
+     *
      * @param priority Log level of the data being logged.  Verbose, Error, etc.
-     * @param tag Tag for for the log data.  Can be used to organize log statements.
-     * @param msg The actual message to be logged. The actual message to be logged.
-     * @param tr If an exception was thrown, this can be sent along for the logging facilities
-     *           to extract and print useful information.
+     * @param tag      Tag for for the log data.  Can be used to organize log statements.
+     * @param msg      The actual message to be logged. The actual message to be logged.
+     * @param tr       If an exception was thrown, this can be sent along for the logging facilities
+     *                 to extract and print useful information.
      */
     @Override
     public void println(int priority, String tag, String msg, Throwable tr) {
 
-        
+
         String priorityStr = null;
 
         // For the purposes of this View, we want to print the priority as readable text.
-        switch(priority) {
+        switch (priority) {
             case android.util.Log.VERBOSE:
                 priorityStr = "VERBOSE";
                 break;
@@ -92,7 +95,7 @@ public void println(int priority, String tag, String msg, Throwable tr) {
 
         // In case this was originally called from an AsyncTask or some other off-UI thread,
         // make sure the update occurs within the UI thread.
-        ((Activity) getContext()).runOnUiThread( (new Thread(new Runnable() {
+        ((Activity) getContext()).runOnUiThread((new Thread(new Runnable() {
             @Override
             public void run() {
                 // Display the text we just generated within the LogView.
@@ -113,11 +116,13 @@ public void setNext(LogNode node) {
         mNext = node;
     }
 
-    /** Takes a string and adds to it, with a separator, if the bit to be added isn't null. Since
+    /**
+     * Takes a string and adds to it, with a separator, if the bit to be added isn't null. Since
      * the logger takes so many arguments that might be null, this method helps cut out some of the
      * agonizing tedium of writing the same 3 lines over and over.
-     * @param source StringBuilder containing the text to append to.
-     * @param addStr The String to append
+     *
+     * @param source    StringBuilder containing the text to append to.
+     * @param addStr    The String to append
      * @param delimiter The String to separate the source and appended strings. A tab or comma,
      *                  for instance.
      * @return The fully concatenated String as a StringBuilder
@@ -136,7 +141,9 @@ private StringBuilder appendIfNotNull(StringBuilder source, String addStr, Strin
     // The next LogNode in the chain.
     LogNode mNext;
 
-    /** Outputs the string as a new line of log data in the LogView. */
+    /**
+     * Outputs the string as a new line of log data in the LogView.
+     */
     public void appendToLog(String s) {
         append("\n" + s);
     }

CustomTransition/build.gradle

@@ -21,7 +21,7 @@ buildscript {
     }
 
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.2.1'
+        classpath 'com.android.tools.build:gradle:7.3.0'
     }
 }
 

CustomTransition/gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-all.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

DrawableAnimations/app/src/main/res/drawable/ic_hourglass_animated.xml

@@ -16,7 +16,9 @@
 -->
 <animated-vector
     xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:aapt="http://schemas.android.com/aapt">
+    xmlns:aapt="http://schemas.android.com/aapt"
+    xmlns:tools="http://schemas.android.com/tools"
+    tools:targetApi="21">
 
     <aapt:attr name="android:drawable">
         <vector

DrawableAnimations/build.gradle

@@ -21,7 +21,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.2.1'
+        classpath 'com.android.tools.build:gradle:7.3.0'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
     }
 }