Skip to content

Commit dd26bd6

Browse files
committed
Fixes race condition in ServiceLocator and moves UI tests to mock flavor
Change-Id: I2205de59af14f2612cbfcc5ab76627aac7d43de4
1 parent 6917a14 commit dd26bd6

File tree

5 files changed

+6
-2
lines changed

5 files changed

+6
-2
lines changed

app/src/mock/java/com/example/android/architecture/blueprints/todoapp/ServiceLocator.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ object ServiceLocator {
4545
}
4646

4747
private fun createTasksRepository(context: Context): TasksRepository {
48-
return DefaultTasksRepository(FakeTasksRemoteDataSource, createTaskLocalDataSource(context))
48+
val newRepo = DefaultTasksRepository(FakeTasksRemoteDataSource, createTaskLocalDataSource(context))
49+
tasksRepository = newRepo
50+
return newRepo
4951
}
5052

5153
private fun createTaskLocalDataSource(context: Context): TasksDataSource {

app/src/prod/java/com/example/android/architecture/blueprints/todoapp/ServiceLocator.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ object ServiceLocator {
4646
}
4747

4848
private fun createTasksRepository(context: Context): TasksRepository {
49-
return DefaultTasksRepository(TasksRemoteDataSource, createTaskLocalDataSource(context))
49+
val newRepo = DefaultTasksRepository(TasksRemoteDataSource, createTaskLocalDataSource(context))
50+
tasksRepository = newRepo
51+
return newRepo
5052
}
5153

5254
private fun createTaskLocalDataSource(context: Context): TasksDataSource {

0 commit comments

Comments
 (0)