File tree Expand file tree Collapse file tree 4 files changed +19
-10
lines changed Expand file tree Collapse file tree 4 files changed +19
-10
lines changed Original file line number Diff line number Diff line change 17
17
<FrameLayout
18
18
xmlns : android =" http://schemas.android.com/apk/res/android"
19
19
android : layout_width =" match_parent"
20
- android : layout_height =" 192dp "
20
+ android : layout_height =" @dimen/header_height "
21
21
android : background =" ?attr/colorPrimaryDark"
22
22
android : gravity =" bottom"
23
23
android : orientation =" vertical"
24
- android : padding =" 16dp "
24
+ android : padding =" @dimen/header_padding "
25
25
android : theme =" @style/ThemeOverlay.AppCompat.Dark" >
26
26
27
27
<ImageView
28
- android : layout_width =" 100dp "
28
+ android : layout_width =" @dimen/header_image_width "
29
29
android : layout_height =" wrap_content"
30
30
android : layout_gravity =" center"
31
- android : src =" @drawable/logo_no_fill" />
31
+ android : src =" @drawable/logo_no_fill"
32
+ android : contentDescription =" @string/tasks_header_image_content_description" />
32
33
33
34
<TextView
34
35
android : layout_width =" wrap_content"
Original file line number Diff line number Diff line change 89
89
android : layout_width =" 96dp"
90
90
android : layout_height =" 96dp"
91
91
android : layout_gravity =" center"
92
- android : src =" @{ContextCompat.getDrawable(context, viewmodel.noTaskIconRes)}" />
92
+ android : src =" @{ContextCompat.getDrawable(context, viewmodel.noTaskIconRes)}"
93
+ android : contentDescription =" @string/no_tasks_image_content_description" />
93
94
94
95
<TextView
95
96
android : id =" @+id/no_tasks_text"
Original file line number Diff line number Diff line change 19
19
<dimen name =" activity_horizontal_margin" >16dp</dimen >
20
20
<dimen name =" activity_vertical_margin" >16dp</dimen >
21
21
22
- <dimen name =" list_item_padding" >8dp</dimen >
23
-
24
22
<dimen name =" fab_margin" >16dp</dimen >
25
23
24
+ <dimen name =" list_item_padding" >8dp</dimen >
25
+ <dimen name =" header_height" >192dp</dimen >
26
+ <dimen name =" header_padding" >16dp</dimen >
27
+ <dimen name =" header_image_width" >100dp</dimen >
28
+
26
29
</resources >
Original file line number Diff line number Diff line change 15
15
-->
16
16
17
17
<resources >
18
- <string name =" app_name" >Todo </string >
18
+ <string name =" app_name" >Tasks </string >
19
19
<string name =" add_task" >New Task</string >
20
20
<string name =" edit_task" >Edit Task</string >
21
21
<string name =" task_marked_complete" >Task marked complete</string >
25
25
<string name =" menu_filter" >Filter</string >
26
26
<string name =" menu_clear" >Clear completed</string >
27
27
<string name =" menu_delete_task" >Delete task</string >
28
- <string name =" navigation_view_header_title" >Todo </string >
28
+ <string name =" navigation_view_header_title" >Tasks </string >
29
29
<string name =" title_hint" >Title</string >
30
30
<string name =" description_hint" >Enter your task here.</string >
31
- <string name =" empty_task_message" >TO DOs cannot be empty</string >
31
+ <string name =" empty_task_message" >Tasks cannot be empty</string >
32
32
<string name =" successfully_saved_task_message" >Task saved</string >
33
33
<string name =" list_title" >Task List</string >
34
34
<string name =" statistics_title" >Statistics</string >
58
58
<string name =" successfully_added_task_message" >Task added</string >
59
59
<string name =" no_data_description" />
60
60
61
+ <!-- Content Descriptions -->
62
+ <string name =" tasks_header_image_content_description" >Tasks header image</string >
63
+ <string name =" no_tasks_image_content_description" >No tasks image</string >
64
+
61
65
</resources >
You can’t perform that action at this time.
0 commit comments