Skip to content

Commit 295ccb8

Browse files
authored
Merge pull request #131 from android/update-gradle-build
Update gradle so Credential Manager sample builds successfully
2 parents 28af0a8 + 0f765bf commit 295ccb8

File tree

7 files changed

+310
-133
lines changed

7 files changed

+310
-133
lines changed
Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
# Workflow name
2+
name: Build CredentialManager Sample
3+
4+
on:
5+
workflow_dispatch:
6+
push:
7+
branches: [ main ]
8+
pull_request:
9+
branches: [ main ]
10+
11+
jobs:
12+
build:
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: actions/checkout@v3
16+
17+
- name: Set Up JDK
18+
uses: actions/setup-java@v3
19+
with:
20+
distribution: 'zulu'
21+
java-version: '17'
22+
cache: 'gradle'
23+
24+
- name: Setup Gradle
25+
uses: gradle/actions/setup-gradle@v4
26+
27+
- name: Install Android SDK Platform VanillaIceCream
28+
run: |
29+
echo "y" | $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager --licenses > /dev/null
30+
echo "y" | $ANDROID_SDK_ROOT/cmdline-tools/latest/bin/sdkmanager "platforms;android-35"
31+
32+
# The sample includes a keystore.properties.template.
33+
# For a CI build, we might need to provide a dummy or generated keystore.
34+
# For now, let's assume the build works without a specific signing config for debug.
35+
# If it requires specific signing for debug, this might fail or need adjustment.
36+
- name: Create dummy keystore.properties if not exists
37+
run: |
38+
if [ ! -f CredentialManager/keystore.properties ]; then
39+
echo "Creating dummy keystore.properties for CI build"
40+
echo "storeFile=debug.keystore" > CredentialManager/keystore.properties
41+
echo "storePassword=android" >> CredentialManager/keystore.properties
42+
echo "keyAlias=androiddebugkey" >> CredentialManager/keystore.properties
43+
echo "keyPassword=android" >> CredentialManager/keystore.properties
44+
fi
45+
# Ensure a debug.keystore exists if not provided by checkout
46+
if [ ! -f CredentialManager/debug.keystore ]; then
47+
echo "Generating dummy debug.keystore for CI build"
48+
keytool -genkey -v -keystore CredentialManager/debug.keystore -storepass android -alias androiddebugkey -keypass android -keyalg RSA -keysize 2048 -validity 10000 -dname "CN=Android Debug,O=Android,C=US"
49+
fi
50+
working-directory: . # Run from checkout root so CredentialManager/ path is correct
51+
52+
- name: Make gradlew executable
53+
run: chmod +x ./gradlew
54+
working-directory: ./CredentialManager
55+
56+
- name: Build CredentialManager app
57+
working-directory: ./CredentialManager
58+
run: ./gradlew app:assembleDebug
Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
# Workflow name
2+
name: Build WebkitWebView Sample
3+
4+
on:
5+
workflow_dispatch:
6+
push:
7+
branches: [ main ]
8+
pull_request:
9+
branches: [ main ]
10+
11+
jobs:
12+
build:
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: actions/checkout@v3
16+
17+
- name: Set Up JDK
18+
uses: actions/setup-java@v3
19+
with:
20+
distribution: 'zulu'
21+
java-version: '17'
22+
cache: 'gradle'
23+
24+
- name: Setup Gradle
25+
uses: gradle/actions/setup-gradle@v4
26+
27+
- name: Create dummy keystore.properties if not exists
28+
run: |
29+
if [ ! -f WebView/WebkitWebView/keystore.properties ]; then
30+
echo "Creating dummy keystore.properties for CI build"
31+
echo "storeFile=debug.keystore" > WebView/WebkitWebView/keystore.properties
32+
echo "storePassword=android" >> WebView/WebkitWebView/keystore.properties
33+
echo "keyAlias=androiddebugkey" >> WebView/WebkitWebView/keystore.properties
34+
echo "keyPassword=android" >> WebView/WebkitWebView/keystore.properties
35+
fi
36+
if [ ! -f WebView/WebkitWebView/debug.keystore ]; then
37+
echo "Generating dummy debug.keystore for CI build"
38+
keytool -genkey -v -keystore WebView/WebkitWebView/debug.keystore -storepass android -alias androiddebugkey -keypass android -keyalg RSA -keysize 2048 -validity 10000 -dname "CN=Android Debug,O=Android,C=US"
39+
fi
40+
working-directory: . # Run from checkout root
41+
42+
- name: Make gradlew executable
43+
run: chmod +x ./gradlew
44+
working-directory: ./WebView/WebkitWebView
45+
46+
- name: Build WebkitWebView app
47+
working-directory: ./WebView/WebkitWebView
48+
run: ./gradlew app:assembleDebug

CredentialManager/app/build.gradle

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,10 @@ keystoreProperties.load(new FileInputStream(keystorePropertiesFile))
3131

3232
android {
3333
namespace 'com.google.credentialmanager.sample'
34-
compileSdk 34
35-
compileSdkPreview "VanillaIceCream"
34+
compileSdk 35
3635
defaultConfig {
3736
applicationId "com.google.credentialmanager.sample"
3837
minSdk 21
39-
targetSdkPreview "VanillaIceCream"
4038
versionCode 1
4139
versionName "1.0"
4240

@@ -101,8 +99,8 @@ dependencies {
10199
androidTestImplementation 'androidx.test.ext:junit:1.1.5'
102100
androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'
103101

104-
implementation 'androidx.credentials:credentials-play-services-auth:1.5.0-alpha02'
105-
implementation 'androidx.credentials:credentials:1.5.0-alpha02'
102+
implementation 'androidx.credentials:credentials-play-services-auth:1.5.0'
103+
implementation 'androidx.credentials:credentials:1.5.0'
106104

107105
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3"
108106
implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3"
-15.3 KB
Binary file not shown.
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
#Wed Dec 28 18:22:13 IST 2022
21
distributionBase=GRADLE_USER_HOME
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1-bin.zip
42
distributionPath=wrapper/dists
5-
zipStorePath=wrapper/dists
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip
4+
networkTimeout=10000
5+
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME
7+
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)