Added suggested optimizations

Author: cy245

Shrine/app/src/main/java/com/authentication/shrine/repository/AuthRepository.kt

@@ -442,11 +442,15 @@ class AuthRepository @Inject constructor(
     suspend fun isSessionIdValid(): Boolean {
         val sessionId = dataStore.read(SESSION_ID)
         if (!sessionId.isNullOrBlank()) {
-            val apiResult = authApiService.getKeys(
-                cookie = sessionId.createCookieHeader(),
-            )
-            if (apiResult.isSuccessful) {
-                return true
+            try {
+                val apiResult = authApiService.getKeys(
+                    cookie = sessionId.createCookieHeader(),
+                )
+                if (apiResult.isSuccessful) {
+                    return true
+                }
+            } catch (e: ApiException) {
+                Log.e(TAG, "Cannot call getKeys for isSessionIdValid")
             }
         }
 

Shrine/app/src/main/java/com/authentication/shrine/ui/viewmodel/SplashViewModel.kt

@@ -43,7 +43,7 @@ class SplashViewModel @Inject constructor(
     init {
         viewModelScope.launch {
             val startDestination =
-                if (isSessionIdValid() && (isSignedInThroughPassword() || isSignedInThroughPasskeys())) {
+                if (isSessionIdValid()) {
                     ShrineAppDestinations.MainMenuRoute.name
                 } else {
                     signOut()
@@ -59,30 +59,6 @@ class SplashViewModel @Inject constructor(
         }
     }
 
-    /**
-     * Checks if the user is signed in using a password.
-     *
-     * This method checks if the user is signed in by calling the `isSignedIn()` method of the
-     * [AuthRepository].
-     *
-     * @return True if the user is signed in using a password, false otherwise.
-     */
-    private suspend fun isSignedInThroughPassword(): Boolean {
-        return repository.isSignedInThroughPassword()
-    }
-
-    /**
-     * Checks if the user is signed in using passkeys.
-     *
-     * This method checks if the user is signed in through passkeys by calling the
-     * `isSignedInThroughPasskeys()` method of the [AuthRepository].
-     *
-     * @return True if the user is signed in using passkeys, false otherwise.
-     */
-    private suspend fun isSignedInThroughPasskeys(): Boolean {
-        return repository.isSignedInThroughPasskeys()
-    }
-
     /**
      * Checks if the session ID is valid with the server.
      *
@@ -95,7 +71,7 @@ class SplashViewModel @Inject constructor(
     /**
      * Signs out the user.
      */
-    fun signOut() {
+    private fun signOut() {
         viewModelScope.launch {
             repository.signOut()
         }