Skip to content

Changing from decorator to manual shared elements in TwoPaneScene #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changing from decorator to manual shared elements in TwoPaneScene #88

wants to merge 1 commit into from

Conversation

dturner
Copy link
Collaborator

@dturner dturner commented Oct 2, 2025

No description provided.

@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Summary of Changes

Hello @dturner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the implementation of shared element transitions in the TwoPaneScene example by shifting from a decorator-based approach to directly applying shared element modifiers to individual navigation entry content. This change enhances control over transition behavior and improves code clarity by explicitly defining shared elements where they are needed. Additionally, a utility function has been extracted to improve code organization.

Highlights

  • Shared Element Transition Refactoring: The mechanism for handling shared element transitions within the TwoPaneScene has been refactored to provide more granular control.
  • Removal of NavEntryDecorator: The generic navEntryDecorator that previously wrapped navigation entries for shared elements has been removed.
  • Direct Shared Element Application: Shared element modifiers are now applied directly to the content of individual navigation entries (Home, Product, Profile) within the entryProvider.
  • Code Structure Improvement: The addProductRoute helper function has been refactored from a member function of TwoPaneActivity to a top-level extension function for NavBackStack<NavKey>.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the implementation of shared element transitions in TwoPaneActivity by moving away from a generic navEntryDecorator to applying the sharedElement modifier manually within each navigation entry. While this change removes a layer of abstraction, it introduces some code repetition. My review includes suggestions to improve the new implementation by removing an unused lambda parameter and extracting the duplicated logic into a helper function for better maintainability.

Base automatically changed from dt/alpha10 to main October 3, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbw0033 jbw0033 Awaiting requested review from jbw0033 jbw0033 is a code owner

@claraf3 claraf3 Awaiting requested review from claraf3 claraf3 is a code owner

@ianhanniballake ianhanniballake Awaiting requested review from ianhanniballake ianhanniballake is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dturner