Skip to content

Commit 02bf1ac

Browse files
Merge pull request #725 from tsumuchan/main
Clarify dependencies of the included build-logic
2 parents e4d539e + e1025d8 commit 02bf1ac

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

build-logic/convention/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ tasks.withType<KotlinCompile>().configureEach {
3636

3737
dependencies {
3838
compileOnly(libs.android.gradlePlugin)
39-
compileOnly(libs.firebase.crashlytics.gradle)
40-
compileOnly(libs.firebase.performance.gradle)
39+
compileOnly(libs.firebase.crashlytics.gradlePlugin)
40+
compileOnly(libs.firebase.performance.gradlePlugin)
4141
compileOnly(libs.kotlin.gradlePlugin)
4242
compileOnly(libs.ksp.gradlePlugin)
4343
}

gradle/libs.versions.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,7 @@ firebase-bom = { group = "com.google.firebase", name = "firebase-bom", version.r
103103
firebase-analytics = { group = "com.google.firebase", name = "firebase-analytics-ktx" }
104104
firebase-cloud-messaging = { group = "com.google.firebase", name = "firebase-messaging-ktx" }
105105
firebase-crashlytics = { group = "com.google.firebase", name = "firebase-crashlytics-ktx" }
106-
firebase-crashlytics-gradle = { group = "com.google.firebase", name = "firebase-crashlytics-gradle", version.ref = "firebaseCrashlyticsPlugin" }
107106
firebase-performance = { group = "com.google.firebase", name = "firebase-perf-ktx" }
108-
firebase-performance-gradle = { group = "com.google.firebase", name = "perf-plugin", version.ref = "firebasePerfPlugin" }
109107
hilt-android = { group = "com.google.dagger", name = "hilt-android", version.ref = "hilt" }
110108
hilt-android-testing = { group = "com.google.dagger", name = "hilt-android-testing", version.ref = "hilt" }
111109
hilt-compiler = { group = "com.google.dagger", name = "hilt-android-compiler", version.ref = "hilt" }
@@ -130,6 +128,8 @@ turbine = { group = "app.cash.turbine", name = "turbine", version.ref = "turbine
130128

131129
# Dependencies of the included build-logic
132130
android-gradlePlugin = { group = "com.android.tools.build", name = "gradle", version.ref = "androidGradlePlugin" }
131+
firebase-crashlytics-gradlePlugin = { group = "com.google.firebase", name = "firebase-crashlytics-gradle", version.ref = "firebaseCrashlyticsPlugin" }
132+
firebase-performance-gradlePlugin = { group = "com.google.firebase", name = "perf-plugin", version.ref = "firebasePerfPlugin" }
133133
kotlin-gradlePlugin = { group = "org.jetbrains.kotlin", name = "kotlin-gradle-plugin", version.ref = "kotlin" }
134134
ksp-gradlePlugin = { group = "com.google.devtools.ksp", name = "com.google.devtools.ksp.gradle.plugin", version.ref = "ksp" }
135135

0 commit comments

Comments
 (0)