Skip to content

Commit 0844d02

Browse files
authored
Merge pull request #603 from amalhanaja/redundant-managed-device
Remove redundant code block for managed virtual device creation
2 parents c677db2 + bcd4a6d commit 0844d02

File tree

2 files changed

+1
-29
lines changed

2 files changed

+1
-29
lines changed

app/build.gradle.kts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
* limitations under the License.
1515
*/
1616
import com.google.samples.apps.nowinandroid.NiaBuildType
17-
import com.android.build.api.dsl.ManagedVirtualDevice
1817

1918
plugins {
2019
id("nowinandroid.android.application")
@@ -75,17 +74,6 @@ android {
7574
unitTests {
7675
isIncludeAndroidResources = true
7776
}
78-
// TODO: Convert it as a convention plugin once Flamingo goes out (https://github.com/android/nowinandroid/issues/523)
79-
managedDevices {
80-
devices {
81-
maybeCreate<ManagedVirtualDevice>("pixel4api30").apply {
82-
device = "Pixel 4"
83-
apiLevel = 30
84-
// ATDs currently support only API level 30.
85-
systemImageSource = "aosp-atd"
86-
}
87-
}
88-
}
8977
}
9078
namespace = "com.google.samples.apps.nowinandroid"
9179
}

core/database/build.gradle.kts

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
* limitations under the License.
1515
*/
1616

17-
import com.android.build.api.dsl.ManagedVirtualDevice
18-
1917
// TODO: Remove once https://youtrack.jetbrains.com/issue/KTIJ-19369 is fixed
2018
@Suppress("DSL_SCOPE_VIOLATION")
2119
plugins {
@@ -31,20 +29,6 @@ android {
3129
"com.google.samples.apps.nowinandroid.core.testing.NiaTestRunner"
3230
}
3331
namespace = "com.google.samples.apps.nowinandroid.core.database"
34-
35-
testOptions {
36-
// TODO: Convert it as a convention plugin once Flamingo goes out (https://github.com/android/nowinandroid/issues/523)
37-
managedDevices {
38-
devices {
39-
maybeCreate<ManagedVirtualDevice>("pixel4api30").apply {
40-
device = "Pixel 4"
41-
apiLevel = 30
42-
// ATDs currently support only API level 30.
43-
systemImageSource = "aosp-atd"
44-
}
45-
}
46-
}
47-
}
4832
}
4933

5034
dependencies {
@@ -54,4 +38,4 @@ dependencies {
5438
implementation(libs.kotlinx.datetime)
5539

5640
androidTestImplementation(project(":core:testing"))
57-
}
41+
}

0 commit comments

Comments
 (0)