Merge pull request #600 from takagimeow/cleanup-unused-args

mmoczkowski · web-flow · commit 2b2f6d48ce06 · 2023-04-13T15:49:35.000+02:00
Remove newsResourceTitle from AnalyticsHelper.logNewsResourceOpened method
diff --git a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/AnalyticsExtensions.kt
@@ -39,7 +39,7 @@ fun AnalyticsHelper.logScreenView(screenName: String) {
     )
 }
 
-fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String, newsResourceTitle: String) {
+fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String) {
     logEvent(
         event = AnalyticsEvent(
             type = "news_resource_opened",
diff --git a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt
@@ -69,7 +69,6 @@ fun LazyGridScope.newsFeed(
                     onClick = {
                         analyticsHelper.logNewsResourceOpened(
                             newsResourceId = userNewsResource.id,
-                            newsResourceTitle = userNewsResource.title,
                         )
                         launchCustomChromeTab(context, resourceUrl, backgroundColor)
                     },
diff --git a/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt b/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt
@@ -56,7 +56,6 @@ fun LazyListScope.userNewsResourceCardItems(
             onClick = {
                 analyticsHelper.logNewsResourceOpened(
                     newsResourceId = userNewsResource.id,
-                    newsResourceTitle = userNewsResource.title,
                 )
                 when (onItemClick) {
                     null -> launchCustomChromeTab(context, resourceUrl, backgroundColor)

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ fun AnalyticsHelper.logScreenView(screenName: String) {`
`39`	`39`	`)`
`40`	`40`	`}`
`41`	`41`
`42`		`-fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String, newsResourceTitle: String) {`
	`42`	`+fun AnalyticsHelper.logNewsResourceOpened(newsResourceId: String) {`
`43`	`43`	`logEvent(`
`44`	`44`	`event = AnalyticsEvent(`
`45`	`45`	`type = "news_resource_opened",`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,6 @@ fun LazyGridScope.newsFeed(`
`69`	`69`	`onClick = {`
`70`	`70`	`analyticsHelper.logNewsResourceOpened(`
`71`	`71`	`newsResourceId = userNewsResource.id,`
`72`		`- newsResourceTitle = userNewsResource.title,`
`73`	`72`	`)`
`74`	`73`	`launchCustomChromeTab(context, resourceUrl, backgroundColor)`
`75`	`74`	`},`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,6 @@ fun LazyListScope.userNewsResourceCardItems(`
`56`	`56`	`onClick = {`
`57`	`57`	`analyticsHelper.logNewsResourceOpened(`
`58`	`58`	`newsResourceId = userNewsResource.id,`
`59`		`- newsResourceTitle = userNewsResource.title,`
`60`	`59`	`)`
`61`	`60`	`when (onItemClick) {`
`62`	`61`	`null -> launchCustomChromeTab(context, resourceUrl, backgroundColor)`