Spacing polish based on design spec

Author: c5inco

core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsFeed.kt

@@ -21,6 +21,7 @@ import android.net.Uri
 import androidx.annotation.ColorInt
 import androidx.browser.customtabs.CustomTabColorSchemeParams
 import androidx.browser.customtabs.CustomTabsIntent
+import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.lazy.LazyListScope
 import androidx.compose.foundation.lazy.grid.GridCells
 import androidx.compose.foundation.lazy.grid.LazyGridScope
@@ -31,6 +32,7 @@ import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
+import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.toArgb
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.tooling.preview.Devices
@@ -67,7 +69,8 @@ fun LazyGridScope.newsFeed(
                             saveableNewsResource.newsResource.id,
                             !saveableNewsResource.isSaved
                         )
-                    }
+                    },
+                    modifier = Modifier.padding(horizontal = 8.dp)
                 )
             }
         }

feature/bookmarks/src/main/java/com/google/samples/apps/nowinandroid/feature/bookmarks/BookmarksScreen.kt

@@ -149,7 +149,7 @@ private fun EmptyState(modifier: Modifier = Modifier) {
             contentDescription = null
         )
 
-        Spacer(modifier = Modifier.height(16.dp))
+        Spacer(modifier = Modifier.height(48.dp))
 
         Text(
             text = stringResource(id = R.string.bookmarks_empty_error),

feature/foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt

@@ -38,6 +38,7 @@ import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.safeDrawing
 import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.layout.width
+import androidx.compose.foundation.layout.widthIn
 import androidx.compose.foundation.layout.windowInsetsBottomHeight
 import androidx.compose.foundation.lazy.LazyListScope
 import androidx.compose.foundation.lazy.grid.GridCells
@@ -243,14 +244,13 @@ private fun LazyGridScope.onboarding(
                         text = stringResource(R.string.onboarding_guidance_subtitle),
                         modifier = Modifier
                             .fillMaxWidth()
-                            .padding(top = 8.dp, start = 16.dp, end = 16.dp),
+                            .padding(top = 8.dp, start = 24.dp, end = 24.dp),
                         textAlign = TextAlign.Center,
                         style = MaterialTheme.typography.bodyMedium
                     )
                     TopicSelection(
                         onboardingUiState,
                         onTopicCheckedChanged,
-                        Modifier.padding(bottom = 8.dp)
                     )
                     // Done button
                     Row(
@@ -261,8 +261,9 @@ private fun LazyGridScope.onboarding(
                             onClick = saveFollowedTopics,
                             enabled = onboardingUiState.isDismissable,
                             modifier = Modifier
-                                .padding(horizontal = 40.dp)
-                                .width(364.dp)
+                                .padding(horizontal = 24.dp)
+                                .widthIn(364.dp)
+                                .fillMaxWidth()
                         ) {
                             Text(
                                 text = stringResource(R.string.done)
@@ -381,9 +382,7 @@ fun TopicIcon(
         model = imageUrl,
         contentDescription = null, // decorative
         colorFilter = ColorFilter.tint(MaterialTheme.colorScheme.primary),
-        modifier = modifier
-            .padding(10.dp)
-            .size(32.dp)
+        modifier = modifier.size(32.dp)
     )
 }
 

feature/interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/InterestsItem.kt

@@ -66,7 +66,7 @@ fun InterestsItem(
                 .padding(vertical = itemSeparation)
         ) {
             InterestsIcon(topicImageUrl, iconModifier.size(64.dp))
-            Spacer(modifier = Modifier.width(16.dp))
+            Spacer(modifier = Modifier.width(24.dp))
             InterestContent(name, description)
         }
         NiaIconToggleButton(

feature/interests/src/main/java/com/google/samples/apps/nowinandroid/feature/interests/TabContent.kt

@@ -38,9 +38,9 @@ fun TopicsTabContent(
 ) {
     LazyColumn(
         modifier = modifier
-            .padding(horizontal = 16.dp)
+            .padding(horizontal = 24.dp)
             .testTag("interests:topics"),
-        contentPadding = PaddingValues(top = 8.dp)
+        contentPadding = PaddingValues(vertical = 16.dp)
     ) {
         topics.forEach { followableTopic ->
             val topicId = followableTopic.topic.id