Skip to content

Commit 350e7b1

Browse files
authored
Merge pull request #1144 from SimonMarquis/move-fakes-to-data-test-module
Move `:core:data` fake repositories to `:core:data-test`
2 parents 4055fb2 + dc2f435 commit 350e7b1

File tree

6 files changed

+16
-16
lines changed

6 files changed

+16
-16
lines changed

core/data-test/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/test/TestDataModule.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ import com.google.samples.apps.nowinandroid.core.data.repository.RecentSearchRep
2222
import com.google.samples.apps.nowinandroid.core.data.repository.SearchContentsRepository
2323
import com.google.samples.apps.nowinandroid.core.data.repository.TopicsRepository
2424
import com.google.samples.apps.nowinandroid.core.data.repository.UserDataRepository
25-
import com.google.samples.apps.nowinandroid.core.data.repository.fake.FakeNewsRepository
26-
import com.google.samples.apps.nowinandroid.core.data.repository.fake.FakeRecentSearchRepository
27-
import com.google.samples.apps.nowinandroid.core.data.repository.fake.FakeSearchContentsRepository
28-
import com.google.samples.apps.nowinandroid.core.data.repository.fake.FakeTopicsRepository
29-
import com.google.samples.apps.nowinandroid.core.data.repository.fake.FakeUserDataRepository
25+
import com.google.samples.apps.nowinandroid.core.data.test.repository.FakeNewsRepository
26+
import com.google.samples.apps.nowinandroid.core.data.test.repository.FakeRecentSearchRepository
27+
import com.google.samples.apps.nowinandroid.core.data.test.repository.FakeSearchContentsRepository
28+
import com.google.samples.apps.nowinandroid.core.data.test.repository.FakeTopicsRepository
29+
import com.google.samples.apps.nowinandroid.core.data.test.repository.FakeUserDataRepository
3030
import com.google.samples.apps.nowinandroid.core.data.util.NetworkMonitor
3131
import com.google.samples.apps.nowinandroid.core.data.util.TimeZoneMonitor
3232
import dagger.Binds
@@ -39,7 +39,7 @@ import dagger.hilt.testing.TestInstallIn
3939
components = [SingletonComponent::class],
4040
replaces = [DataModule::class],
4141
)
42-
interface TestDataModule {
42+
internal interface TestDataModule {
4343
@Binds
4444
fun bindsTopicRepository(
4545
fakeTopicsRepository: FakeTopicsRepository,

core/data/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/fake/FakeNewsRepository.kt renamed to core/data-test/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/test/repository/FakeNewsRepository.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.google.samples.apps.nowinandroid.core.data.repository.fake
17+
package com.google.samples.apps.nowinandroid.core.data.test.repository
1818

1919
import com.google.samples.apps.nowinandroid.core.data.Synchronizer
2020
import com.google.samples.apps.nowinandroid.core.data.model.asEntity
@@ -39,7 +39,7 @@ import javax.inject.Inject
3939
* This allows us to run the app with fake data, without needing an internet connection or working
4040
* backend.
4141
*/
42-
class FakeNewsRepository @Inject constructor(
42+
internal class FakeNewsRepository @Inject constructor(
4343
@Dispatcher(IO) private val ioDispatcher: CoroutineDispatcher,
4444
private val datasource: FakeNiaNetworkDataSource,
4545
) : NewsRepository {

core/data/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/fake/FakeRecentSearchRepository.kt renamed to core/data-test/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/test/repository/FakeRecentSearchRepository.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.google.samples.apps.nowinandroid.core.data.repository.fake
17+
package com.google.samples.apps.nowinandroid.core.data.test.repository
1818

1919
import com.google.samples.apps.nowinandroid.core.data.model.RecentSearchQuery
2020
import com.google.samples.apps.nowinandroid.core.data.repository.RecentSearchRepository
@@ -25,7 +25,7 @@ import javax.inject.Inject
2525
/**
2626
* Fake implementation of the [RecentSearchRepository]
2727
*/
28-
class FakeRecentSearchRepository @Inject constructor() : RecentSearchRepository {
28+
internal class FakeRecentSearchRepository @Inject constructor() : RecentSearchRepository {
2929
override suspend fun insertOrReplaceRecentSearch(searchQuery: String) = Unit
3030

3131
override fun getRecentSearchQueries(limit: Int): Flow<List<RecentSearchQuery>> =

core/data/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/fake/FakeSearchContentsRepository.kt renamed to core/data-test/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/test/repository/FakeSearchContentsRepository.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.google.samples.apps.nowinandroid.core.data.repository.fake
17+
package com.google.samples.apps.nowinandroid.core.data.test.repository
1818

1919
import com.google.samples.apps.nowinandroid.core.data.repository.SearchContentsRepository
2020
import com.google.samples.apps.nowinandroid.core.model.data.SearchResult
@@ -25,7 +25,7 @@ import javax.inject.Inject
2525
/**
2626
* Fake implementation of the [SearchContentsRepository]
2727
*/
28-
class FakeSearchContentsRepository @Inject constructor() : SearchContentsRepository {
28+
internal class FakeSearchContentsRepository @Inject constructor() : SearchContentsRepository {
2929

3030
override suspend fun populateFtsData() = Unit
3131
override fun searchContents(searchQuery: String): Flow<SearchResult> = flowOf()

core/data/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/fake/FakeTopicsRepository.kt renamed to core/data-test/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/test/repository/FakeTopicsRepository.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.google.samples.apps.nowinandroid.core.data.repository.fake
17+
package com.google.samples.apps.nowinandroid.core.data.test.repository
1818

1919
import com.google.samples.apps.nowinandroid.core.data.Synchronizer
2020
import com.google.samples.apps.nowinandroid.core.data.repository.TopicsRepository
@@ -36,7 +36,7 @@ import javax.inject.Inject
3636
* This allows us to run the app with fake data, without needing an internet connection or working
3737
* backend.
3838
*/
39-
class FakeTopicsRepository @Inject constructor(
39+
internal class FakeTopicsRepository @Inject constructor(
4040
@Dispatcher(IO) private val ioDispatcher: CoroutineDispatcher,
4141
private val datasource: FakeNiaNetworkDataSource,
4242
) : TopicsRepository {

core/data/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/repository/fake/FakeUserDataRepository.kt renamed to core/data-test/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/test/repository/FakeUserDataRepository.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.google.samples.apps.nowinandroid.core.data.repository.fake
17+
package com.google.samples.apps.nowinandroid.core.data.test.repository
1818

1919
import com.google.samples.apps.nowinandroid.core.data.repository.UserDataRepository
2020
import com.google.samples.apps.nowinandroid.core.datastore.NiaPreferencesDataSource
@@ -30,7 +30,7 @@ import javax.inject.Inject
3030
* This allows us to run the app with fake data, without needing an internet connection or working
3131
* backend.
3232
*/
33-
class FakeUserDataRepository @Inject constructor(
33+
internal class FakeUserDataRepository @Inject constructor(
3434
private val niaPreferencesDataSource: NiaPreferencesDataSource,
3535
) : UserDataRepository {
3636

0 commit comments

Comments
 (0)