Skip to content

Commit 373dae2

Browse files
authored
Merge pull request #1006 from thatfiredev/rpf-update-firebase-ktx
upgrade to Firebase BoM 32.5.0 and remove Firebase KTX
2 parents 5aba8ea + 3c6366d commit 373dae2

File tree

7 files changed

+27
-26
lines changed

7 files changed

+27
-26
lines changed

app/dependencies/prodReleaseRuntimeClasspath.txt

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -147,12 +147,12 @@ com.google.android.gms:play-services-ads-identifier:18.0.0
147147
com.google.android.gms:play-services-base:18.0.1
148148
com.google.android.gms:play-services-basement:18.1.0
149149
com.google.android.gms:play-services-cloud-messaging:17.0.1
150-
com.google.android.gms:play-services-measurement-api:21.4.0
151-
com.google.android.gms:play-services-measurement-base:21.4.0
152-
com.google.android.gms:play-services-measurement-impl:21.4.0
153-
com.google.android.gms:play-services-measurement-sdk-api:21.4.0
154-
com.google.android.gms:play-services-measurement-sdk:21.4.0
155-
com.google.android.gms:play-services-measurement:21.4.0
150+
com.google.android.gms:play-services-measurement-api:21.5.0
151+
com.google.android.gms:play-services-measurement-base:21.5.0
152+
com.google.android.gms:play-services-measurement-impl:21.5.0
153+
com.google.android.gms:play-services-measurement-sdk-api:21.5.0
154+
com.google.android.gms:play-services-measurement-sdk:21.5.0
155+
com.google.android.gms:play-services-measurement:21.5.0
156156
com.google.android.gms:play-services-oss-licenses:17.0.1
157157
com.google.android.gms:play-services-stats:17.0.2
158158
com.google.android.gms:play-services-tasks:18.0.2
@@ -163,16 +163,15 @@ com.google.dagger:hilt-android:2.51.1
163163
com.google.dagger:hilt-core:2.51.1
164164
com.google.errorprone:error_prone_annotations:2.11.0
165165
com.google.firebase:firebase-abt:21.1.1
166-
com.google.firebase:firebase-analytics-ktx:21.4.0
167-
com.google.firebase:firebase-analytics:21.4.0
166+
com.google.firebase:firebase-analytics-ktx:21.5.0
167+
com.google.firebase:firebase-analytics:21.5.0
168168
com.google.firebase:firebase-annotations:16.2.0
169-
com.google.firebase:firebase-bom:32.4.0
169+
com.google.firebase:firebase-bom:32.5.0
170170
com.google.firebase:firebase-common-ktx:20.4.2
171171
com.google.firebase:firebase-common:20.4.2
172172
com.google.firebase:firebase-components:17.1.5
173173
com.google.firebase:firebase-config:21.5.0
174-
com.google.firebase:firebase-crashlytics-ktx:18.5.0
175-
com.google.firebase:firebase-crashlytics:18.5.0
174+
com.google.firebase:firebase-crashlytics:18.5.1
176175
com.google.firebase:firebase-datatransport:18.1.8
177176
com.google.firebase:firebase-encoders-json:18.0.1
178177
com.google.firebase:firebase-encoders-proto:16.0.0
@@ -181,9 +180,7 @@ com.google.firebase:firebase-iid-interop:17.1.0
181180
com.google.firebase:firebase-installations-interop:17.1.1
182181
com.google.firebase:firebase-installations:17.2.0
183182
com.google.firebase:firebase-measurement-connector:19.0.0
184-
com.google.firebase:firebase-messaging-ktx:23.3.0
185-
com.google.firebase:firebase-messaging:23.3.0
186-
com.google.firebase:firebase-perf-ktx:20.5.0
183+
com.google.firebase:firebase-messaging:23.3.1
187184
com.google.firebase:firebase-perf:20.5.0
188185
com.google.firebase:firebase-sessions:1.1.0
189186
com.google.firebase:protolite-well-known-types:18.0.0

app/prodRelease-badging.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ application-icon-640:'res/mipmap-anydpi-v26/ic_launcher.xml'
105105
application-icon-65534:'res/mipmap-anydpi-v26/ic_launcher.xml'
106106
application: label='Now in Android' icon='res/mipmap-anydpi-v26/ic_launcher.xml'
107107
launchable-activity: name='com.google.samples.apps.nowinandroid.MainActivity' label='' icon=''
108+
property: name='android.adservices.AD_SERVICES_CONFIG' resource='res/xml/ga_ad_services_config.xml'
108109
uses-library-not-required:'androidx.window.extensions'
109110
uses-library-not-required:'androidx.window.sidecar'
110111
uses-library-not-required:'android.ext.adservices'

app/src/main/AndroidManifest.xml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@
2020
<uses-permission android:name="android.permission.INTERNET" />
2121

2222
<!--
23-
Firebase automatically adds the AD_ID permission, even though we don't use it. If you use this
24-
permission you must declare how you're using it to Google Play, otherwise the app will be
25-
rejected when publishing it. To avoid this we remove the permission entirely.
23+
Firebase automatically adds these AD_ID and ADSERVICES permissions, even though we don't use them.
24+
If you use these permissions you must declare how you're using them to Google Play, otherwise the
25+
app will be rejected when publishing it. To avoid this we remove the permissions entirely.
2626
-->
2727
<uses-permission android:name="com.google.android.gms.permission.AD_ID" tools:node="remove"/>
28+
<uses-permission android:name="android.permission.ACCESS_ADSERVICES_ATTRIBUTION" tools:node="remove"/>
29+
<uses-permission android:name="android.permission.ACCESS_ADSERVICES_AD_ID" tools:node="remove"/>
2830

2931
<application
3032
android:name=".NiaApplication"

core/analytics/src/prod/kotlin/com/google/samples/apps/nowinandroid/core/analytics/AnalyticsModule.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
package com.google.samples.apps.nowinandroid.core.analytics
1818

19+
import com.google.firebase.Firebase
1920
import com.google.firebase.analytics.FirebaseAnalytics
20-
import com.google.firebase.analytics.ktx.analytics
21-
import com.google.firebase.ktx.Firebase
21+
import com.google.firebase.analytics.analytics
2222
import dagger.Binds
2323
import dagger.Module
2424
import dagger.Provides

core/analytics/src/prod/kotlin/com/google/samples/apps/nowinandroid/core/analytics/FirebaseAnalyticsHelper.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
package com.google.samples.apps.nowinandroid.core.analytics
1818

1919
import com.google.firebase.analytics.FirebaseAnalytics
20-
import com.google.firebase.analytics.ktx.logEvent
20+
import com.google.firebase.analytics.logEvent
2121
import javax.inject.Inject
2222

2323
/**

gradle/libs.versions.toml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ androidxWindowManager = "1.3.0-alpha03"
3232
androidxWork = "2.9.0"
3333
coil = "2.6.0"
3434
dependencyGuard = "0.5.0"
35-
firebaseBom = "32.4.0"
35+
firebaseBom = "32.5.0"
3636
firebaseCrashlyticsPlugin = "2.9.9"
3737
firebasePerfPlugin = "1.4.2"
3838
gmsPlugin = "4.4.1"
@@ -113,9 +113,10 @@ coil-kt-compose = { group = "io.coil-kt", name = "coil-compose", version.ref = "
113113
coil-kt-svg = { group = "io.coil-kt", name = "coil-svg", version.ref = "coil" }
114114
firebase-analytics = { group = "com.google.firebase", name = "firebase-analytics-ktx" }
115115
firebase-bom = { group = "com.google.firebase", name = "firebase-bom", version.ref = "firebaseBom" }
116-
firebase-cloud-messaging = { group = "com.google.firebase", name = "firebase-messaging-ktx" }
117-
firebase-crashlytics = { group = "com.google.firebase", name = "firebase-crashlytics-ktx" }
118-
firebase-performance = { group = "com.google.firebase", name = "firebase-perf-ktx" }
116+
firebase-cloud-messaging = { group = "com.google.firebase", name = "firebase-messaging" }
117+
firebase-crashlytics = { group = "com.google.firebase", name = "firebase-crashlytics" }
118+
firebase-performance = { group = "com.google.firebase", name = "firebase-perf" }
119+
firebase-performance-gradle = { group = "com.google.firebase", name = "perf-plugin", version.ref = "firebasePerfPlugin" }
119120
google-oss-licenses = { group = "com.google.android.gms", name = "play-services-oss-licenses", version.ref = "googleOss" }
120121
google-oss-licenses-plugin = { group = "com.google.android.gms", name = "oss-licenses-plugin", version.ref = "googleOssPlugin" }
121122
hilt-android = { group = "com.google.dagger", name = "hilt-android", version.ref = "hilt" }

sync/work/src/prod/kotlin/com/google/samples/apps/nowinandroid/sync/di/SyncModule.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
package com.google.samples.apps.nowinandroid.sync.di
1818

19-
import com.google.firebase.ktx.Firebase
19+
import com.google.firebase.Firebase
2020
import com.google.firebase.messaging.FirebaseMessaging
21-
import com.google.firebase.messaging.ktx.messaging
21+
import com.google.firebase.messaging.messaging
2222
import com.google.samples.apps.nowinandroid.core.data.util.SyncManager
2323
import com.google.samples.apps.nowinandroid.sync.status.FirebaseSyncSubscriber
2424
import com.google.samples.apps.nowinandroid.sync.status.SyncSubscriber

0 commit comments

Comments
 (0)