Skip to content

Commit 3cf6f64

Browse files
authored
Merge pull request #1436 from android/dturner-patch-1
Made pull request instructions clearer
2 parents 3b02f81 + 7c16da9 commit 3cf6f64

File tree

1 file changed

+16
-17
lines changed

1 file changed

+16
-17
lines changed

.github/pull_request_template.md

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,25 @@
1-
_Thanks for submitting a pull request. Please include the following information._
1+
**DO NOT CREATE A PULL REQUEST WITHOUT READING THESE INSTRUCTIONS**
22

3-
**What I have done and why**
3+
## Instructions
4+
Thanks for submitting a pull request. To accept your pull request we need you do a few things:
5+
6+
**If this is your first pull request**
47

5-
_Include a summary of what your pull request contains, and why you have made these changes._
8+
- [Sign the contributors license agreement](https://cla.developers.google.com/)
69

7-
Fixes #<issue_number_goes_here>
10+
**Ensure tests pass and code is formatted correctly**
811

9-
**How I'm testing it**
12+
- Run local tests on the `DemoDebug` variant by running `./gradlew testDemoDebug`
13+
- Fix code formatting: `./gradlew --init-script gradle/init.gradle.kts spotlessApply`
1014

11-
_Choose at least one:_
12-
- Unit tests
13-
- UI tests
14-
- Screenshot tests
15-
- N/A _(provide justification)_
15+
**Add a description**
1616

17-
**Do tests pass?**
18-
- [ ] Run local tests on `DemoDebug` variant: `./gradlew testDemoDebug`
19-
- [ ] Check formatting: `./gradlew --init-script gradle/init.gradle.kts spotlessApply`
17+
We need to know what you've done and why you've done it. Include a summary of what your pull request contains, and why you have made these changes. Include links to any relevant issues which it fixes.
2018

21-
**Is this your first pull request?**
22-
- [ ] [Sign the CLA](https://cla.developers.google.com/)
23-
- [ ] Run `./tools/setup.sh`
24-
- [ ] Import the code formatting style as explained in [the setup script](/tools/setup.sh#L40).
19+
[Here's an example](https://github.com/android/nowinandroid/pull/1257).
2520

21+
**NOW DELETE THIS LINE AND EVERYTHING ABOVE IT**
22+
23+
**What I have done and why**
2624

25+
\<add your PR description here\>

0 commit comments

Comments
 (0)