Skip to content

Commit 51379a2

Browse files
fix #614 : removed unused onItemClick parameter from NewsResourceCardList.kt
1. removed the unused onItemClick parameter 2. removed now redundant variables it used 3. removed its description from the comments.
1 parent d905701 commit 51379a2

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,18 @@ import com.google.samples.apps.nowinandroid.core.model.data.UserNewsResource
3131
* [UserNewsResource]s.
3232
*
3333
* [onToggleBookmark] defines the action invoked when a user wishes to bookmark an item
34-
* [onItemClick] optional parameter for action to be performed when the card is clicked. The
35-
* default action launches an intent matching the card.
34+
* Default action launches an intent matching the card.
3635
*/
3736
fun LazyListScope.userNewsResourceCardItems(
3837
items: List<UserNewsResource>,
3938
onToggleBookmark: (item: UserNewsResource) -> Unit,
4039
onNewsResourceViewed: (String) -> Unit,
41-
onItemClick: ((item: UserNewsResource) -> Unit)? = null,
4240
onTopicClick: (String) -> Unit,
4341
itemModifier: Modifier = Modifier,
4442
) = items(
4543
items = items,
4644
key = { it.id },
4745
itemContent = { userNewsResource ->
48-
val resourceUrl = Uri.parse(userNewsResource.url)
49-
val backgroundColor = MaterialTheme.colorScheme.background.toArgb()
50-
val context = LocalContext.current
5146
val analyticsHelper = LocalAnalyticsHelper.current
5247

5348
NewsResourceCardExpanded(
@@ -59,10 +54,6 @@ fun LazyListScope.userNewsResourceCardItems(
5954
analyticsHelper.logNewsResourceOpened(
6055
newsResourceId = userNewsResource.id,
6156
)
62-
when (onItemClick) {
63-
null -> launchCustomChromeTab(context, resourceUrl, backgroundColor)
64-
else -> onItemClick(userNewsResource)
65-
}
6657
onNewsResourceViewed(userNewsResource.id)
6758
},
6859
onTopicClick = onTopicClick,

0 commit comments

Comments
 (0)