Skip to content

Commit 547cb19

Browse files
authored
Merge pull request #1256 from lnbs97/main
Fix typo in TopicViewModel.kt
2 parents 74d1d91 + 96d210d commit 547cb19

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

feature/topic/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/TopicScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ internal fun TopicRoute(
7979
viewModel: TopicViewModel = hiltViewModel(),
8080
) {
8181
val topicUiState: TopicUiState by viewModel.topicUiState.collectAsStateWithLifecycle()
82-
val newsUiState: NewsUiState by viewModel.newUiState.collectAsStateWithLifecycle()
82+
val newsUiState: NewsUiState by viewModel.newsUiState.collectAsStateWithLifecycle()
8383

8484
TrackScreenViewEvent(screenName = "Topic: ${viewModel.topicId}")
8585
TopicScreen(

feature/topic/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/topic/TopicViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class TopicViewModel @Inject constructor(
6262
initialValue = TopicUiState.Loading,
6363
)
6464

65-
val newUiState: StateFlow<NewsUiState> = newsUiState(
65+
val newsUiState: StateFlow<NewsUiState> = newsUiState(
6666
topicId = topicArgs.topicId,
6767
userDataRepository = userDataRepository,
6868
userNewsResourceRepository = userNewsResourceRepository,

feature/topic/src/test/kotlin/com/google/samples/apps/nowinandroid/feature/topic/TopicViewModelTest.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ class TopicViewModelTest {
9191

9292
@Test
9393
fun uiStateNews_whenInitialized_thenShowLoading() = runTest {
94-
assertEquals(NewsUiState.Loading, viewModel.newUiState.value)
94+
assertEquals(NewsUiState.Loading, viewModel.newsUiState.value)
9595
}
9696

9797
@Test
@@ -117,7 +117,7 @@ class TopicViewModelTest {
117117
topicsRepository.sendTopics(testInputTopics.map { it.topic })
118118
userDataRepository.setFollowedTopicIds(setOf(testInputTopics[1].topic.id))
119119
val topicUiState = viewModel.topicUiState.value
120-
val newsUiState = viewModel.newUiState.value
120+
val newsUiState = viewModel.newsUiState.value
121121

122122
assertIs<TopicUiState.Success>(topicUiState)
123123
assertIs<NewsUiState.Loading>(newsUiState)
@@ -131,15 +131,15 @@ class TopicViewModelTest {
131131
val collectJob = launch(UnconfinedTestDispatcher()) {
132132
combine(
133133
viewModel.topicUiState,
134-
viewModel.newUiState,
134+
viewModel.newsUiState,
135135
::Pair,
136136
).collect()
137137
}
138138
topicsRepository.sendTopics(testInputTopics.map { it.topic })
139139
userDataRepository.setFollowedTopicIds(setOf(testInputTopics[1].topic.id))
140140
newsRepository.sendNewsResources(sampleNewsResources)
141141
val topicUiState = viewModel.topicUiState.value
142-
val newsUiState = viewModel.newUiState.value
142+
val newsUiState = viewModel.newsUiState.value
143143

144144
assertIs<TopicUiState.Success>(topicUiState)
145145
assertIs<NewsUiState.Success>(newsUiState)

0 commit comments

Comments
 (0)